From: Simon Josefsson <jas@extundo.com>
Cc: ding@gnus.org
Subject: Re: pgg passphrase caching
Date: Tue, 29 Apr 2003 02:45:43 +0200 [thread overview]
Message-ID: <ilu1xzmw2q0.fsf@latte.josefsson.org> (raw)
In-Reply-To: <86wuhejji1.fsf@jochen.rijnh.nl> (Jochen =?iso-8859-1?q?K=FCpper's?= message of "Tue, 29 Apr 2003 01:21:42 +0200")
Jochen Küpper <jochen@jochen-kuepper.de> writes:
> The problem was introduced between cvs' -D 20030416 and 20030417.
Thanks, it is the pgg-default-user-id addition to mml2015.el that
caused the problem:
(defun mml2015-pgg-sign (cont)
(let ((pgg-errors-buffer mml2015-result-buffer)
(boundary (funcall mml-boundary-function (incf mml-multipart-number)))
(pgg-default-user-id (or (message-options-get 'message-sender)
pgg-default-user-id)))
...
The problem is that (message-options-get 'message-sender) always
return something, where we'd really only want it to return something
if the user specified a MML sender=0xfoobar tag. Please upgrade to
HEAD to try the following patch.
2003-04-29 Simon Josefsson <jas@extundo.com>
* mml2015.el (mml2015-pgg-sign): Use mml-sender instead of
message-sender.
* mml.el (mml-generate-mime-1): Set mml-sender too.
--- mml.el.~6.74.~ Sun Apr 27 17:01:37 2003
+++ mml.el Tue Apr 29 02:43:15 2003
@@ -541,7 +541,8 @@
mml-encrypt-alist))
sender recipients)
(when (or sign-item encrypt-item)
- (if (setq sender (cdr (assq 'sender cont)))
+ (when (setq sender (cdr (assq 'sender cont)))
+ (message-options-set 'mml-sender sender)
(message-options-set 'message-sender sender))
(if (setq recipients (cdr (assq 'recipients cont)))
(message-options-set 'message-recipients recipients))
--- mml2015.el.~6.60.~ Wed Apr 16 21:19:32 2003
+++ mml2015.el Tue Apr 29 02:43:28 2003
@@ -807,7 +807,7 @@
(defun mml2015-pgg-sign (cont)
(let ((pgg-errors-buffer mml2015-result-buffer)
(boundary (funcall mml-boundary-function (incf mml-multipart-number)))
- (pgg-default-user-id (or (message-options-get 'message-sender)
+ (pgg-default-user-id (or (message-options-get 'mml-sender)
pgg-default-user-id)))
(unless (pgg-sign-region (point-min) (point-max))
(pop-to-buffer mml2015-result-buffer)
next prev parent reply other threads:[~2003-04-29 0:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-27 19:24 Jochen Küpper
2003-04-27 20:36 ` Simon Josefsson
2003-04-28 23:21 ` Jochen Küpper
2003-04-29 0:45 ` Simon Josefsson [this message]
2003-04-29 7:50 ` Jochen Küpper
2003-04-27 23:26 ` Michael Teichgräber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ilu1xzmw2q0.fsf@latte.josefsson.org \
--to=jas@extundo.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).