Newsgroup header sorted last in summary toggle

Newsgroup header sorted last in summary toggle

[Klaus Straubinger]

The function gnus-summary-toggle-header does

    (run-hooks 'gnus-article-decode-hook)

which in turn calls, at least with the default value of this hook
variable, the function article-decode-group-name. There,

    (nnheader-replace-header "Newsgroups" ...

takes place, which deletes the Newsgroups header and inserts it right
again, but at the end of headers, destroying the beautiful sort order
of the headers.

For me it seems not necessary to call this function at all, but who am
I to know it.

The problem seems to be a result of a recent change with this ChangeLog
entry:

    2003-02-26  Simon Josefsson  <jas@extundo.com>

            * gnus-sum.el (gnus-summary-toggle-header): Run
            gnus-article-decode-hook instead of calling a-decode-encoded-words
            directly (the latter is run as part of the former).

-- 
Klaus Straubinger

Re: Newsgroup header sorted last in summary toggle

[Simon Josefsson]

Klaus Straubinger <ksnetz@arcor.de> writes:

> The function gnus-summary-toggle-header does
>
>     (run-hooks 'gnus-article-decode-hook)
>
> which in turn calls, at least with the default value of this hook
> variable, the function article-decode-group-name. There,
>
>     (nnheader-replace-header "Newsgroups" ...
>
> takes place, which deletes the Newsgroups header and inserts it right
> again, but at the end of headers, destroying the beautiful sort order
> of the headers.
>
> For me it seems not necessary to call this function at all, but who am
> I to know it.

Right, I have now made it less destructive.  Thanks for pointing this
out.

(It would be nice if `article-decode-group-name' didn't depend on
*Original Article* buffer, but I wasn't able to make it so; I tried
various combinations of string-as-unibyte, string-make-unibyte and
reordering gnus-article-decode-hook.  Maybe someone would like to take
a look on how to do it properly.)