Bug and fix in advanced scoring with < > <= >=

Bug and fix in advanced scoring with < > <= >=

[Scott A Crosby]

In advanced scoring, if you have, for example:

 ((|
   ("lines" 400 >)) 1000)

This does not match if the number of lines is > 400, but rather
matches if 400 > the number of lines...

See:

(defun gnus-advanced-integer (index match type)
  (if (not (memq type '(< > <= >= =)))
      (error "No such integer score type: %s" type)
    (funcall type match (or (aref gnus-advanced-headers index) 0))))

This is counter intuitive. For example, these two score rules mean
different things. (all messages that don't have exactly 400 lines will
be scored up 3000, not score up all messages > 400 lines by 3000 twice
which is what is intended.)

(((|
    ("lines" 400 >))
   3000)
 ("lines"
  (400 3000 nil >)))


What we want is:

(defun gnus-advanced-integer (index match type)
  (if (not (memq type '(< > <= >= =)))
      (error "No such integer score type: %s" type)
    (funcall type (or (aref gnus-advanced-headers index) 0) match)))


Scott

Re: Bug and fix in advanced scoring with < > <= >=

[Simon Josefsson]

Scott A Crosby <scrosby@cs.rice.edu> writes:

> What we want is:

Added, thanks.