gnus-union needs a lot of time

gnus-union needs a lot of time

[Christoph Conrad]

Hi,

downloading articles with the Gnus agent did spent longer and longer
in the last months, even when there are no articles to download. I
made an M-x elp-instrument-package <RET> gnus- <RET> and got the
following results (excerpt):

gnus-agent-fetch-headers 11 44.600695     4.0546086363
gnus-union               68 41.160040000  0.6052947058

Over 90% of the time is spent in gnus-union, which in fact is an alias
to 'union on my computer.

I am wondering if there is a possibility to speed up this function or
the information which is processed here?

Best regards,
cu, -cc-
-- 
=> GNU Emacs Webring @ <http://www.gnusoftware.com/WebRing/> <=
Look Ma, this man can twist his fingers as if they were made of rubber,
isn't that amazing? -- Not really, he's been using emacs for years...!

Re: gnus-union needs a lot of time

[Simon Josefsson]

Christoph Conrad <christoph.conrad@gmx.de> writes:

> Hi,
>
> downloading articles with the Gnus agent did spent longer and longer
> in the last months, even when there are no articles to download. I
> made an M-x elp-instrument-package <RET> gnus- <RET> and got the
> following results (excerpt):
>
> gnus-agent-fetch-headers 11 44.600695     4.0546086363
> gnus-union               68 41.160040000  0.6052947058
>
> Over 90% of the time is spent in gnus-union, which in fact is an alias
> to 'union on my computer.
>
> I am wondering if there is a possibility to speed up this function or
> the information which is processed here?

I guess so.  Does this patch help?  Maybe you could try using
`gnus-add-to-range' instead if this doesn't improve it too much.  New
elp results would be interesting.

Index: gnus-agent.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-agent.el,v
retrieving revision 6.25
diff -u -u -w -r6.25 gnus-agent.el
--- gnus-agent.el	2001/11/21 06:24:47	6.25
+++ gnus-agent.el	2001/11/29 15:43:30
@@ -999,9 +999,8 @@
 	(file (gnus-agent-article-name ".overview" group)))
     ;; Add article with marks to list of article headers we want to fetch.
     (dolist (arts (gnus-info-marks (gnus-get-info group)))
-      (setq articles (gnus-union (gnus-uncompress-sequence (cdr arts))
-			    articles)))
-    (setq articles (sort articles '<))
+      (setq articles (gnus-range-add articles (cdr arts))))
+    (setq articles (sort (gnus-uncompress-sequence articles) '<))
     ;; Remove known articles.
     (when (gnus-agent-load-alist group)
       (setq articles (gnus-sorted-intersection

Re: gnus-union needs a lot of time

[Christoph Conrad]

Hello Simon,

you wrote:

    > I guess so. Does this patch help? Maybe you could try using
    > `gnus-add-to-range' instead if this doesn't improve it too much.
    > New elp results would be interesting.

gnus-agent-fetch-headers is about six times faster now (for me). GREAT
speedup!!! Thanks!!!!
            
Best regards,
cu, -cc-
-- 
=> GNU Emacs Webring @ <http://www.gnusoftware.com/WebRing/> <=
Look Ma, this man can twist his fingers as if they were made of rubber,
isn't that amazing? -- Not really, he's been using emacs for years...!

Re: gnus-union needs a lot of time

[Simon Josefsson]

Christoph Conrad <christoph.conrad@gmx.de> writes:

>     > I guess so. Does this patch help? Maybe you could try using
>     > `gnus-add-to-range' instead if this doesn't improve it too much.
>     > New elp results would be interesting.
>
> gnus-agent-fetch-headers is about six times faster now (for me). GREAT
> speedup!!! Thanks!!!!

I've committed it, thanks for pointing out a place for optimization.