mouse-1 in group mode selects group?

mouse-1 in group mode selects group?

[Simon Josefsson]

What about using mouse-1 to enter groups from the group buffer?

If you want to experiment with it, evaluate this:

(define-key gnus-group-mode-map (kbd "<mouse-1>") 'gnus-mouse-pick-topic)

I know it isn't very emacsish, but is there much opposition against it?

Index: gnus-group.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-group.el,v
retrieving revision 6.73
diff -u -p -u -w -r6.73 gnus-group.el
--- gnus-group.el	2002/04/23 01:18:09	6.73
+++ gnus-group.el	2002/04/29 18:25:50
@@ -577,6 +577,7 @@ simple manner.")
     "\C-c\C-i" gnus-info-find-node
     "\M-e" gnus-group-edit-group-method
     "^" gnus-group-enter-server-mode
+    gnus-mouse-1 gnus-mouse-pick-group
     gnus-mouse-2 gnus-mouse-pick-group
     "<" beginning-of-buffer
     ">" end-of-buffer

Re: mouse-1 in group mode selects group?

[Simon Josefsson]

Simon Josefsson <jas@extundo.com> writes:

> +    gnus-mouse-1 gnus-mouse-pick-group

That patch wasn't very good, this one should work (and makes mouse-1
pick articles in the summary buffer as well):

Index: lisp/gnus-group.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-group.el,v
retrieving revision 6.73
diff -u -p -r6.73 gnus-group.el
--- lisp/gnus-group.el	2002/04/23 01:18:09	6.73
+++ lisp/gnus-group.el	2002/04/29 18:40:25
@@ -577,6 +577,7 @@ simple manner.")
     "\C-c\C-i" gnus-info-find-node
     "\M-e" gnus-group-edit-group-method
     "^" gnus-group-enter-server-mode
+    gnus-mouse-1 gnus-mouse-pick-group
     gnus-mouse-2 gnus-mouse-pick-group
     "<" beginning-of-buffer
     ">" end-of-buffer
Index: lisp/gnus-sum.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
retrieving revision 6.207
diff -u -p -r6.207 gnus-sum.el
--- lisp/gnus-sum.el	2002/04/17 08:54:21	6.207
+++ lisp/gnus-sum.el	2002/04/29 18:40:26
@@ -1565,6 +1565,7 @@ increase the score of each group you rea
     "q" gnus-summary-exit
     "Q" gnus-summary-exit-no-update
     "\C-c\C-i" gnus-info-find-node
+    gnus-mouse-1 gnus-mouse-pick-article
     gnus-mouse-2 gnus-mouse-pick-article
     "m" gnus-summary-mail-other-window
     "a" gnus-summary-post-news
Index: lisp/gnus-ems.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-ems.el,v
retrieving revision 6.20
diff -u -p -r6.20 gnus-ems.el
--- lisp/gnus-ems.el	2002/04/12 11:51:01	6.20
+++ lisp/gnus-ems.el	2002/04/29 18:40:27
@@ -32,6 +32,7 @@
 
 ;;; Function aliases later to be redefined for XEmacs usage.
 
+(defvar gnus-mouse-1 [mouse-1])
 (defvar gnus-mouse-2 [mouse-2])
 (defvar gnus-down-mouse-3 [down-mouse-3])
 (defvar gnus-down-mouse-2 [down-mouse-2])
Index: lisp/gnus-xmas.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-xmas.el,v
retrieving revision 6.31
diff -u -p -r6.31 gnus-xmas.el
--- lisp/gnus-xmas.el	2002/02/13 04:10:06	6.31
+++ lisp/gnus-xmas.el	2002/04/29 18:40:27
@@ -91,6 +91,7 @@ Possibly the `etc' directory has not bee
 (defvar gnus-summary-kill-menu)
 (defvar gnus-article-article-menu)
 (defvar gnus-article-treatment-menu)
+(defvar gnus-mouse-1)
 (defvar gnus-mouse-2)
 (defvar standard-display-table)
 (defvar gnus-tree-minimize-window)

Re: mouse-1 in group mode selects group?

[Reiner Steib]

On Mon, Apr 29 2002, Simon Josefsson wrote:

> (define-key gnus-group-mode-map (kbd "<mouse-1>") 'gnus-mouse-pick-topic)
>
> I know it isn't very emacsish, but is there much opposition against it?

I tried, but I don't like it. I often use more than one buffer in one
frame and select the other buffer with <mouse-1> rather than `C-x o'.
This behavior is quite surprising within Emacs, IMHO.

What would the most convenient way to revert this change (if it
becomes the default behavior)? `(define-key gnus-group-mode-map (kbd
"<mouse-1>") 'mouse-select-window)'?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: mouse-1 in group mode selects group?

[Simon Josefsson]

Reiner Steib <4uce.02.r.steib@gmx.net> writes:

> On Mon, Apr 29 2002, Simon Josefsson wrote:
>
>> (define-key gnus-group-mode-map (kbd "<mouse-1>") 'gnus-mouse-pick-topic)
>>
>> I know it isn't very emacsish, but is there much opposition against it?
>
> I tried, but I don't like it. I often use more than one buffer in one
> frame and select the other buffer with <mouse-1> rather than `C-x o'.
> This behavior is quite surprising within Emacs, IMHO.

I guess so.  I hadn't tried it much when I posted it, just wanted to
get people's opinions.  I think I like it though.

Hm. Other UI apps needs two clicks if you haven't focused the window.
Perhaps it can be modified to only enter the group if the cursor was
focused to that window, otherwise simply move point to where you
pointed.

> What would the most convenient way to revert this change (if it
> becomes the default behavior)? `(define-key gnus-group-mode-map (kbd
> "<mouse-1>") 'mouse-select-window)'?

Yes.  Or whatever the original key binding was.

Re: mouse-1 in group mode selects group?

[Kai Großjohann]

Simon Josefsson <jas@extundo.com> writes:

> (define-key gnus-group-mode-map (kbd "<mouse-1>") 'gnus-mouse-pick-topic)
>
> I know it isn't very emacsish, but is there much opposition against it?

I often do <mouse-1> and then hit RET.  This is different from hitting
<mouse-2>, because <mouse-2> also selects the first article.  Just a
data point...

kai
-- 
Silence is foo!