Gnus development mailing list
 help / color / mirror / Atom feed
From: Simon Josefsson <jas@extundo.com>
Cc: ding@gnus.org
Subject: Re: something decodes my headers...
Date: Wed, 11 Jun 2003 06:38:25 +0200	[thread overview]
Message-ID: <iluptllz0se.fsf@latte.josefsson.org> (raw)
In-Reply-To: <m2znkpbh2n.fsf@tnuctip.rychter.com> (Jan Rychter's message of "Tue, 10 Jun 2003 17:20:32 -0700")

Jan Rychter <jan@rychter.com> writes:

>  Simon> I think it might be a bug to invoke mail-extr on 8bit data.
>
> It is. It is really not designed to do that, and it only works for a
> subset of ISO-8859-1. Actually, I have the distinct impression that if
> we removed the 8859-1 support from mail-extr.el, the breakage would be
> noticed by many more people.

Yes.  OTOH, I doubt the Right Thing wrt mail-extr is to patch it.  It
should be rewritten.  But if there is a short patch that solve
problems, I guess it doesn't hurt.  Removing the iso-8859-1 support is
probably not a good thing in practice though, even if I agree in
theory.

>  Simon> Note that if it is bbdb that calls mail-extr, it is probably a
>  Simon> bug in bbdb.  Chopped names could indicate a bug in rfc2047.el
>  Simon> though, there where bugs like this recently (perhaps not fixed?
>  Simon> I recall emacs bugs caused them).
>
> Well, interestingly enough, mail-extract-address-components is being
> called TWICE whenever I enter a message. Once by Gnus, once by BBDB. In
> both cases, an 8-bit string is being passed. Backtraces below, with the
> name of the person in the From: field changed to my spamtrap:
>
>   mail-extract-address-components("full 8bit name <spam@rychter.com>")
>   mm-dissect-buffer(nil nil)

I don't see where the MIME decoding occurs before m-e-a-c is invoked
in that function.  It just seems to invoke (mail-fetch-field "from")
and then m-e-a-c on that string.  Could it be that the incoming
message had raw non-ASCII characters in it?  Does this patch help?
Assuming you leave g-e-a-c to its default value.

--- mm-decode.el.~6.91.~	Fri Apr 25 01:07:04 2003
+++ mm-decode.el	Wed Jun 11 06:37:37 2003
@@ -493,7 +493,8 @@
 	  ;; creates unibyte buffers. This `if', though not a perfect
 	  ;; solution, avoids most of them.
 	  (if from
-	      (setq from (cadr (mail-extract-address-components from))))))
+	      (setq from (cadr (funcall gnus-extract-address-components
+					from))))))
       (when cte
 	(setq cte (mail-header-strip cte)))
       (if (or (not ctl)




  reply	other threads:[~2003-06-11  4:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-05 19:01 Jan Rychter
2003-06-05 21:53 ` Simon Josefsson
2003-06-11  0:20   ` Jan Rychter
2003-06-11  4:38     ` Simon Josefsson [this message]
2003-06-11  4:53       ` Jan Rychter
2003-06-11 10:13         ` Simon Josefsson
2003-06-11 18:38           ` Jan Rychter
2003-06-12 22:30   ` Dave Love
2003-06-12 22:38 ` Dave Love
2003-06-13  6:37   ` Simon Josefsson
2003-06-16  0:12     ` Jan Rychter
2003-06-17 22:26       ` Dave Love
2003-06-18  8:30         ` Jan Rychter
2003-06-17 22:17     ` Dave Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iluptllz0se.fsf@latte.josefsson.org \
    --to=jas@extundo.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).