* ebola in Gnus 5.6.44
@ 1998-10-20 20:34 G. Evermann
1998-10-22 2:02 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: G. Evermann @ 1998-10-20 20:34 UTC (permalink / raw)
When downloding articles for the agent I get lots of the following
messages on the console:
Comparison between integer and character is constant nil (?2 and 0)
[nntp-retrieve-articles, gnus-retrieve-articles, gnus-agent-fetch-articles, gnus-agent-fetch-group-1, <compiled-function of unknown origin>, call-interactively]
This is XEmacs 21.2-beta3 but I have also seen it in 21.0 (also on a
different news-server).
If anybody wants to reproduce this, remember to compile with -debug to
get the ebola notices.
Gunnar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ebola in Gnus 5.6.44
1998-10-20 20:34 ebola in Gnus 5.6.44 G. Evermann
@ 1998-10-22 2:02 ` Lars Magne Ingebrigtsen
1998-10-22 2:37 ` Hrvoje Niksic
0 siblings, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 1998-10-22 2:02 UTC (permalink / raw)
"G. Evermann" <ge204@eng.cam.ac.uk> writes:
> When downloding articles for the agent I get lots of the following
> messages on the console:
>
> Comparison between integer and character is constant nil (?2 and 0)
> [nntp-retrieve-articles, gnus-retrieve-articles, gnus-agent-fetch-articles, gnus-agent-fetch-group-1, <compiled-function of unknown origin>, call-interactively]
Let's see... The only places ?2 appears is in
(eq (following-char) ?2)
and
(memq (char-after (point)) '(?2 ?3 ?4 ?5))
in nntp.el.
Is this verboten?
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ebola in Gnus 5.6.44
1998-10-22 2:02 ` Lars Magne Ingebrigtsen
@ 1998-10-22 2:37 ` Hrvoje Niksic
1998-10-24 4:32 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Hrvoje Niksic @ 1998-10-22 2:37 UTC (permalink / raw)
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Let's see... The only places ?2 appears is in
>
> (eq (following-char) ?2)
[...]
> Is this verboten?
This is technically legal in XEmacs, but confuses the hell out of
ebola-warning code because (following-char) returns 0 (not ?\0 -- the
two are distinct in XEmacs 20) so the code thinks that you might be
comparing integers and characters heedlessly, which you are not.
It's better style to replace (following-char) with (char-after), which
returns nil at eob.
--
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
We must all confront and destroy our own inner geek.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ebola in Gnus 5.6.44
1998-10-22 2:37 ` Hrvoje Niksic
@ 1998-10-24 4:32 ` Lars Magne Ingebrigtsen
1998-10-24 8:53 ` Hrvoje Niksic
0 siblings, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 1998-10-24 4:32 UTC (permalink / raw)
Hrvoje Niksic <hniksic@srce.hr> writes:
> It's better style to replace (following-char) with (char-after), which
> returns nil at eob.
Okidoke. I've now done this thoughout 0.37 (and changed a bunch of
='s to eq's).
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ebola in Gnus 5.6.44
1998-10-24 4:32 ` Lars Magne Ingebrigtsen
@ 1998-10-24 8:53 ` Hrvoje Niksic
0 siblings, 0 replies; 5+ messages in thread
From: Hrvoje Niksic @ 1998-10-24 8:53 UTC (permalink / raw)
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Hrvoje Niksic <hniksic@srce.hr> writes:
>
> > It's better style to replace (following-char) with (char-after), which
> > returns nil at eob.
>
> Okidoke. I've now done this thoughout 0.37
Cool, thanks. XEmacs will be happy. XEmacs will eat someone else.
> (and changed a bunch of ='s to eq's).
Note that, under XEmacs 20, (eq ?A 65) is nil, while (= ?A 65) remains
t. So for some comparisons where characters need to be coerced to
integers, `=' makes sense.
--
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Oh lord won't you buy me a color TV...
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~1998-10-24 8:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-10-20 20:34 ebola in Gnus 5.6.44 G. Evermann
1998-10-22 2:02 ` Lars Magne Ingebrigtsen
1998-10-22 2:37 ` Hrvoje Niksic
1998-10-24 4:32 ` Lars Magne Ingebrigtsen
1998-10-24 8:53 ` Hrvoje Niksic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).