Gnus development mailing list
 help / color / mirror / Atom feed
* nndoc: nndoc-address broken for multiple nndoc files in a virtual newsgroup
@ 1996-02-27 17:27 Albrecht Kadlec
  0 siblings, 0 replies; only message in thread
From: Albrecht Kadlec @ 1996-02-27 17:27 UTC (permalink / raw)




In short: there are two bugs:

	1.)	nndoc-address is a group setting, which isn't set
		for virtual newsgroups member groups, or at least it's not
		set every time a header is requested from a different
		member group.
		(I think you need to add two nndoc groups to a virtual
		newsgroup, to get this effect)

	2.)	probably there's sth wrong with the virtual newsgroup
		itself, since it gave different results when first opened.



long version:
 
nndoc-possibly-change-buffer is broken (& possibly other functions, too):
nndoc-address is wrong under the following (admittedly complicated)
circumstances:


I tried this since the very earlish ding gnus versions (one of the first
release of virtual newsgroups)
I reported the behaviour several times (every 2-3 months)
It still doesn't work in sgnus-0.45.


try this:

I created 2 doc groups (G f) for my (remote) RMAIL and SMAIL files

I enter each one and see the expected contents. On exit the numbers in the
group buffer are updated ( I use Unread  Ticked Dormant: Groupname)

I create a virtual Group (G V) mail-old.
I add the two groups to the virtual group (G v) (SMAIL first)

I enter the virtual group.
The group I added first (SMAIL) is fetched (you can tell from the ange-ftp
messages).
Only summary lines of the group I added first are displayed.
It looks like this:

R  [  28: albrecht            ] Re: neue Telephonnummer
R  [  28: albrecht            ] 
   [  32: albrecht            ] Re: Gerrit and Afke have a baby
   [  32: albrecht            ] 
   [  38: albrecht            ] Re: xray / target
   [  38: albrecht            ] 
   [  42: albrecht            ] Re: kommst du mit? (fwd, hab' mich vorhin bei deiner adresse vertippt)

When I select the first article I indeed get the article with that subject
When I select the second article, the second file is FETCHED!!!
It wasn't fetched before!!!!
Finally the first article of RMAIL is displayed:

When I quit, the group buffer is updated with this garbage:

     107  0 0: RMAIL
     107  0 0: SMAIL
     214  0 0: mail-old


The messages say (sorry the first part is missing, but it was only sth.
about: Entering group mail-old):



> eving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...6%
> ving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...98%
> ing /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...done
Fetching headers...done
Sorting threads...
Sorting threads...done
Generating summary...
Generating summary...done
Executing ?...
Executing ?...done
End of buffer [2 times]
Beginning of buffer [3 times]
Mark set
> rieving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...
> eving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...6%
> ving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...98%
> ing /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...done
Loading mail-extr...
Loading mail-extr...done
Loading gnus-cite...
Loading gnus-cite...done
Auto-saving...
Auto-saving...done
> rieving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...
> eving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...4%
> ving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...92%
> ing /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...done
Mark set



so it seems like only the first member group is scanned for headers.
Threading & sorting is done on these headers for BOTH member groups. 
i.e: the header array of SMAIL is reused for RMAIL.
Thus the threading & sorting doesn't do much:

the final order seems to be: 

	SMAIL 1 with header of SMAIL 1
	RMAIL 1 with header of SMAIL 1 !!!!
	SMAIL 2 with header of SMAIL 2
	RMAIL 2 with header of SMAIL 2 !!!!





The second & third time (& ever since) I tried (new emacs), I just saw the
RMAIL contents. (no duplicate headers !!!)



Password for albrecht@vta_host.auto.tuwien.ac.at: whatever

Opening FTP connection to vta_host.auto.tuwien.ac.at...
Opening FTP connection to vta_host.auto.tuwien.ac.at...done
Logging in as user albrecht@vta_host.auto.tuwien.ac.at...
Logging in as user albrecht@vta_host.auto.tuwien.ac.at...done
Getting PWD...
Getting PWD...done
Listing /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL/...
> ting /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL/...8k
> ng /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL/...done
Listing /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/...
Listing /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/...done
> rieving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...
> eving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...6%
> ving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...91%
> ing /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/SMAIL...done
Opening nndoc server on nndoc:RMAIL...

> rieving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...
> eving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...9%
> ving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...99%
> ing /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...done
Fetching headers...
> rieving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...
> eving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...6%
> ving /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...99%
> ing /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL...done
Fetching headers...done
Sorting threads...
Sorting threads...done
Generating summary...
Generating summary...done
Executing ?...
Loading gnus-kill...
Loading gnus-kill...done
Executing ?...done




the nntp buffer looks like this, after nnvirtual has fetched all headers:

1	"Heizkoerper in meinem Zimmer ..."	Ulrich Schmid <s@auto.tuwien.ac.at>	Tue, 2 Jan 1996 09:56:27 +0100	<199601020856.AA01285@newton.auto.tuwien.ac.at>		0	6	Xref: anaphi.vlsivie.tuwien.ac.at nndoc+nndoc:SMAIL:SMAIL:1	
2	"Heizkoerper in meinem Zimmer ..."	Ulrich Schmid <s@auto.tuwien.ac.at>	Tue, 2 Jan 1996 09:56:27 +0100	<199601020856.AA01285@newton.auto.tuwien.ac.at>		0	6	Xref: anaphi.vlsivie.tuwien.ac.at nndoc+nndoc:RMAIL:RMAIL:1	
3	so, mo	helwig@schnoferl.cg.tuwien.ac.at (Helwig Loeffelmann)	Tue, 2 Jan 1996 09:59:38 +0100 (MET)	<199601020859.JAA03137@schnoferl.cg.tuwien.ac.at>		0	20	Xref: anaphi.vlsivie.tuwien.ac.at nndoc+nndoc:RMAIL:RMAIL:2	
4	so, mo	helwig@schnoferl.cg.tuwien.ac.at (Helwig Loeffelmann)	Tue, 2 Jan 1996 09:59:38 +0100 (MET)	<199601020859.JAA03137@schnoferl.cg.tuwien.ac.at>		0	20	Xref: anaphi.vlsivie.tuwien.ac.at nndoc+nndoc:SMAIL:SMAIL:2	


note that article 1 & 2 have the same subject & sender, but the right
reference.
the same for the next, ...
the ODD article always has the same subject as the EVEN.
But odd articles are from SMAIL and even ones from RMAIL.


since the headers are the same, threading removes every ODD (SMAIL)
article. 
That's why I just can see the EVEN ones.




BTW: shouldn't the call to `gnus-retrieve-headers' propagate the `fetch-old'
parameter in nnvirtual-retrieve-headers ?

old:	      (when (setq result (gnus-retrieve-headers 
				  (list (caddr article)) cgroup))
-> 
proposed:	      (when (setq result (gnus-retrieve-headers 
				  (list (caddr article)) cgroup fetch-old))


so..
the problem seems to be nndoc-possibly-change-buffer not doing so.
or rather: it does, but *nndoc:RMAIL* and *nndoc:SMAIL* do have the same
contents 


this in terms comes from a wrong set nndoc-address in
nndoc-possibly-change-buffer:
i added:
(message "(nndoc-possibly-change-buffer %s %s %s" group nndoc-address source)
as the first line after the function head.
I got:

(nndoc-possibly-change-buffer SMAIL /albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/RMAIL nndoc:SMAIL
                  ^^^^^ !!!!!!

so the address doesn't fit.

I don't know where it should be set. I guess in or before nndoc-request-group.



I changed the line 
	    (insert-file-contents nndoc-address)
to the following:
	    (insert-file-contents (concat 
"/albrecht@vta_host.auto.tuwien.ac.at:/home/vta_host/albrecht/" group))

and it now works for me.

This is possibly the least portable & ugliest hack ever (therefore no patch
!!!), but I don't know where I should get the correct address from.

I hope someone with a deeper understanding of where nndoc-address should be
set (hi, lars?) can fix this now.


cheers,
albrecht


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~1996-02-27 17:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1996-02-27 17:27 nndoc: nndoc-address broken for multiple nndoc files in a virtual newsgroup Albrecht Kadlec

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).