September Gnus 0.48 is released

September Gnus 0.48 is released

[Lars Magne Ingebrigtsen]

Bug fix.

Get it from <URL:http://www.ifi.uio.no/~larsi/sgnus.tar.gz> or 
"ftp.ifi.uio.no:/pub/emacs/gnus/".

ChangeLog since last release:

Thu Feb 29 14:28:06 1996  Lars Magne Ingebrigtsen  <larsi@hler.ifi.uio.no>

	* gnus.el (gnus-read-active-file): Wouldn't work on `some'.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@ifi.uio.no * Lars Ingebrigtsen

Re: September Gnus 0.48 is released

[Steven L Baur]

There was an XEmacs compatibility problem introduced into v0.46.  The
utility function mail-strip-quoted-names accepts nil input on Emacs
19.30 and barfs and dies on nil input with XEmacs 19.13.  The
following patch works around this problem.  A 19.14 beta tester should
check to see if mail-strip-quoted-names (in utils/mail-utils.el) still
has the same bug.

The supplied patch does nothing on Emacs 19.30 and on XEmacs puts a
wrapper around mail-strip-quoted-names to correctly process a nil
parameter.

===================================================================
RCS file: RCS/ChangeLog,v
retrieving revision 1.51
diff -u -r1.51 ChangeLog
--- ChangeLog	1996/02/29 17:14:32	1.51
+++ ChangeLog	1996/02/29 19:02:39
@@ -1,3 +1,15 @@
+Thu Feb 29 10:50:02 1996  Steven L. Baur  <steve@miranova.com>
+
+	* gnus-xmas.el (gnus-xmas-redefine): Add wrapper to
+	mail-strip-quoted-names.
+	(gnus-xmas-mail-strip-quoted-names): New function.
+
+	* gnus-msg.el (gnus-mail-reply): Use it.
+
+	* gnus-soup.el (gnus-soup-store): Use it.
+
+	* gnus-ems.el: mail-strip-quoted-names -> gnus-mail-strip-quoted-names.
+
 Thu Feb 29 14:28:06 1996  Lars Magne Ingebrigtsen  <larsi@hler.ifi.uio.no>
 
 	* gnus.el (gnus-read-active-file): Wouldn't work on `some'.

===================================================================
RCS file: RCS/gnus-ems.el,v
retrieving revision 1.8
diff -u -r1.8 gnus-ems.el
--- gnus-ems.el	1996/02/19 23:48:29	1.8
+++ gnus-ems.el	1996/02/29 18:48:55
@@ -39,6 +39,7 @@
 (defalias 'gnus-extent-start-open 'ignore)
 (defalias 'gnus-set-text-properties 'set-text-properties)
 (defalias 'gnus-appt-select-lowest-window 'appt-select-lowest-window)
+(defalias 'gnus-mail-strip-quoted-names 'mail-strip-quoted-names)
 
 (eval-and-compile 
   (autoload 'gnus-xmas-define "gnus-xmas")

===================================================================
RCS file: RCS/gnus-xmas.el,v
retrieving revision 1.16
diff -u -r1.16 gnus-xmas.el
--- gnus-xmas.el	1996/02/19 23:48:29	1.16
+++ gnus-xmas.el	1996/02/29 18:54:07
@@ -397,6 +397,7 @@
   (fset 'gnus-tree-minimize 'gnus-xmas-tree-minimize)
   (fset 'gnus-appt-select-lowest-window 
 	'gnus-xmas-appt-select-lowest-window)
+  (fset 'gnus-mail-strip-quoted-names 'gnus-xmas-mail-strip-quoted-names)
 
   (add-hook 'gnus-group-mode-hook 'gnus-xmas-group-menu-add)
   (add-hook 'gnus-summary-mode-hook 'gnus-xmas-summary-menu-add)
@@ -710,5 +711,11 @@
 	    (after-find-file error (not nowarn)))))
       buf)))
 
+(defun gnus-xmas-mail-strip-quoted-names (address)
+  "Protect mail-strip-quoted-names from NIL input.
+XEmacs compatibility workaround."
+  (if (null address)
+      nil
+    (mail-strip-quoted-names address)))
 
 ;;; gnus-xmas.el ends here

===================================================================
RCS file: RCS/gnus-msg.el,v
retrieving revision 1.36
diff -u -r1.36 gnus-msg.el
--- gnus-msg.el	1996/02/29 17:12:15	1.36
+++ gnus-msg.el	1996/02/29 19:01:32
@@ -481,9 +481,9 @@
   (gnus-summary-select-article t)
   ;; Check whether the user owns the article that is to be superseded. 
   (unless (string-equal
-	   (downcase (mail-strip-quoted-names 
+	   (downcase (gnus-mail-strip-quoted-names 
 		      (mail-header-from gnus-current-headers)))
-	   (downcase (mail-strip-quoted-names (gnus-inews-user-name))))
+	   (downcase (gnus-mail-strip-quoted-names (gnus-inews-user-name))))
     (error "This article is not yours."))
   ;; Get a normal *Post News* buffer.
   (gnus-new-news gnus-newsgroup-name t)
@@ -1035,8 +1035,9 @@
 	  ;; user id with value of its From: field.
 	  (if (not
 	       (string-equal
-		(downcase (mail-strip-quoted-names from))
-		(downcase (mail-strip-quoted-names (gnus-inews-user-name)))))
+		(downcase (gnus-mail-strip-quoted-names from))
+		(downcase (gnus-mail-strip-quoted-names
+			   (gnus-inews-user-name)))))
 	      (progn
 		(ding) (gnus-message 3 "This article is not yours.")
 		nil)
@@ -1891,8 +1892,8 @@
 		      new-cc 
 		      (if (and mctdo
 			       (not (string= 
-				     (mail-strip-quoted-names mct)
-				     (mail-strip-quoted-names
+				     (gnus-mail-strip-quoted-names mct)
+				     (gnus-mail-strip-quoted-names
 				      (or to-address 
 					  (if (and follow-to 
 						   (not (stringp follow-to)))
@@ -1917,7 +1918,7 @@
 		  (setq ccalist
 			(mapcar
 			 (lambda (addr)
-			   (cons (mail-strip-quoted-names addr) addr))
+			   (cons (gnus-mail-strip-quoted-names addr) addr))
 			 (nreverse (gnus-mail-parse-comma-list))))
 		  (let ((s ccalist))
 		    (while s

===================================================================
RCS file: RCS/gnus-soup.el,v
retrieving revision 1.10
diff -u -r1.10 gnus-soup.el
--- gnus-soup.el	1996/02/29 05:45:56	1.10
+++ gnus-soup.el	1996/02/29 19:02:24
@@ -223,7 +223,7 @@
       ;; Find the "from".
       (goto-char (point-min))
       (setq from
-	    (mail-strip-quoted-names
+	    (gnus-mail-strip-quoted-names
 	     (or (mail-fetch-field "from")
 		 (mail-fetch-field "really-from")
 		 (mail-fetch-field "sender"))))

-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be proofread for $250/hour.
Andrea Seastrand: For your vote on the Telecom bill, I will vote for anyone
except you in November.

Re: September Gnus 0.48 is released

[Mark Borges]

>> On 29 Feb 1996 11:25:35 -0800,
>> Steven L Baur(sb) wrote:
sb> The following patch works around this problem.  A 19.14 beta
sb> tester should check to see if mail-strip-quoted-names (in
sb> utils/mail-utils.el) still has the same bug.

Maybe. The defun from 19.14-beta12 is appended below (I'm not sure
what I'm looking for).

If it is a bug/incompatability, could you please let us know.
Thanks,

  -mb-

(defun mail-strip-quoted-names (address)
  "Delete comments and quoted strings in an address list ADDRESS.
Also delete leading/trailing whitespace and replace FOO <BAR> with just BAR.
Return a modified address list."
  (if (null address)
      nil
    (if mail-use-rfc822
	(progn (require 'rfc822)
	       (mapconcat 'identity (rfc822-addresses address) ", "))
      (let (pos)
       (string-match "\\`[ \t\n]*" address)
       ;; strip surrounding whitespace
       (setq address (substring address
				(match-end 0)
				(string-match "[ \t\n]*\\'" address
					      (match-end 0))))

       ;; Detect nested comments.
       (if (string-match "[ \t]*(\\([^)\"\\]\\|\\\\.\\|\\\\\n\\)*(" address)
	   ;; Strip nested comments.
	   (save-excursion
	     (set-buffer (get-buffer-create " *temp*"))
	     (erase-buffer)
	     (insert address)
	     (set-syntax-table lisp-mode-syntax-table)
	     (goto-char 1)
	     (while (search-forward "(" nil t)
	       (forward-char -1)
	       (skip-chars-backward " \t")
	       (delete-region (point)
			      (save-excursion
				(condition-case ()
				    (forward-sexp 1)
				  (error (goto-char (point-max))))
				  (point))))
	     (setq address (buffer-string))
	     (erase-buffer))
	 ;; Strip non-nested comments an easier way.
	 (while (setq pos (string-match 
			    ;; This doesn't hack rfc822 nested comments
			    ;;  `(xyzzy (foo) whinge)' properly.  Big deal.
			    "[ \t]*(\\([^)\"\\]\\|\\\\.\\|\\\\\n\\)*)"
			    address))
	   (setq address
		 (mail-string-delete address
				     pos (match-end 0)))))

       ;; strip `quoted' names (This is supposed to hack `"Foo Bar" <bar@host>')
       (setq pos 0)
       (while (setq pos (string-match
			  "[ \t]*\"\\([^\"\\]\\|\\\\.\\|\\\\\n\\)*\"[ \t\n]*"
			  address pos))
	 ;; If the next thing is "@", we have "foo bar"@host.  Leave it.
	 (if (and (> (length address) (match-end 0))
		  (= (aref address (match-end 0)) ?@))
	     (setq pos (match-end 0))
	   (setq address
		 (mail-string-delete address
				     pos (match-end 0)))))
       ;; Retain only part of address in <> delims, if there is such a thing.
       (while (setq pos (string-match "\\(,\\s-*\\|\\`\\)[^,]*<\\([^>,]*>\\)"
				      address))
	 (let ((junk-beg (match-end 1))
	       (junk-end (match-beginning 2))
	       (close (match-end 0)))
	   (setq address (mail-string-delete address (1- close) close))
	   (setq address (mail-string-delete address junk-beg junk-end))))
       address))))
  
(or (and (boundp 'rmail-default-dont-reply-to-names)
	 (not (null rmail-default-dont-reply-to-names)))
    (setq rmail-default-dont-reply-to-names "info-"))

Re: September Gnus 0.48 is released

[Mark Borges]

>> On 29 Feb 1996 11:25:35 -0800,
>> Steven L Baur(sb) wrote:
sb> The utility function mail-strip-quoted-names accepts nil input on Emacs
sb> 19.30 and barfs and dies on nil input with XEmacs 19.13.  The
sb> following patch works around this problem.  A 19.14 beta tester should
sb> check to see if mail-strip-quoted-names (in utils/mail-utils.el) still
sb> has the same bug.

I should have noted that XEmacs-19.14 is synced up with GNU Emacs
19.30 for the lisp files that are in common between the
emacsen,including this one (mail-utils.el). So, if the problem doesn't
exist in GNU Emacs 19.30 it shouldn't on XEmacs-19.14 either.

  -mb-

Re: September Gnus 0.48 is released

[Steven L Baur]

>>>>> "mb" == Mark Borges <mdb@cdc.noaa.gov> writes:

>>> On 29 Feb 1996 11:25:35 -0800,
>>> Steven L Baur(sb) wrote:
sb> The utility function mail-strip-quoted-names accepts nil input on Emacs
sb> 19.30 and barfs and dies on nil input with XEmacs 19.13.

mb> I should have noted that XEmacs-19.14 is synced up with GNU Emacs
mb> 19.30 for the lisp files that are in common between the
mb> emacsen,including this one (mail-utils.el). So, if the problem doesn't
mb> exist in GNU Emacs 19.30 it shouldn't on XEmacs-19.14 either.

You're right, the code snippet you sent to the list and e-mailed me a
duplicate confirms it.  Another bug fixed in 19.14.

-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be proofread for $250/hour.
Andrea Seastrand: For your vote on the Telecom bill, I will vote for anyone
except you in November.