Re: XEmacs-20.3/Emacs-20.2 enriched-decode bug [Was: Re: bad article]

Re: XEmacs-20.3/Emacs-20.2 enriched-decode bug [Was: Re: bad article]

[Shep Proudfoot]

SL Baur <steve@xemacs.org> writes:

> Try this and see if it helps (note that format.el is dumped with
> XEmacs so you have to either redump XEmacs after patching or
> explicitly load the new version of the file).

How does one "redump XEmacs"?

Shep


_________________________________________________________
DO YOU YAHOO!?
Get your free @yahoo.com address at http://mail.yahoo.com

Re: XEmacs-20.3/Emacs-20.2 enriched-decode bug [Was: Re: bad article]

[SL Baur]

Shep Proudfoot <sproudfoot@yahoo.com> writes:

> SL Baur <steve@xemacs.org> writes:
>> Try this and see if it helps (note that format.el is dumped with
>> XEmacs so you have to either redump XEmacs after patching or
>> explicitly load the new version of the file).

> How does one "redump XEmacs"?

After patching format.el, go up to the top level directory of your
XEmacs sources and type `make' (and then do `make install' if this
fixes the problem).

Re: XEmacs-20.3/Emacs-20.2 enriched-decode bug [Was: Re: bad article]

[SL Baur]

Danny Siu <dsiu@Adobe.COM> writes:

> Lars Magne Ingebrigtsen writes:
Lars> Joerg Plate <Plate@Psyche.HB.North.de> writes:
>>> Signaling: (wrong-type-argument integer-or-marker-p nil)
>>> put-text-property(1230 nil unknown ("x-fontsize"))
>>> format-deannotate-region(

Lars> [...]

>>> mime-preview/display-body(

Lars> Looks like a SEMI bug.

> I don't think so.

> I encountered this bug everyday.  I guess more people are using mailers that
> encode formatted mail using enriched.

It's an Emacs/XEmacs bug in format.el and fixed in the latest
sources.

(digging around ...)

Try this and see if it helps (note that format.el is dumped with
XEmacs so you have to either redump XEmacs after patching or
explicitly load the new version of the file).

1997-12-16  Oscar Figueiredo <Oscar.Figueiredo@di.epfl.ch>

	* format.el (format-deannotate-region):  Bug fix.
	Deannotating a region containing unknown tags would fail
	(causing decoding of text/enriched to fail at user level)

Index: format.el
===================================================================
RCS file: /usr/local/xemacs/xemacs-20.0/lisp/format.el,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- format.el	1997/12/14 03:51:44	1.5
+++ format.el	1997/12/17 06:27:13	1.6
@@ -652,9 +652,10 @@
 					  loc (cdr (car extents))))))))
 			(setq alist (cdr alist))))
 		    (setq aalist (cdr aalist)))
-		  (if (not matched)
+		  (unless matched
 		      ;; Didn't find any match for the annotation:
 		      ;; Store as value of text-property `unknown'.
+		      (setcdr (car top-extents) loc)
 		      (let ((extents top-extents)
 			    (start (car (car top-extents)))
 			    (loc (cdr (car top-extents))))

XEmacs-20.3/Emacs-20.2 enriched-decode bug [Was: Re: bad article]

[Danny Siu]

Lars Magne Ingebrigtsen writes:

  Lars> Joerg Plate <Plate@Psyche.HB.North.de> writes:
  >> Signaling: (wrong-type-argument integer-or-marker-p nil)
  >> put-text-property(1230 nil unknown ("x-fontsize"))
  >> format-deannotate-region(

  Lars> [...]

  >> mime-preview/display-body(

  Lars> Looks like a SEMI bug.

I don't think so.

I encountered this bug everyday.  I guess more people are using mailers that
encode formatted mail using enriched.

Anyways, the problem happens whenever a "Content-type: text/enriched;
charset=us-ascii" mail is read.  format-deannotate-region (in
listp/prim/format.el) calls put-text-property with a nil as 2nd argument.
format-deannotate-region is called by enriched-decode (in
lisp/modes/enriched.el).

To reproduce, highlight the following line

<x-fontsize><param>13</param>Enriched is broken!!</x-fontsize>

and do

(enriched-decode (region-beginning) (region-end))

Any x-* tags will fail in enriched-mode.

I am using XEmacs-20.3 but FSF Emacs-20.2 fails the same way.

  Lars> -- (domestic pets only, the antidote for overdose, milk.)
  Lars>   larsi@gnus.org * Lars Magne Ingebrigtsen

-- 
=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Danny Dick-Fung Siu                              mailto:dsiu@adobe.com 
 WebReady Printing Group           mailto:dsiu@alumni.eecs.berkeley.edu 
 Adobe Systems Incorporated          http://www.csua.berkeley.edu/~dsiu 
=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=