Gnus development mailing list
 help / color / mirror / Atom feed
From: David Engster <deng@randomsample.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>,  ding@gnus.org
Subject: Re: [gnus git]  branch master updated: n0-17-27-g43f8466 =1= nntp.el (nntp-open-connection): Set TCP keepalive option.
Date: Tue, 10 May 2011 16:19:10 +0200	[thread overview]
Message-ID: <m2fwom3ag1.fsf@randomsample.de> (raw)
In-Reply-To: <jwvaaeuacuu.fsf-monnier+INBOX@gnu.org> (Stefan Monnier's message of "Tue, 10 May 2011 10:46:36 -0300")

Stefan Monnier writes:
>>> I don't necessarily disagree with this patch, but I'm wondering what the
>>> use case is.
>> In any case, the buildbot is now complaining that this (probably) won't
>> work on Emacs22 and XEmacs. :-)
>
> I must say I have no idea what makes it think so.  The `fboundp' check
> should avoid those problems.

You're checking for set-network-process-option, but not for
process-type. At least that will fix the warning for Emacs22.

Regarding XEmacs, I have no idea...

-David



  reply	other threads:[~2011-05-10 14:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1QJYrH-0001ys-1x@quimby.gnus.org>
2011-05-09 22:53 ` Lars Magne Ingebrigtsen
2011-05-10  1:01   ` Stefan Monnier
2011-05-10  1:07     ` Stefan Monnier
2011-05-30 20:14       ` Lars Magne Ingebrigtsen
2011-05-30 20:17     ` Lars Magne Ingebrigtsen
2011-05-10  5:30   ` David Engster
2011-05-10 13:46     ` Stefan Monnier
2011-05-10 14:19       ` David Engster [this message]
2011-05-11  8:57         ` David Engster
2011-05-11 17:59     ` David Engster
2011-05-10 12:06   ` Greg Troxel
2011-05-10 12:23     ` Antoine Levitt
2011-05-10 13:07       ` Richard Riley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2fwom3ag1.fsf@randomsample.de \
    --to=deng@randomsample.de \
    --cc=ding@gnus.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).