M-g doesn't work with gnus-no-server

M-g doesn't work with gnus-no-server

[Daiki Ueno]

Hello,

To reduce startup time, I usually start Gnus with M-x gnus-no-server,
and type M-g to check certain groups.  However, it seems to be broken
for a while:

Debugger entered--Lisp error: (error "server/993 Name or service not known")
  make-network-process(:name "*nnimap*" :buffer #<buffer  *nnimap server nil  *nntpd**> :host "server" :service "993" :nowait nil)
  open-network-stream("*nnimap*" #<buffer  *nnimap server nil  *nntpd**> "server" "993")
  open-gnutls-stream("*nnimap*" #<buffer  *nnimap server nil  *nntpd**> "server" "993")
  ...
  nnimap-open-connection-1(#<buffer  *nntpd*>)
  nnimap-open-connection(#<buffer  *nntpd*>)
  nnimap-open-server("server" nil nil)
  nnimap-change-group(nil "server")
  nnimap-request-group-scan("INBOX" "server" ...)
  gnus-request-group-scan("nnimap+server:INBOX" ...)
  gnus-group-get-new-news-this-group(nil)
  gnus-topic-get-new-news-this-topic(nil)
  funcall-interactively(gnus-topic-get-new-news-this-topic nil)
  call-interactively(gnus-topic-get-new-news-this-topic nil nil)
  command-execute(gnus-topic-get-new-news-this-topic)

Comparing the backtrace with the one taken with M-x debug-on-entry
open-network-stream on Emacs 24.4, the DEFS argument of
`nnimap-open-server' is not given on the first connection.

Any ideas on this?

Regards,
-- 
Daiki Ueno

Re: M-g doesn't work with gnus-no-server

[Ted Zlatanov]

On Tue, 17 Mar 2015 18:06:09 +0900 Daiki Ueno <ueno@gnu.org> wrote: 

DU> Debugger entered--Lisp error: (error "server/993 Name or service not known")
DU>   make-network-process(:name "*nnimap*" :buffer #<buffer  *nnimap server nil  *nntpd**> :host "server" :service "993" :nowait nil)
DU>   open-network-stream("*nnimap*" #<buffer  *nnimap server nil  *nntpd**> "server" "993")
DU>   open-gnutls-stream("*nnimap*" #<buffer  *nnimap server nil  *nntpd**> "server" "993")
DU>   ...
DU>   nnimap-open-connection-1(#<buffer  *nntpd*>)
DU>   nnimap-open-connection(#<buffer  *nntpd*>)
DU>   nnimap-open-server("server" nil nil)
DU>   nnimap-change-group(nil "server")
DU>   nnimap-request-group-scan("INBOX" "server" ...)
DU>   gnus-request-group-scan("nnimap+server:INBOX" ...)
DU>   gnus-group-get-new-news-this-group(nil)
DU>   gnus-topic-get-new-news-this-topic(nil)
DU>   funcall-interactively(gnus-topic-get-new-news-this-topic nil)
DU>   call-interactively(gnus-topic-get-new-news-this-topic nil nil)
DU>   command-execute(gnus-topic-get-new-news-this-topic)

DU> Comparing the backtrace with the one taken with M-x debug-on-entry
DU> open-network-stream on Emacs 24.4, the DEFS argument of
DU> `nnimap-open-server' is not given on the first connection.

No idea, but can you bisect the issue to a specific commit?  That would
answer it most clearly.

Ted

Re: M-g doesn't work with gnus-no-server

[Lars Ingebrigtsen]

Daiki Ueno <ueno@gnu.org> writes:

> To reduce startup time, I usually start Gnus with M-x gnus-no-server,
> and type M-g to check certain groups.  However, it seems to be broken
> for a while:
>
> Debugger entered--Lisp error: (error "server/993 Name or service not known")
>   make-network-process(:name "*nnimap*" :buffer #<buffer *nnimap
> server nil *nntpd**> :host "server" :service "993" :nowait nil)
>   open-network-stream("*nnimap*" #<buffer *nnimap server nil *nntpd**>
> "server" "993")

Weird.  It's using "server" as the server name?  Or did you just edit
it?  :-)

> Comparing the backtrace with the one taken with M-x debug-on-entry
> open-network-stream on Emacs 24.4, the DEFS argument of
> `nnimap-open-server' is not given on the first connection.
>
> Any ideas on this?

Not really...  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: M-g doesn't work with gnus-no-server

[Andreas Schwab]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Daiki Ueno <ueno@gnu.org> writes:
>
>> To reduce startup time, I usually start Gnus with M-x gnus-no-server,
>> and type M-g to check certain groups.  However, it seems to be broken
>> for a while:
>>
>> Debugger entered--Lisp error: (error "server/993 Name or service not known")
>>   make-network-process(:name "*nnimap*" :buffer #<buffer *nnimap
>> server nil *nntpd**> :host "server" :service "993" :nowait nil)
>>   open-network-stream("*nnimap*" #<buffer *nnimap server nil *nntpd**>
>> "server" "993")
>
> Weird.  It's using "server" as the server name?

It's supposed to be looked up in gnus-server-alist.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: M-g doesn't work with gnus-no-server

[Andreas Schwab]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Daiki Ueno <ueno@gnu.org> writes:
>
>> To reduce startup time, I usually start Gnus with M-x gnus-no-server,
>> and type M-g to check certain groups.  However, it seems to be broken
>> for a while:
>>
>> Debugger entered--Lisp error: (error "server/993 Name or service not known")
>>   make-network-process(:name "*nnimap*" :buffer #<buffer *nnimap
>> server nil *nntpd**> :host "server" :service "993" :nowait nil)
>>   open-network-stream("*nnimap*" #<buffer *nnimap server nil *nntpd**>
>> "server" "993")
>
> Weird.  It's using "server" as the server name?  Or did you just edit
> it?  :-)

It seems gnus fails to use nnimap-address from the server method.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: M-g doesn't work with gnus-no-server

[Andreas Schwab]

Fixed by 9dc77e3.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: M-g doesn't work with gnus-no-server

[Daiki Ueno]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

Andreas Schwab <schwab@linux-m68k.org> writes:

> Fixed by 9dc77e3.

Thanks, but now I get "Unknown service: 993" instead (i.e. the host part
is nil).  The full backtrace is attached below.

Perhaps my .newsrc.eld might be not compatible with this change?

Regards,
-- 
Daiki Ueno

[-- Attachment #2: gnus-no-server.log --]
[-- Type: application/octet-stream, Size: 6239 bytes --]

Re: M-g doesn't work with gnus-no-server

[Dave Goldberg]

>
> Thanks, but now I get "Unknown service: 993" instead (i.e. the host part
> is nil).  The full backtrace is attached below.
>
> Perhaps my .newsrc.eld might be not compatible with this change?

I'm not sure it's the same thing but I was seeing that error when I set up Emacs and Gnus on a Windows 10 system.  The solution for that was to explicitly set nnimap-server-port to 993 in my secondary select method definitions.

-- 
Dave Goldberg
david.goldberg6@verizon.net

Re: M-g doesn't work with gnus-no-server

[Lars Ingebrigtsen]

Daiki Ueno <ueno@gnu.org> writes:

> Thanks, but now I get "Unknown service: 993" instead (i.e. the host part
> is nil).  The full backtrace is attached below.
>
> Perhaps my .newsrc.eld might be not compatible with this change?

Debugger entered--Lisp error: (error "Unknown service: 993")
  make-network-process(:name "*nnimap*" :buffer #<buffer  *nnimap nil nil  *nntpd**-409419> :host nil :service "993" :nowait nil)

[...]

  nnimap-change-group(nil "server")

Still the literal string "server", which surely has to be wrong...

Hm...  what does your nnimap server definition look like?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: M-g doesn't work with gnus-no-server

[Daiki Ueno]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Debugger entered--Lisp error: (error "Unknown service: 993")
>   make-network-process(:name "*nnimap*" :buffer #<buffer *nnimap nil
> nil *nntpd**-409419> :host nil :service "993" :nowait nil)
>
> [...]
>
>   nnimap-change-group(nil "server")
>
> Still the literal string "server", which surely has to be wrong...

I'm ignorant about this, but it should be an alist entry, right?

> Hm...  what does your nnimap server definition look like?

The only relevant configuration seems to be:

(setq gnus-select-method '(nnnil "")
      gnus-secondary-select-methods
      '((nnimap "server"
		(nnimap-address "......")
		(nnir-search-engine imap))))

where I masked nnimap-address with "...".

Regards,
-- 
Daiki Ueno

Re: M-g doesn't work with gnus-no-server

[Lars Ingebrigtsen]

Daiki Ueno <ueno@gnu.org> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Debugger entered--Lisp error: (error "Unknown service: 993")
>>   make-network-process(:name "*nnimap*" :buffer #<buffer *nnimap nil
>> nil *nntpd**-409419> :host nil :service "993" :nowait nil)
>>
>> [...]
>>
>>   nnimap-change-group(nil "server")
>>
>> Still the literal string "server", which surely has to be wrong...

[...]

>       gnus-secondary-select-methods
>       '((nnimap "server"
> 		(nnimap-address "......")
> 		(nnir-search-engine imap))))

Oh, your nnimap server is actually called "server".  :-)  Then the

>>   nnimap-change-group(nil "server")

part of the backtrace is as it should be.  I think.  But the right
nnimap-address still isn't set.  Hm...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: M-g doesn't work with gnus-no-server

[Daiki Ueno]

[-- Attachment #1: Type: text/plain, Size: 1829 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Daiki Ueno <ueno@gnu.org> writes:
>
>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>
>>> Debugger entered--Lisp error: (error "Unknown service: 993")
>>>   make-network-process(:name "*nnimap*" :buffer #<buffer *nnimap nil
>>> nil *nntpd**-409419> :host nil :service "993" :nowait nil)
>>>
>>> [...]
>>>
>>>   nnimap-change-group(nil "server")
>>>
>>> Still the literal string "server", which surely has to be wrong...
>
> [...]
>
>>       gnus-secondary-select-methods
>>       '((nnimap "server"
>> 		(nnimap-address "......")
>> 		(nnir-search-engine imap))))
>
> Oh, your nnimap server is actually called "server".  :-)  Then the
>
>>>   nnimap-change-group(nil "server")
>
> part of the backtrace is as it should be.  I think.  But the right
> nnimap-address still isn't set.  Hm...

I had a bit closer look at this, comparing the backtraces taken from
24.5 (works ok) and the git master (doesn't work).

The call sequences until `nnimap-open-server' are:

24.5:
  gnus-group-get-new-news-this-group
    -> gnus-activate-group
      -> gnus-open-server
        -> nnimap-open-server

master:
  gnus-group-get-new-news-this-group
    -> gnus-request-group-scan
      -> nnimap-request-group-scan
        -> nnimap-change-group
          -> nnimap-open-server

In the former case, `nnimap-open-server' is called with an alist entry
containing `nnimap-address', etc., while in the latter case, the
function takes "server", nil, nil.

So I guess a simple work around would be to replicate the same sequence
starting from `gnus-activate-group', if server is not opened.

Does the attached patch look correct?

To be honest, this issue is no longer priority for myself, since I
changed my habit to always use M-x gnus, as nnimap is fast enough these
days :-)

Regards,
-- 
Daiki Ueno

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnus-Make-M-g-work-with-gnus-no-server.patch --]
[-- Type: text/x-patch, Size: 951 bytes --]

From e1d28517a47b6b2fb4e820d5a2b9e12f2087366a Mon Sep 17 00:00:00 2001
From: Daiki Ueno <ueno@gnu.org>
Date: Tue, 9 Feb 2016 17:37:59 +0900
Subject: [PATCH] gnus: Make M-g work with gnus-no-server

* lisp/gnus/gnus-group.el: Don't call `gnus-request-group-scan' if
server is not opened.
---
 lisp/gnus/gnus-group.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 1cd16a4..4e1efab 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -4110,6 +4110,7 @@ gnus-group-get-new-news-this-group
       ;; Bypass any previous denials from the server.
       (gnus-remove-denial (setq method (gnus-find-method-for-group group)))
       (if (or (and (not dont-scan)
+		   (gnus-server-opened method)
 		   (gnus-request-group-scan group (gnus-get-info group)))
 	      (gnus-activate-group group (if dont-scan nil 'scan) nil method))
 	  (let ((info (gnus-get-info group))
-- 
2.5.0

Re: M-g doesn't work with gnus-no-server

[Lars Ingebrigtsen]

Daiki Ueno <ueno@gnu.org> writes:

> The call sequences until `nnimap-open-server' are:
>
> 24.5:
>   gnus-group-get-new-news-this-group
>     -> gnus-activate-group
>       -> gnus-open-server
>         -> nnimap-open-server
>
> master:
>   gnus-group-get-new-news-this-group
>     -> gnus-request-group-scan
>       -> nnimap-request-group-scan
>         -> nnimap-change-group
>           -> nnimap-open-server

[...]

> * lisp/gnus/gnus-group.el: Don't call `gnus-request-group-scan' if
> server is not opened.

Well, we want `M-g' to open the server if it isn't already...  so
perhaps we should just call `gnus-activate-group'?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: M-g doesn't work with gnus-no-server

[Daiki Ueno]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> * lisp/gnus/gnus-group.el: Don't call `gnus-request-group-scan' if
>> server is not opened.
>
> Well, we want `M-g' to open the server if it isn't already...  so
> perhaps we should just call `gnus-activate-group'?

I am not really sure if I get your suggestion, but how about this?

Regards,
-- 
Daiki Ueno

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnus-Make-M-g-work-with-gnus-no-server.patch --]
[-- Type: text/x-patch, Size: 1560 bytes --]

From d84b39a671f3c36634d92897205f3d812a64e9ba Mon Sep 17 00:00:00 2001
From: Daiki Ueno <ueno@gnu.org>
Date: Tue, 9 Feb 2016 17:37:59 +0900
Subject: [PATCH] gnus: Make M-g work with gnus-no-server

* lisp/gnus/gnus-group.el: Divert to call `gnus-activate-group' with the
SCAN argument set, if request-group-scan is not defined for the backend.
Ensure that the server is open when calling `gnus-request-group-scan'.
---
 lisp/gnus/gnus-group.el | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 1cd16a4..5554569 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -4109,9 +4109,14 @@ gnus-group-get-new-news-this-group
       (gnus-group-remove-mark group)
       ;; Bypass any previous denials from the server.
       (gnus-remove-denial (setq method (gnus-find-method-for-group group)))
-      (if (or (and (not dont-scan)
-		   (gnus-request-group-scan group (gnus-get-info group)))
-	      (gnus-activate-group group (if dont-scan nil 'scan) nil method))
+      (if (if (and (not dont-scan)
+		   ;; Prefer request-group-scan if the backend supports it.
+		   (gnus-check-backend-function 'request-group-scan group))
+	      (progn
+		;; Ensure that the server is already open.
+		(gnus-activate-group group nil nil method)
+		(gnus-request-group-scan group (gnus-get-info group)))
+	    (gnus-activate-group group (if dont-scan nil 'scan) nil method))
 	  (let ((info (gnus-get-info group))
 		(active (gnus-active group)))
 	    (when info
-- 
2.5.0

Re: M-g doesn't work with gnus-no-server

[Andreas Schwab]

I've reverted commit 9dc77e3 due to bug #22634.  This really needs to be
fixed in the caller.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: M-g doesn't work with gnus-no-server

[Lars Ingebrigtsen]

Daiki Ueno <ueno@gnu.org> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>>> * lisp/gnus/gnus-group.el: Don't call `gnus-request-group-scan' if
>>> server is not opened.
>>
>> Well, we want `M-g' to open the server if it isn't already...  so
>> perhaps we should just call `gnus-activate-group'?
>
> I am not really sure if I get your suggestion, but how about this?

Can you report this problem with `M-x report-emacs-bug' so that it
doesn't get lost?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: M-g doesn't work with gnus-no-server

[Daiki Ueno]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Can you report this problem with `M-x report-emacs-bug' so that it
> doesn't get lost?

Done as bug#22649.

Regards,
-- 
Daiki Ueno