* [PATCH] Encrypt replies to encrypted messages by default.
@ 2011-01-03 1:43 Karl Fogel
2011-01-03 4:49 ` Lars Magne Ingebrigtsen
2011-01-03 7:30 ` Reiner Steib
0 siblings, 2 replies; 7+ messages in thread
From: Karl Fogel @ 2011-01-03 1:43 UTC (permalink / raw)
To: ding
(I recently sent this patch to emacs-devel@ [1], then thought maybe I
should post it here instead.)
The patch below causes replies to encrypted messages to also be
encrypted by default. Justification: it's better to accidentally
encrypt than to accidentally *not* encrypt. Especially with email,
where a reply may quote parts of the original mail (which was sent
encrypted, thus raising the likelihood that quoted excerpts would be of
a sensitive nature).
It happened to me recently: I accidentally sent a reply in plaintext,
quoting parts of a rather sensitive mail, because I'd unconsciously
expected Gnus to automatically encrypt the reply. That incident started
me looking for some way to control this behavior. I was very glad to
find `gnus-message-replyencrypt' -- I thought I was going to have to
implement it -- but was surprised to find it set to nil by default.
(Note the same logic does not apply to `gnus-message-replysign', so I
haven't changed that variable's default in this patch.)
Does this patch seem like a good idea?
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 0796918..aff0071 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2011-01-02 Karl Fogel <kfogel@red-bean.com>
+
+ * gnus-msg.el (gnus-message-replyencrypt): Default to `t'.
+
2011-01-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
* nnimap.el (nnimap-login): Prefer AUTH=CRAM-MD5, if it's available.
diff --git a/lisp/gnus-msg.el b/lisp/gnus-msg.el
index d77abfa..6dfdb4c 100644
--- a/lisp/gnus-msg.el
+++ b/lisp/gnus-msg.el
@@ -244,7 +244,7 @@ See also the `mml-default-sign-method' variable."
:type 'boolean)
(defcustom gnus-message-replyencrypt
- nil
+ t
"Automatically encrypt replies to encrypted messages.
See also the `mml-default-encrypt-method' variable."
:group 'gnus-message
Thanks,
-Karl
[1] http://lists.gnu.org/archive/html/emacs-devel/2011-01/msg00078.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Encrypt replies to encrypted messages by default.
2011-01-03 1:43 [PATCH] Encrypt replies to encrypted messages by default Karl Fogel
@ 2011-01-03 4:49 ` Lars Magne Ingebrigtsen
2011-01-03 7:30 ` Reiner Steib
1 sibling, 0 replies; 7+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-01-03 4:49 UTC (permalink / raw)
To: ding
Karl Fogel <kfogel@red-bean.com> writes:
> Does this patch seem like a good idea?
Makes sense to me. Applied.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Encrypt replies to encrypted messages by default.
2011-01-03 1:43 [PATCH] Encrypt replies to encrypted messages by default Karl Fogel
2011-01-03 4:49 ` Lars Magne Ingebrigtsen
@ 2011-01-03 7:30 ` Reiner Steib
2011-01-03 18:01 ` Karl Fogel
1 sibling, 1 reply; 7+ messages in thread
From: Reiner Steib @ 2011-01-03 7:30 UTC (permalink / raw)
To: Karl Fogel; +Cc: ding
On Mon, Jan 03 2011, Karl Fogel wrote:
> +2011-01-02 Karl Fogel <kfogel@red-bean.com>
> +
> + * gnus-msg.el (gnus-message-replyencrypt): Default to `t'.
> +
[...]
> (defcustom gnus-message-replyencrypt
> - nil
> + t
> "Automatically encrypt replies to encrypted messages.
> See also the `mml-default-encrypt-method' variable."
> :group 'gnus-message
Please add a :version tag as well.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Encrypt replies to encrypted messages by default.
2011-01-03 7:30 ` Reiner Steib
@ 2011-01-03 18:01 ` Karl Fogel
2011-01-03 22:18 ` Reiner Steib
0 siblings, 1 reply; 7+ messages in thread
From: Karl Fogel @ 2011-01-03 18:01 UTC (permalink / raw)
To: ding
Reiner Steib <reinersteib+gmane@imap.cc> writes:
>On Mon, Jan 03 2011, Karl Fogel wrote:
>> +2011-01-02 Karl Fogel <kfogel@red-bean.com>
>> +
>> + * gnus-msg.el (gnus-message-replyencrypt): Default to `t'.
>> +
>[...]
>> (defcustom gnus-message-replyencrypt
>> - nil
>> + t
>> "Automatically encrypt replies to encrypted messages.
>> See also the `mml-default-encrypt-method' variable."
>> :group 'gnus-message
>
>Please add a :version tag as well.
Just FYI, Lars did so in:
commit 4abc2eab2393ea07019b39a20594f85a479d9e20
Author: Lars Magne Ingebrigtsen <larsi@quimbies.gnus.org>
Date: Mon Jan 3 05:49:16 2011 +0100
Best,
-Karl, not subscribed to this list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Encrypt replies to encrypted messages by default.
2011-01-03 18:01 ` Karl Fogel
@ 2011-01-03 22:18 ` Reiner Steib
2011-01-03 22:23 ` Karl Fogel
0 siblings, 1 reply; 7+ messages in thread
From: Reiner Steib @ 2011-01-03 22:18 UTC (permalink / raw)
To: Karl Fogel; +Cc: ding
On Mon, Jan 03 2011, Karl Fogel wrote:
> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>>On Mon, Jan 03 2011, Karl Fogel wrote:
>>> +2011-01-02 Karl Fogel <kfogel@red-bean.com>
>>> +
>
>>> + * gnus-msg.el (gnus-message-replyencrypt): Default to `t'.
>>> +
>>[...]
>>> (defcustom gnus-message-replyencrypt
>>> - nil
>>> + t
>>> "Automatically encrypt replies to encrypted messages.
>>> See also the `mml-default-encrypt-method' variable."
>>> :group 'gnus-message
>>
>>Please add a :version tag as well.
>
> Just FYI, Lars did so in:
>
> commit 4abc2eab2393ea07019b39a20594f85a479d9e20
> Author: Lars Magne Ingebrigtsen <larsi@quimbies.gnus.org>
> Date: Mon Jan 3 05:49:16 2011 +0100
diff --git a/lisp/gnus-msg.el b/lisp/gnus-msg.el
index 6dfdb4c..c262900 100644
--- a/lisp/gnus-msg.el
+++ b/lisp/gnus-msg.el
[...]
-(defcustom gnus-message-replyencrypt
- t
+(defcustom gnus-message-replyencrypt t
"Automatically encrypt replies to encrypted messages.
See also the `mml-default-encrypt-method' variable."
+ :version "22.1"
:group 'gnus-message
:type 'boolean)
Hm, it should read "24.1", not "22.1" because the default changed in
24.1.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Encrypt replies to encrypted messages by default.
2011-01-03 22:18 ` Reiner Steib
@ 2011-01-03 22:23 ` Karl Fogel
2011-01-04 0:03 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 7+ messages in thread
From: Karl Fogel @ 2011-01-03 22:23 UTC (permalink / raw)
To: ding
Reiner Steib <reinersteib+gmane@imap.cc> writes:
>diff --git a/lisp/gnus-msg.el b/lisp/gnus-msg.el
>index 6dfdb4c..c262900 100644
>--- a/lisp/gnus-msg.el
>+++ b/lisp/gnus-msg.el
>[...]
>
>-(defcustom gnus-message-replyencrypt
>- t
>+(defcustom gnus-message-replyencrypt t
> "Automatically encrypt replies to encrypted messages.
> See also the `mml-default-encrypt-method' variable."
>+ :version "22.1"
> :group 'gnus-message
> :type 'boolean)
>
>Hm, it should read "24.1", not "22.1" because the default changed in
>24.1.
Also, I have to admit I was wondering why the `t' was brought up to be
on the same line as the variable's name, when the other similar
variables in that file keep the value on the second line...
-Karl (please CC me on replies, as Reiner has done)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Encrypt replies to encrypted messages by default.
2011-01-03 22:23 ` Karl Fogel
@ 2011-01-04 0:03 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 7+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-01-04 0:03 UTC (permalink / raw)
To: Karl Fogel; +Cc: ding
Karl Fogel <kfogel@red-bean.com> writes:
>>Hm, it should read "24.1", not "22.1" because the default changed in
>>24.1.
Fixed now.
> Also, I have to admit I was wondering why the `t' was brought up to be
> on the same line as the variable's name, when the other similar
> variables in that file keep the value on the second line...
I thought it looked prettier that way.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-01-04 0:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-03 1:43 [PATCH] Encrypt replies to encrypted messages by default Karl Fogel
2011-01-03 4:49 ` Lars Magne Ingebrigtsen
2011-01-03 7:30 ` Reiner Steib
2011-01-03 18:01 ` Karl Fogel
2011-01-03 22:18 ` Reiner Steib
2011-01-03 22:23 ` Karl Fogel
2011-01-04 0:03 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).