[PATCH] gnus-expand-group-parameter: Only return and act on what was matched

[PATCH] gnus-expand-group-parameter: Only return and act on what was matched

[Julien Danjou]

Signed-off-by: Julien Danjou <julien@danjou.info>
---
Hi,

Is something like the following acceptable?

I've groups like:
nnimap+Naquadah:lists.debian.devel

and gnus-parameters set to something like:

        ("lists\\.debian\\.\\(.+\\)$"
         (gnus-use-scoring t)
         (to-list . "debian-\\1@lists.debian.org")
         (subscribed . t))))

With the current code, the To is set to
   nnimap+Naquadah:debian-devel@lists.debian.org
which is annoying. :-(
It only replaces what matched, but do not remove what was not matched.

With that patch it does the right thing:

     debian-devel@lists.debian.org

WDYT?

 lisp/ChangeLog |    3 +++
 lisp/gnus.el   |   13 +++++++------
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 7605a87..d5a0717 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,8 @@
 2010-10-06  Julien Danjou  <julien@danjou.info>
 
+	* gnus.el (gnus-expand-group-parameter): Only return and act on what
+	was matched.
+
 	* sieve-manage.el: Update example in `Commentary'.
 
 	* sieve.el (sieve-open-server): Use sieve-manage-authenticate.
diff --git a/lisp/gnus.el b/lisp/gnus.el
index 531374b..64e2aa5 100644
--- a/lisp/gnus.el
+++ b/lisp/gnus.el
@@ -3809,12 +3809,13 @@ You should probably use `gnus-find-method-for-group' instead."
 
 (defun gnus-expand-group-parameter (match value group)
   "Use MATCH to expand VALUE in GROUP."
-  (with-temp-buffer
-    (insert group)
-    (goto-char (point-min))
-    (while (re-search-forward match nil t)
-      (replace-match value))
-    (buffer-string)))
+  (let ((start (string-match match group)))
+    (if start
+        (let ((matched-string (substring group start (match-end 0))))
+          ;; Build match groups
+          (string-match match matched-string)
+          (replace-match value nil nil matched-string))
+      group)))
 
 (defun gnus-expand-group-parameters (match parameters group)
   "Go through PARAMETERS and expand them according to the match data."
-- 
1.7.1

Re: [PATCH] gnus-expand-group-parameter: Only return and act on what was matched

[Lars Magne Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

> +	* gnus.el (gnus-expand-group-parameter): Only return and act on what
> +	was matched.

I'm not 100% what the total effects of this would be, but it looks good
to me.  Apply it and we'll see what happens...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen