Gnus development mailing list
 help / color / mirror / Atom feed
From: Jesper Harder <harder@myrealbox.com>
Subject: Re: [PATCH] Skip over citations and signature (resend)
Date: Thu, 10 Apr 2003 02:06:12 +0200	[thread overview]
Message-ID: <m34r572p3f.fsf@defun.localdomain> (raw)
In-Reply-To: <87k7e3jlv7.fsf@mulligatwani.msrl.com>

Michael Shields <shields@msrl.com> writes:

> Jesper Harder <harder@myrealbox.com> wrote:
>>> 2003-02-12  Michael Shields  <shields@msrl.com>
>>>
>>> 	* gnus-sum.el (gnus-article-goto-next-page,
>>> 	gnus-article-goto-prev-page): Call gnus-summary-*-page, instead of
>>> 	relying on the summary bindings of `n' and `p'.
>>
>> Michael, could you check if it's really required -- this change breaks
>> gnus-pick-mode.
>
> In what way does it break?  It looks to me that gnus-pick-mode does not
> change the bindings of `n' or `p'; they are not in gnus-pick-mode-map.

It displays the summary buffer.  The point of pick-mode is that you only
want to see the article buffer after selecting the articles to read.

There's also some code in `gnus-article-read-summary-keys' that appears
to deal with pick-mode specially -- stuff like

   (let (gnus-pick-mode)

I'm not sure exactly what the purpose is :-)

I also get an error after reading the last selected article and exiting
the group

gnus-article-goto-next-page: Wrong type argument: window-live-p,#<window 3>

Both problems disappear after reverting the patch.



  reply	other threads:[~2003-04-10  0:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-11  4:21 Michael Shields
2003-02-12 14:58 ` Kai Großjohann
2003-02-12 17:55 ` Michael Shields
2003-02-12 20:21   ` Kai Großjohann
2003-04-09 21:42   ` Jesper Harder
2003-04-09 23:23     ` Michael Shields
2003-04-10  0:06       ` Jesper Harder [this message]
2003-02-12 20:26 ` Kai Großjohann
2003-02-12 23:30   ` Michael Shields
2003-02-13 11:29     ` Kai Großjohann
2003-02-12 22:08 ` Frank Haun
2003-02-13  0:34   ` Katsumi Yamaoka
2003-02-13  1:07     ` Frank Haun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m34r572p3f.fsf@defun.localdomain \
    --to=harder@myrealbox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).