gnus-demon problem

gnus-demon problem

[Robert Pluim]

gnus-demon-add-handler was erroring out on me, obviously nobody uses it
;)

diff --git a/lisp/gnus-demon.el b/lisp/gnus-demon.el
index b33a673..ad40117 100644
--- a/lisp/gnus-demon.el
+++ b/lisp/gnus-demon.el
@@ -128,11 +128,11 @@ Emacs has been idle for IDLE `gnus-demon-timestep's."
              ;; (func number t)
              ;; Call when Emacs has been idle for `time'
              ((and (numberp time) (eq idle t))
-              (run-with-timer t time 'gnus-demon-run-callback func time))
+              (run-with-timer time time 'gnus-demon-run-callback func time))
              ;; (func number number)
              ;; Call every `time' when Emacs has been idle for `idle'
              ((and (numberp time) (numberp idle))
-              (run-with-timer t time 'gnus-demon-run-callback func idle))
+              (run-with-timer time time 'gnus-demon-run-callback func idle))
              ;; (func nil number)
              ;; Only call when Emacs has been idle for `idle'
              ((and (null time) (numberp idle))

Re: gnus-demon problem

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

On Wed, Dec 08 2010, Robert Pluim wrote:

> gnus-demon-add-handler was erroring out on me, obviously nobody uses it

What was the error? I do not see what's invalid in the current code at
first glance.

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: gnus-demon problem

[Robert Pluim]

Julien Danjou <julien@danjou.info> writes:

> On Wed, Dec 08 2010, Robert Pluim wrote:
>
>> gnus-demon-add-handler was erroring out on me, obviously nobody uses it
>
> What was the error? I do not see what's invalid in the current code at
> first glance.

It was complaining that the first argument was not a number, which it
isn't, it's 't :)


Regards

Robert

Re: gnus-demon problem

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

On Wed, Dec 08 2010, Robert Pluim wrote:

> It was complaining that the first argument was not a number, which it
> isn't, it's 't :)

What's your Emacs version then?

Emacs >= 23.2 accepts t as argument.

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: gnus-demon problem

[Robert Pluim]

Julien Danjou <julien@danjou.info> writes:

> On Wed, Dec 08 2010, Robert Pluim wrote:
>
>> It was complaining that the first argument was not a number, which it
>> isn't, it's 't :)
>
> What's your Emacs version then?
>

XEmacs 21.5  (beta29) "garbanzo" 5663ae9a8989+ [Lucid] (i686-pc-cygwin,
Mule) of Tue Oct 12 2010 on RPluim

The docstring for run-with-timer is:

  `run-with-timer' is an interactive compiled Lisp function
    -- loaded from "timer-funcs"
  (run-with-timer SECS REPEAT FUNCTION &rest ARGS)
  
  Documentation:
  Perform an action after a delay of SECS seconds.
  Repeat the action every REPEAT seconds, if REPEAT is non-nil.
  SECS and REPEAT may be integers or floating point numbers.
  The action is to call FUNCTION with arguments ARGS.

which appears to be the same as in emacs trunk

I think we can argue about whether that docstring allows 't or not, it
certainly doesn't specify the semantics very well.

Regards

Robert

Re: gnus-demon problem

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

On Wed, Dec 08 2010, Robert Pluim wrote:

> XEmacs 21.5  (beta29) "garbanzo" 5663ae9a8989+ [Lucid] (i686-pc-cygwin,
> Mule) of Tue Oct 12 2010 on RPluim

Sigh. I hate XEmacs.

> which appears to be the same as in emacs trunk

Not if you look at the real function behind, run-at-time.

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: gnus-demon problem

[Robert Pluim]

Julien Danjou <julien@danjou.info> writes:

> On Wed, Dec 08 2010, Robert Pluim wrote:
>
>> XEmacs 21.5  (beta29) "garbanzo" 5663ae9a8989+ [Lucid] (i686-pc-cygwin,
>> Mule) of Tue Oct 12 2010 on RPluim
>
> Sigh. I hate XEmacs.

We're not the ones who changed the semantics.

>> which appears to be the same as in emacs trunk
>
> Not if you look at the real function behind, run-at-time.

Then the documentation needs to be updated.

Robert

Re: gnus-demon problem

[Lars Magne Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> gnus-demon-add-handler was erroring out on me, obviously nobody uses it
> ;)

Looks like we both applied the patch...  er...  Anyway, should be OK now
again.  Unless I messed up with git again.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen