From: Mike McEwan <mike@lotusland.demon.co.uk>
Subject: `gnus-group-read-group' doesn't use `select-article'?
Date: 04 Aug 1998 20:53:42 +0100 [thread overview]
Message-ID: <m390l47cc9.fsf@lotusland.demon.co.uk> (raw)
Well, I tinkered with the above `new' parameter to
`gnus-group-read-group' and friends, but it just wasn't working. At
least, not the way I expect it to.
After the usual session with edebug it seemed that `select-article'
wasn't being passed to from `gnus-summary-read-group' to
`gnus-summary-read-group-1'. The following patch does it for me (Lars,
I'm sure you can let me know if I'm missing something here).
Having got `select-article' to be passed to
`gnus-summary-read-group-1', I then noticed that where `old' articles
were being selected due to `gnus-fetch-old-headers' not being `nil',
they were all being marked `old' regardless. Setting
`gnus-newsgroup-unselected' in the following, again, does it for me.
--
Mike.
--- ChangeLog.orig Tue Aug 4 04:26:20 1998
+++ ChangeLog Tue Aug 4 20:27:02 1998
@@ -1,3 +1,12 @@
+1998-08-04 Mike McEwan <mike@lotusland.demon.co.uk>
+
+ * gnus-sum.el (gnus-select-newsgroup): Set
+ `gnus-newsgroup-unselected' when selecting specific articles via
+ SELECT-ARTICLE - there may be more headers to fetch if
+ `gnus-fetch-old-headers' is non-nil.
+ (gnus-summary-read-group): pass SELECT-ARTICLE to
+ `gnus-summary-read-group-1' and reset to nil when going to next group.
+
Tue Aug 4 05:25:01 1998 Lars Magne Ingebrigtsen <larsi@menja.ifi.uio.no>
* gnus.el: Gnus v5.6.28 is released.
--- gnus-sum.el.orig Mon Jul 27 02:25:51 1998
+++ gnus-sum.el Tue Aug 4 20:16:01 1998
@@ -2519,9 +2519,10 @@
(let ((gnus-auto-select-next nil))
(or (gnus-summary-read-group-1
group show-all no-article
- kill-buffer no-display)
- (setq show-all nil)
- select-article))))
+ kill-buffer no-display
+ select-article)
+ (setq show-all nil
+ select-article nil)))))
(eq gnus-auto-select-next 'quietly))
(set-buffer gnus-group-buffer)
;; The entry function called above goes to the next
@@ -3872,7 +3873,12 @@
(unless (gnus-ephemeral-group-p gnus-newsgroup-name)
(gnus-group-update-group group))
- (setq articles (or select-articles (gnus-articles-to-read group read-all)))
+ (if (setq articles select-articles)
+ (setq gnus-newsgroup-unselected
+ (gnus-sorted-intersection
+ gnus-newsgroup-unreads
+ (gnus-sorted-complement gnus-newsgroup-unreads articles)))
+ (setq articles (gnus-articles-to-read group read-all)))
(cond
((null articles)
next reply other threads:[~1998-08-04 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-08-04 19:53 Mike McEwan [this message]
1998-08-04 20:33 ` Mike McEwan
1998-08-05 6:50 ` Kai Grossjohann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m390l47cc9.fsf@lotusland.demon.co.uk \
--to=mike@lotusland.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).