Re: gnus-split-references tweak

[Jesper Harder <harder@ifa.au.dk>]

prj@po.cwru.edu (Paul Jarc) writes:

> Jesper Harder <harder@ifa.au.dk> wrote:
>> prj@po.cwru.edu (Paul Jarc) writes:
>>> Hm.  It seems this actually isn't sufficient for recognizing them
>>> anyway.  I'm not sure what else would need to be changed, though.
>>
>> Maybe you also have to change the regexp in `gnus-parent-id':
>>
>>       (when (string-match "<[^> \t]+>\\'" references)
>
> Oops.  Yep, that works.  I'll commit it tomorrow if no one objects.
> -      (when (string-match "<[^> \t]+>\\'" references)
> -       (match-string 0 references)))))
> +      (when (string-match "\(<[^<]+[^< \t]\)[ \t]*\\'" references)
> +       (match-string 1 references)))))

You missed a couple of backslashes in the regexp, it should be

  "\\(<[^<]+[^< \t]\\)[ \t]*\\'"

But this regexp is rather expensive compared to the old one
(`gnus-parent-id' is called several times on each article).  Entering a
10k group was 15% slower for me.

I think this one:

      (when (string-match "\\(<[^>]+>\\)[ \t]*\\'" references)
	(match-string 1 references)))))

is more efficient -- the performance penalty was only about 2%.