cvslog

cvslog

[ShengHuo ZHU]

I still got a warning:

cvslog: can't open /tmp/cvs.1002.6280: No such file or directory

ShengHuo

Re: cvslog

[Russ Allbery]

ShengHuo ZHU <zsh@cs.rochester.edu> writes:

> I still got a warning:

> cvslog: can't open /tmp/cvs.1002.6280: No such file or directory

This generally indicates that cvslog is configured to merge multidirectory
commit messages (the -m option), but that cvsprep is not installed or is
not running correctly.

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>

Re: cvslog

[Lars Magne Ingebrigtsen]

Russ Allbery <rra@stanford.edu> writes:

> This generally indicates that cvslog is configured to merge multidirectory
> commit messages (the -m option), but that cvsprep is not installed or is
> not running correctly.

Right.  I was experimenting a bit to see what made cvslog infloop.
I've now removed it again.

I think I've found what triggers it.  If I check something in (and I'm
doing all this via pcl-cvs, if that matters), and I leave the commmit
message blank, cvslog will infloop until I kill(1) it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: cvslog

[Russ Allbery]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> I think I've found what triggers it.  If I check something in (and I'm
> doing all this via pcl-cvs, if that matters), and I leave the commmit
> message blank, cvslog will infloop until I kill(1) it.

Aha.  Try this patch.

Index: cvslog
===================================================================
RCS file: /afs/ir/cvs/leland/CVSROOT/cvslog,v
retrieving revision 1.25
diff -u -r1.25 cvslog
--- cvslog      30 Dec 2001 22:34:34 -0000      1.25
+++ cvslog      2 Jan 2002 05:23:03 -0000
@@ -343,8 +343,8 @@
 sub parse_message {
     my $data = shift;
     my @message = <STDIN>;
-    shift @message while ($message[0] =~ /^\s*$/);
-    pop @message while ($message[-1] =~ /^\s*$/);
+    shift @message while (@message && $message[0] =~ /^\s*$/);
+    pop @message while (@message && $message[-1] =~ /^\s*$/);
     $$data{message}{text} = [ @message ];
 }

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>

Re: cvslog

[Lars Magne Ingebrigtsen]

Russ Allbery <rra@stanford.edu> writes:

> Aha.  Try this patch.

Thanks; that fixed the problem.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen