new spam.el

new spam.el

[Ted Zlatanov]

I have put a new version of spam.el in the CVS repository, and updated
the ChangeLog.  All the credit should go to François Pinard, who did
the hard work of putting together all the code.  The documentation is
not ready, but I think the comments in the code will be sufficient to
get people started (and those were written by François as well).  Do
let me know if you have any questions, and I'll do my best to answer.

There's a few FIXMEs in the code that I'll try to resolve soon (but
feel free to provide patches if you like).  The key bindings are not
perfect, the blackhole check is still broken (as I reported to the
ding list some time ago), but bogofilter and black/whitelists should
work right away.

The spam-split function is the main point of interest for this
release: when added to your nnimap/nnmail fancy split, it will return
either nil or the value of the spam-split-group variable, which is
"spam" by default.  The spam detection is done with several variables
you can customize.

The default spam-split-group value may be a problem if your primary
backend is nntp, for instance (since the "spam" group won't be
writeable), so make sure to customize that.  See the comments for more
details.

Again, feel free to ask any questions or make any suggestions.

Ted

Re: new spam.el

[Katsumi Yamaoka]

Hi,

>>>>> In <m3fzvrpe3w.fsf@heechee.beld.net>
>>>>>	Ted Zlatanov <tzz@lifelogs.com> wrote:

> I have put a new version of spam.el in the CVS repository, and updated
> the ChangeLog...

I got the following error while compiling new spam.el:

Compiling /Work/gnus/lisp/spam.el...
While compiling spam-check-bbdb in file /Work/gnus/lisp/spam.el:
  !! error (("net must be atomic"))

It is said by the macro `bbdb-search' which requires that the
4th argument is a string or a symbol.  So, I think the function
`spam-check-bbdb' can be modified as follows:

(defun spam-check-bbdb ()
  "We want people, who are in bbdb not to be splitted to spam"
  (let ((who (message-fetch-field "from")))
    (when who
      (setq who (regexp-quote (cadr (gnus-extract-address-components who))))
      (bbdb-search (bbdb-records) nil nil who))))
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: new spam.el

[Ted Zlatanov]

On Tue, 01 Oct 2002, yamaoka@jpl.org wrote:
> It is said by the macro `bbdb-search' which requires that the
> 4th argument is a string or a symbol.  So, I think the function
> `spam-check-bbdb' can be modified as follows:
> 
> (defun spam-check-bbdb ()
>   "We want people, who are in bbdb not to be splitted to spam"
>   (let ((who (message-fetch-field "from")))
>     (when who
>       (setq who (regexp-quote (cadr (gnus-extract-address-components who)))) 
>       (bbdb-search (bbdb-records) nil nil who))))

I added the change, with one more modification (we want to return the
value of spam-split-group, it's not t or nil).  Thank you.

I also fixed spam-check-whitelist, which also returned t or nil and
should return spam-split-group or nil.

I'm doing this to be consistent with Francois' code, which let each
checking function return a string (spam-split-group) or nil, rather
than have the spam-split function aggregate all the return values of t
or nil.

Ted