make-obsolete-variable and defcustom versions (was: [gnus git] branch master updated: =1= (nnimap-split-rule): Mark as obsolete.)

make-obsolete-variable and defcustom versions (was: [gnus git] branch master updated: =1= (nnimap-split-rule): Mark as obsolete.)

[Reiner Steib]

On Wed, Sep 29 2010, Lars Magne Ingebrigtsen wrote:

> +(make-obsolete-variable 'nnimap-split-rule "see `nnimap-split-methods'"
> +			"Gnus 5.13")

I think we should use the Emacs version here (or both, Emacs and
Gnus), like we do for the defcustom :version tag.

For the later, we could also use ":package-version" (cf. mh-e/*.el),
but we probable need to deal with (XEmacs) compatibility then.

,----[ grep -A1 -nH -e make-obsolete-variable *.el ]
| gnus-art.el:730:(make-obsolete-variable 'gnus-article-hide-pgp-hook nil
| gnus-art.el-731-			"Gnus 5.10 (Emacs-22.1)")
| --
| gnus-art.el:1226:(make-obsolete-variable 'gnus-treat-strip-pgp nil
| gnus-art.el-1227-			"Gnus 5.10 (Emacs 22.1)")
| --
| gnus-art.el:1417:(make-obsolete-variable 'gnus-treat-display-xface
| gnus-art.el-1418-			'gnus-treat-display-x-face "22.1")
| --
| gnus-msg.el:151:(make-obsolete-variable 'gnus-inews-mark-gcc-as-read
| gnus-msg.el-152-			'gnus-gcc-mark-as-read "Emacs 22.1")
| --
| nnir.el:515:(make-obsolete-variable 'nnir-swish-e-index-file
| nnir.el-516-			'nnir-swish-e-index-files "Emacs 23.1")
| --
| nnmail.el:245:(make-obsolete-variable 'nnmail-spool-file 'mail-sources
| nnmail.el-246-			"Gnus 5.9 (Emacs 22.1)")
| --
| spam.el:417:(make-obsolete-variable 'spam-ifile-path 'spam-ifile-program
| spam.el-418-                        "Gnus 5.10.9 (Emacs 22.1)")
| --
| spam.el:425:(make-obsolete-variable 'spam-ifile-database-path 'spam-ifile-database
| spam.el-426-                        "Gnus 5.10.9 (Emacs 22.1)")
| --
| spam.el:456:(make-obsolete-variable 'spam-bogofilter-path 'spam-bogofilter-program
| spam.el-457-                        "Gnus 5.10.9 (Emacs 22.1)")
| --
| spam.el:508:(make-obsolete-variable 'spam-bsfilter-path 'spam-bsfilter-program
| spam.el-509-                        "Gnus 5.10.9 (Emacs 22.1)")
| --
| spam.el:574:(make-obsolete-variable 'spam-spamassassin-path
| spam.el-575-  'spam-spamassassin-program "Gnus 5.10.9 (Emacs 22.1)")
| --
| spam.el:606:(make-obsolete-variable 'spam-sa-learn-path 'spam-sa-learn-program
| spam.el-607-                        "Gnus 5.10.9 (Emacs 22.1)")
`----

"Emacs-22.1" should be "Emacs 22.1".

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: make-obsolete-variable and defcustom versions

[Lars Magne Ingebrigtsen]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> I think we should use the Emacs version here (or both, Emacs and
> Gnus), like we do for the defcustom :version tag.

Ok; I've now regularised them to have the Emacs version, or both.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen