Re: [patch] `M-Return' on quoted text failed when not using prefix `>'.

Re: [patch] `M-Return' on quoted text failed when not using prefix `>'.

[Lars Magne Ingebrigtsen]

Rui Zhu <sprache@iname.com> writes:

> The problem is I'd like to use `| ' as quote prefix when composing
> replies,

Well, I think that's a problem, too, and the solution is to stop doing 
that.  :-)

Quoted text is represented by ">" in news; how you present that when
you're reading is up to you.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [patch] `M-Return' on quoted text failed when not using prefix `>'.

[Rui Zhu]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Rui Zhu <sprache@iname.com> writes:
> 
> > The problem is I'd like to use `> ' as quote prefix when composing
> > replies,

Sorry for the rant I've made.  In fact the patch is not well thought
out, think if I encounter such a prefix `> Super> ', sigh, not super any
more. ;-(

The point is that the code in `message-newline-and-reformat' seems to
presume the cited text *must* have prefix include char `>', because
`supercite-thing' must get matched.  But the situation is, I think,
supercite prefix can only occure one or zero time, and at the end of
prefix.  Or you mean `supercite-thing' can degenerate to normal prefix.

> Well, I think that's a problem, too, and the solution is to stop doing
> that. :-)

I've just thought `| ' looks good and tried to work out the troubles
it makes to me.  But now I thought a little more about it: It makes
troubles to others too, just like to myself.  The existence of the
convention is not without its reason.

#\Rui

-- 
Happy Gnusing!
Happy Easter!

Re: [patch] `M-Return' on quoted text failed when not using prefix `>'.

[Lars Magne Ingebrigtsen]

Rui Zhu <sprache@iname.com> writes:

> The point is that the code in `message-newline-and-reformat' seems to
> presume the cited text *must* have prefix include char `>', because
> `supercite-thing' must get matched.  But the situation is, I think,
> supercite prefix can only occure one or zero time, and at the end of
> prefix.  Or you mean `supercite-thing' can degenerate to normal prefix.

I don't know much about how Supercite works, but I think, perhaps,
that it should have its own functions for doing stuff like this, since
it is what knows best what its variables are.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [patch] `M-Return' on quoted text failed when not using prefix `>'.

[Kai Großjohann]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> I don't know much about how Supercite works, but I think, perhaps,
> that it should have its own functions for doing stuff like this, since
> it is what knows best what its variables are.

Supercite has `C-c C-p C-o' which is like `C-o' and not `RET', but
that's close enough I think.

kai
-- 
Beware of flying birch trees.

[patch] `M-Return' on quoted text failed when not using prefix `>'.

[Rui Zhu]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

Hi, there,

The problem is I'd like to use `| ' as quote prefix when composing
replies, but `message-newline-and-reformat' always searches `>', so it
fails for reformat the text after inserting 3 `\n'.

This one line patch is against today's CVS version.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch for `message-newline-and-reformat' in message.el --]
[-- Type: text/x-patch, Size: 332 bytes --]

--- message.el.orig	Sat Mar 18 17:59:57 2000
+++ message.el	Sat Mar 18 18:13:16 2000
@@ -1627,7 +1627,7 @@
     (unless (bolp)
       (save-excursion
 	(beginning-of-line)
-	(when (looking-at (concat prefix
+	(when (looking-at (concat prefix "\\|"
 				  supercite-thing))
 	  (setq quoted (match-string 0))))
       (insert "\n"))

[-- Attachment #3: Type: text/plain, Size: 1916 bytes --]


BTW, it is still trouble some, because default `fill-paragraph' seems
not like `| ', `: ', etc.  So I now use a external format filter called
`par', following is glue codes.

;;;------------- External Paragraph Reformatter -----------------------
(defvar my-fill-external-program "par")
(defun my-fill-with-external (&optional formatter)
  "Fill region/paragraph with your favorite external formatter.

Fill the region in the sense of `transient-mark-mode' being `t', but
you don't need to use transient mark mode.  Or fill the paragraph
under the point if no region marked. 

The external formatter can be set using variable
`my-fill-external-program'.  `par' is highly recommended; `fmt' in Gnu
`textutils' is one choice; or others which I don't know but can be
used as a filter from stdin to stdout.

Prefix can be used to specify your external formatter or more command
line options."

  (interactive
   (let ((not-use-default current-prefix-arg))
     (list (if not-use-default
               (read-string "Fill formatter: " 
                            (format "%s " my-fill-external-program))
             my-fill-external-program))))
  (let ((old-is-transient transient-mark-mode)
        (formatter (or formatter my-fill-external-program)))
    (unwind-protect
        (progn
          (setq transient-mark-mode t)
          (unless mark-active
            (mark-paragraph))
          (shell-command-on-region (region-beginning) (region-end) 
                                   formatter nil t nil)
          t)                            ; return `t' for `fill-paragraph'
      (setq transient-mark-mode old-is-transient))))

(add-hook 'message-mode-hook
          #'(lambda ()
              (make-local-variable 'fill-paragraph-function)
              (setq fill-paragraph-function 'my-fill-with-external)))

;; (global-set-key [?\C-c ?q] 'my-fill-with-external)

;;; End here

#\Rui

-- 
Happy Gnusing!