[PATCH] nnimap: Checking mailbox %s vs. Updating info for %s

[PATCH] nnimap: Checking mailbox %s vs. Updating info for %s

[Chris Brierley]

A couple of months ago I sent in a bug report detailing how moving
or copying a message from an nnimap group on one IMAP server to an
nnimap group on another IMAP server causes a bogus server entry in
the *Server* buffer with the result that subsequent invocations of
gnus-group-get-new-news cause the dreaded "Updating info for %s"
vs. the much faster "Checking mailbox %s".

Simon sent out a patch which resolved this problem, and which I've
been using successfuly since.  I just installed Gnus 5.8.4 and it
looks like Simon's patch didn't make it into the release.  I've
applied his patch to 5.8.4 and it still fixes the bug without
apparent problems.

So, I'm including Simon's patch here in the hopes that it can be
added to CVS.  Thanks.

,-----[ Patch to gnus-sum.el
| 2000-03-01  Simon Josefsson  <jas@pdc.kth.se>
| 
|         * gnus-sum.el (gnus-read-move-group-name): 
|         (gnus-summary-move-article): Use `gnus-group-method' to find out
|         what method the manually entered group belong to.
|         `gnus-group-name-to-method' doesn't return any method parameters
|         and `gnus-find-method-for-group' uses `gnus-group-name-to-method'
|         for new groups so they wouldn't work.
| 
| Index: lisp/gnus-sum.el
| ===================================================================
| RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
| retrieving revision 5.97
| diff -w -u -r5.97 gnus-sum.el
| --- lisp/gnus-sum.el	2000/02/03 16:28:49	5.97
| +++ lisp/gnus-sum.el	2000/03/01 19:45:52
| @@ -7322,7 +7322,7 @@
|              articles prefix))
|        (set (intern (format "gnus-current-%s-group" action)) to-newsgroup))
|      (setq to-method (or select-method
| -			(gnus-group-name-to-method to-newsgroup)))
| +			(gnus-group-method to-newsgroup)))
|      ;; Check the method we are to move this article to...
|      (unless (gnus-check-backend-function
|              'request-accept-article (car to-method))
| @@ -9027,14 +9027,15 @@
|        (unless to-newsgroup
|         (error "No group name entered"))
|        (or (gnus-active to-newsgroup)
| -	  (gnus-activate-group to-newsgroup)
| +	  (gnus-activate-group to-newsgroup nil nil
| +			       (gnus-group-method to-newsgroup))
|           (if (gnus-y-or-n-p (format "No such group: %s.  Create it? "
|                                      to-newsgroup))
|               (or (and (gnus-request-create-group
| -			to-newsgroup (gnus-group-name-to-method to-newsgroup))
| +			to-newsgroup (gnus-group-method to-newsgroup))
|                        (gnus-activate-group
|                         to-newsgroup nil nil
| -			(gnus-group-name-to-method to-newsgroup))
| +			(gnus-group-method to-newsgroup))
|                        (gnus-subscribe-group to-newsgroup))
|                   (error "Couldn't create group %s" to-newsgroup)))
|           (error "No such group: %s" to-newsgroup)))
`-----

Re: [PATCH] nnimap: Checking mailbox %s vs. Updating info for %s

[Lars Magne Ingebrigtsen]

Chris Brierley <brierley@pobox.com> writes:

> So, I'm including Simon's patch here in the hopes that it can be
> added to CVS.  Thanks.
> 
> ,-----[ Patch to gnus-sum.el
> | 2000-03-01  Simon Josefsson  <jas@pdc.kth.se>
> | 

Eurm -- could you un-manglify that patch and resend it?

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [PATCH] nnimap: Checking mailbox %s vs. Updating info for %s

[Chris Brierley]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

On 2000-04-20, Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
> Chris Brierley <brierley@pobox.com> writes:
> 
> > So, I'm including Simon's patch here in the hopes that it can
> > be added to CVS.  Thanks.
> 
> Eurm -- could you un-manglify that patch and resend it?

Oh, well fine.  But it was *much* prettier the way I had it
before.  ;)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-sum.patch --]
[-- Type: text/x-patch, Size: 1272 bytes --]

--- lisp/gnus-sum.el	2000/02/03 16:28:49	5.97
+++ lisp/gnus-sum.el	2000/03/01 19:45:52
@@ -7322,7 +7322,7 @@
 	     articles prefix))
       (set (intern (format "gnus-current-%s-group" action)) to-newsgroup))
     (setq to-method (or select-method
-			(gnus-group-name-to-method to-newsgroup)))
+			(gnus-group-method to-newsgroup)))
     ;; Check the method we are to move this article to...
     (unless (gnus-check-backend-function
 	     'request-accept-article (car to-method))
@@ -9027,14 +9027,15 @@
       (unless to-newsgroup
 	(error "No group name entered"))
       (or (gnus-active to-newsgroup)
-	  (gnus-activate-group to-newsgroup)
+	  (gnus-activate-group to-newsgroup nil nil
+			       (gnus-group-method to-newsgroup))
 	  (if (gnus-y-or-n-p (format "No such group: %s.  Create it? "
 				     to-newsgroup))
 	      (or (and (gnus-request-create-group
-			to-newsgroup (gnus-group-name-to-method to-newsgroup))
+			to-newsgroup (gnus-group-method to-newsgroup))
 		       (gnus-activate-group
 			to-newsgroup nil nil
-			(gnus-group-name-to-method to-newsgroup))
+			(gnus-group-method to-newsgroup))
 		       (gnus-subscribe-group to-newsgroup))
 		  (error "Couldn't create group %s" to-newsgroup)))
 	  (error "No such group: %s" to-newsgroup)))