shr-width question has no effect for this mail

shr-width question has no effect for this mail

[Tassilo Horn]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

Hi all,

`shr-width' defaults to `fill-column' which is 79 here.  Nevertheless,
the attached mail is rendered much wider than that.  Why is that?

Bye,
Tassilo


[-- Attachment #2: Type: message/rfc822, Size: 7947 bytes --]

[-- Attachment #2.1.1.1: Type: text/plain, Size: 881 bytes --]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100230/
-----------------------------------------------------------

(Updated 2010-12-29 22:21:02.767813)


Review request for rekonq.


Changes
-------

it now uses a QGraphicsEffect to animate the highlight. added tabHighlightEffect class.


Summary
-------

This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window).

I don't have a kde git account, so please merge it if you like it.


Diffs (updated)
-----

  src/CMakeLists.txt 6cf2651 
  src/mainview.cpp 850101e 
  src/tabbar.h acd8e2f 
  src/tabbar.cpp 286d7d4 

Diff: http://git.reviewboard.kde.org/r/100230/diff


Testing
-------

compiles and works


Thanks,

Johannes


[-- Attachment #2.1.1.2: Type: text/html, Size: 3025 bytes --]

[-- Attachment #2.1.2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
rekonq mailing list
rekonq-RoXCvvDuEio@public.gmane.org
https://mail.kde.org/mailman/listinfo/rekonq

Re: shr-width question has no effect for this mail

[Lars Magne Ingebrigtsen]

Tassilo Horn <tassilo@member.fsf.org> writes:

> `shr-width' defaults to `fill-column' which is 79 here.  Nevertheless,
> the attached mail is rendered much wider than that.  Why is that?

Because there's a table in the message that can't be rendered that
narrowly.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: shr-width question has no effect for this mail

[Tassilo Horn]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

Hi Lars,

>> `shr-width' defaults to `fill-column' which is 79 here.
>> Nevertheless, the attached mail is rendered much wider than that.
>> Why is that?
>
> Because there's a table in the message that can't be rendered that
> narrowly.

Ah, you mean because the table contains cells with <pre>-text that
cannot be broken around, right?

Bye,
Tassilo
-- 
Sent from my Emacs

Re: shr-width question has no effect for this mail

[Lars Magne Ingebrigtsen]

Tassilo Horn <tassilo@member.fsf.org> writes:

> Ah, you mean because the table contains cells with <pre>-text that
> cannot be broken around, right?

Yes, or some other wide unbreakable text...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen