Gnus development mailing list
 help / color / mirror / Atom feed
* Missing marks with nnimap
@ 2010-10-29 11:29 Knut Anders Hatlen
  2010-10-29 23:35 ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 5+ messages in thread
From: Knut Anders Hatlen @ 2010-10-29 11:29 UTC (permalink / raw)
  To: ding

I tried to access a Zimbra server using the latest gnus from git, and
noticed that it didn't see the ticks on the articles. For example, in
one group with 211 articles (2 unread, 12 ticked), I see the 2 unread
articles as unread, the other 209 articles as read, but none as ticked.

G E says:

("mail.autoderby" 3
 ((1 . 1222))
 ((seen 1012
	(1015 . 1224)))
 nil
 ((modseq)
  (uidvalidity . "6567453")
  (active 1012 . 1224)
  (permanent-flags %Seen %Deleted %Answered %Forwarded %Redirected %Flagged %Hidden %Draft $MDNSent)))

*nnimap <server> *nntpd** says this after M-g:

* 211 EXISTS^M
* 0 RECENT^M
* OK [UIDVALIDITY 6567453] UID validity status^M
* OK [UIDNEXT 1225] Predicted next UID^M
* FLAGS (%Seen %Deleted %Answered %Forwarded %Redirected %Flagged %Hidden %Draft $MDNSent)^M
* OK [PERMANENTFLAGS (%Seen %Deleted %Answered %Forwarded %Redirected %Flagged %Hidden %Draft $MDNSent)] Permanent flags^M
134 OK [READ-WRITE] SELECT completed^M
* 1 FETCH (FLAGS (%Flagged) UID 1012)^M
* 2 FETCH (FLAGS (%Seen) UID 1015)^M
* 3 FETCH (FLAGS (%Seen) UID 1016)^M
* 4 FETCH (FLAGS (%Seen) UID 1017)^M
* 5 FETCH (FLAGS (%Seen) UID 1018)^M
(...)
* 201 FETCH (FLAGS (%Seen) UID 1214)^M
* 202 FETCH (FLAGS (%Flagged) UID 1215)^M
* 203 FETCH (FLAGS (%Seen) UID 1216)^M
* 204 FETCH (FLAGS (%Seen) UID 1217)^M
* 205 FETCH (FLAGS (%Seen) UID 1218)^M
* 206 FETCH (FLAGS (%Seen) UID 1219)^M
* 207 FETCH (FLAGS (%Seen) UID 1220)^M
* 208 FETCH (FLAGS (%Seen) UID 1221)^M
* 209 FETCH (FLAGS (%Seen) UID 1222)^M
* 210 FETCH (FLAGS () UID 1223)^M
* 211 FETCH (FLAGS () UID 1224)^M
135 OK UID FETCH completed^M

Does it ring any bells?

-- 
Knut Anders




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Missing marks with nnimap
  2010-10-29 11:29 Missing marks with nnimap Knut Anders Hatlen
@ 2010-10-29 23:35 ` Lars Magne Ingebrigtsen
  2010-10-30  8:45   ` Knut Anders Hatlen
  0 siblings, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-10-29 23:35 UTC (permalink / raw)
  To: ding

Knut Anders Hatlen <kahatlen@gmail.com> writes:

> *nnimap <server> *nntpd** says this after M-g:

[...]

> * OK [PERMANENTFLAGS (%Seen %Deleted %Answered %Forwarded %Redirected %Flagged %Hidden %Draft $MDNSent)] Permanent flags^M

[...]

> * 202 FETCH (FLAGS (%Flagged) UID 1215)^M

Looks OK.  What does `G E' on the group after this look like?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Missing marks with nnimap
  2010-10-29 23:35 ` Lars Magne Ingebrigtsen
@ 2010-10-30  8:45   ` Knut Anders Hatlen
  2010-10-30  9:55     ` Knut Anders Hatlen
  0 siblings, 1 reply; 5+ messages in thread
From: Knut Anders Hatlen @ 2010-10-30  8:45 UTC (permalink / raw)
  To: ding

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Knut Anders Hatlen <kahatlen@gmail.com> writes:
>
>> *nnimap <server> *nntpd** says this after M-g:
>
> [...]
>
>> * OK [PERMANENTFLAGS (%Seen %Deleted %Answered %Forwarded %Redirected %Flagged %Hidden %Draft $MDNSent)] Permanent flags^M
>
> [...]
>
>> * 202 FETCH (FLAGS (%Flagged) UID 1215)^M
>
> Looks OK.  What does `G E' on the group after this look like?

("mail.autoderby" 3
 ((1 . 1222))
 ((seen (1223 . 1224)))
 nil
 ((modseq)
  (uidvalidity . "6567453")
  (active 1012 . 1224)
  (permanent-flags %Seen %Deleted %Answered %Forwarded %Redirected %Flagged %Hidden %Draft $MDNSent)))


-- 
Knut Anders




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Missing marks with nnimap
  2010-10-30  8:45   ` Knut Anders Hatlen
@ 2010-10-30  9:55     ` Knut Anders Hatlen
  2010-10-30 11:16       ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 5+ messages in thread
From: Knut Anders Hatlen @ 2010-10-30  9:55 UTC (permalink / raw)
  To: ding

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

Knut Anders Hatlen <kahatlen@gmail.com> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> Knut Anders Hatlen <kahatlen@gmail.com> writes:
>>
>>> *nnimap <server> *nntpd** says this after M-g:
>>
>> [...]
>>
>>> * OK [PERMANENTFLAGS (%Seen %Deleted %Answered %Forwarded %Redirected %Flagged %Hidden %Draft $MDNSent)] Permanent flags^M
>>
>> [...]
>>
>>> * 202 FETCH (FLAGS (%Flagged) UID 1215)^M
>>
>> Looks OK.  What does `G E' on the group after this look like?
>
> ("mail.autoderby" 3
>  ((1 . 1222))
>  ((seen (1223 . 1224)))
>  nil
>  ((modseq)
>   (uidvalidity . "6567453")
>   (active 1012 . 1224)
>   (permanent-flags %Seen %Deleted %Answered %Forwarded %Redirected %Flagged %Hidden %Draft $MDNSent)))

Found it. The server doesn't have \* in PERMANENTFLAGS. And the
non-QRESYNC code in nnimap-update-info fails to see that \Flagged is
supported because it checks whether (%Flagged 1012 1027 ...)  is member
of permanent-flags. So it seems it's just missing a call to car before
calling memq. The attached patch made the problem go away for me.

-- 
Knut Anders

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: flags.diff --]
[-- Type: text/x-patch, Size: 510 bytes --]

diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index 8ea5063..7568807 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -1181,7 +1181,8 @@ textual parts.")
 	      (setq marks (gnus-info-marks info))
 	      (dolist (type (cdr nnimap-mark-alist))
 		(when (or (not (listp permanent-flags))
-			  (memq (assoc (caddr type) flags) permanent-flags)
+			  (memq (car (assoc (caddr type) flags))
+				permanent-flags)
 			  (memq '%* permanent-flags))
 		  (let ((old-marks (assoc (car type) marks))
 			(new-marks

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Missing marks with nnimap
  2010-10-30  9:55     ` Knut Anders Hatlen
@ 2010-10-30 11:16       ` Lars Magne Ingebrigtsen
  0 siblings, 0 replies; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-10-30 11:16 UTC (permalink / raw)
  To: ding

Knut Anders Hatlen <kahatlen@gmail.com> writes:

> Found it. The server doesn't have \* in PERMANENTFLAGS. And the
> non-QRESYNC code in nnimap-update-info fails to see that \Flagged is
> supported because it checks whether (%Flagged 1012 1027 ...)  is member
> of permanent-flags. So it seems it's just missing a call to car before
> calling memq. The attached patch made the problem go away for me.

Ah, right.  Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-10-30 11:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-29 11:29 Missing marks with nnimap Knut Anders Hatlen
2010-10-29 23:35 ` Lars Magne Ingebrigtsen
2010-10-30  8:45   ` Knut Anders Hatlen
2010-10-30  9:55     ` Knut Anders Hatlen
2010-10-30 11:16       ` Lars Magne Ingebrigtsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).