Re: BUG: NoCeM and foreign groups: does it work?

[roth@klondike.cse.ucsc.edu (Carl D. Roth)]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> roth@cse.ucsc.edu (Carl D. Roth) writes:

> > The way I've worked around points 1. and 3. above is to slightly
> > modify gnus-nocem-enter-article to match groups out of a *different*
> > hashtb than gnus-newsrc-hashtb.  This new hash table consists of the
> > gnus-group-real-name mappings of all of the groups in the newsrc.

> Yes, that sounds like the right way to do it.  Could you mail me
> patches? 

I hope posting is OK...

The patch itself also adds a debugging statement to
nocem-check-article.  I run nocem in batch mode, and I want to know
about all of the `invalid' nocem issuers.


[-- Attachment #2: .signature --]
[-- Type: text/plain, Size: 65 bytes --]

Carl Roth  mailto:roth@cse.ucsc.edu  (finger for PGP public key)

[-- Attachment #3: gnus-nocem.diff --]
[-- Type: application/octet-stream, Size: 1784 bytes --]

--- gnus-nocem.el.orig	Fri Jul 25 12:25:51 1997
+++ gnus-nocem.el	Fri Jul 25 12:29:06 1997
@@ -96,6 +96,24 @@
 (defun gnus-nocem-cache-file ()
   (concat (file-name-as-directory gnus-nocem-directory) "cache"))
 
+;;
+;; faster lookups for group names:
+;;
+
+(defvar gnus-real-group-hashtb nil
+  "Real-name mappings of subscribed groups.")
+
+(defun gnus-fill-real-hashtb ()
+  "Fill up a hash table with the real-name mappings from the user's
+active file."
+  (setq gnus-real-group-hashtb (gnus-make-hashtable 123))
+  (mapcar '(lambda (group)
+	     (setq group (gnus-group-real-name (car group)))
+	     (gnus-sethash group
+			   t
+			   gnus-real-group-hashtb))
+	  gnus-newsrc-alist))
+
 (defun gnus-nocem-scan-groups ()
   "Scan all NoCeM groups for new NoCeM messages."
   (interactive)
@@ -105,6 +123,8 @@
     (gnus-make-directory gnus-nocem-directory)
     ;; Load any previous NoCeM headers.
     (gnus-nocem-load-cache)
+    ;; Get the group name mappings:
+    (gnus-fill-real-hashtb)
     ;; Read the active file if it hasn't been read yet.
     (and (file-exists-p (gnus-nocem-active-file))
 	 (not gnus-nocem-active)
@@ -185,6 +205,8 @@
 	(narrow-to-region b e)
 	(setq issuer (mail-fetch-field "issuer"))
 	(widen)
+	(or (member issuer gnus-nocem-issuers)
+	    (message "invalid NoCeM issuer: %s" issuer))
 	(and (member issuer gnus-nocem-issuers) ; We like her....
 	     (gnus-nocem-verify-issuer issuer) ; She is who she says she is...
 	     (gnus-nocem-enter-article)	; We gobble the message..
@@ -223,7 +245,7 @@
 	  (set group nil))
 	 (t
 	  (when (gnus-gethash (gnus-group-real-name (symbol-name group))
-			      gnus-newsrc-hashtb)
+			      gnus-real-group-hashtb)
 	    ;; Valid group.
 	    (beginning-of-line)
 	    (while (= (following-char) ?\t)