gnus-icalendar export to org does not include time stamp if no description

gnus-icalendar export to org does not include time stamp if no description

[Eric S Fraga]

Hello,

I don't know whether to post this here, in the org mailing list, or an
emacs group...

I use gnus-icalendar-event-export to create org entries from calendar
invites.  For some reason, the time stamp associated with the entry is
only exported if the invite has a description field (line 483 of
gnus-icalendar.el in git version of Emacs).  As the description field is
optional, some invites do not get exported properly.  This seems wrong
to me.

I could try fixing this myself but I'm not proficient with elisp...

Please advise.

Thanks,
eric
-- 
Eric S Fraga via Emacs 27.0.50 & org 9.2.3 on Debian buster/sid

Re: gnus-icalendar export to org does not include time stamp if no description

[Robert Pluim]

>>>>> On Sun, 14 Apr 2019 12:00:24 +0100, Eric S Fraga <e.fraga@ucl.ac.uk> said:

    Eric> Hello, I don't know whether to post this here, in the org
    Eric> mailing list, or an emacs group...

    Eric> I use gnus-icalendar-event-export to create org entries from
    Eric> calendar invites.  For some reason, the time stamp
    Eric> associated with the entry is only exported if the invite has
    Eric> a description field (line 483 of gnus-icalendar.el in git
    Eric> version of Emacs).  As the description field is optional,
    Eric> some invites do not get exported properly.  This seems wrong
    Eric> to me.

    Eric> I could try fixing this myself but I'm not proficient with
    Eric> elisp...

Totally untested, as I donʼt use gnus-icalendar at all.

diff --git a/lisp/gnus/gnus-icalendar.el b/lisp/gnus/gnus-icalendar.el
index 28020a1fd0..64cc3f92a9 100644
--- a/lisp/gnus/gnus-icalendar.el
+++ b/lisp/gnus/gnus-icalendar.el
@@ -480,14 +480,14 @@ gnus-icalendar--format-participant-list
                 (org-entry-put (point) (car prop) (cdr prop)))
               props))
 
-      (when description
-        (save-restriction
-          (narrow-to-region (point) (point))
-          (insert (gnus-icalendar-event:org-timestamp event)
-                  "\n\n"
-                  description)
-          (indent-region (point-min) (point-max) 2)
-          (fill-region (point-min) (point-max))))
+      (save-restriction
+        (narrow-to-region (point) (point))
+        (insert (gnus-icalendar-event:org-timestamp event)
+                "\n\n")
+        (when description
+          (insert description))
+        (indent-region (point-min) (point-max) 2)
+        (fill-region (point-min) (point-max)))
 
       (buffer-string))))
 

Re: gnus-icalendar export to org does not include time stamp if no description

[Eric S Fraga]

On Sunday, 14 Apr 2019 at 13:21, Robert Pluim wrote:
> Totally untested, as I donʼt use gnus-icalendar at all.

Looks reasonable (i.e. makes sense to me!).  I'll try this out.  Should
this patch be suggested on the emacs-devel list or will somebody in this
group pick it up?

Thanks,
eric

-- 
Eric S Fraga via Emacs 27.0.50 & org 9.2.3 on Debian buster/sid

Re: gnus-icalendar export to org does not include time stamp if no description

[Eric S Fraga]

On Sunday, 14 Apr 2019 at 13:21, Robert Pluim wrote:
> Totally untested, as I donʼt use gnus-icalendar at all.

I've tested it a little.  Seems to work just fine.  Many thanks!

-- 
Eric S Fraga via Emacs 27.0.50 & org 9.2.3 on Debian buster/sid

Re: gnus-icalendar export to org does not include time stamp if no description

[Robert Pluim]

>>>>> On Sun, 14 Apr 2019 12:41:02 +0100, Eric S Fraga <e.fraga@ucl.ac.uk> said:

    Eric> On Sunday, 14 Apr 2019 at 13:21, Robert Pluim wrote:
    >> Totally untested, as I donʼt use gnus-icalendar at all.

    Eric> Looks reasonable (i.e. makes sense to me!).  I'll try this
    Eric> out.  Should this patch be suggested on the emacs-devel list
    Eric> or will somebody in this group pick it up?

You or someone else who actually uses that function should suggest it
there (assuming the patch works, of course).

Robert

Re: gnus-icalendar export to org does not include time stamp if no description

[Eric S Fraga]

On Sunday, 14 Apr 2019 at 14:03, Robert Pluim wrote:
> You or someone else who actually uses that function should suggest it
> there (assuming the patch works, of course).

Okay, I'll do this.  Thanks.
-- 
Eric S Fraga via Emacs 27.0.50 & org 9.2.3 on Debian buster/sid

Re: gnus-icalendar export to org does not include time stamp if no description

[Lars Ingebrigtsen]

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> On Sunday, 14 Apr 2019 at 13:21, Robert Pluim wrote:
>> Totally untested, as I donʼt use gnus-icalendar at all.
>
> I've tested it a little.  Seems to work just fine.  Many thanks!

I've now applied Robert's patch to Emacs 27.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no