what the heck happened to gnus-spec ?!

what the heck happened to gnus-spec ?!

[Didier Verna]

        The balloon-help property format spec has been broken. Here's a diff
between the latest working version I have, and the latest CVS version. I
don't understand these modifications. If they were intentional, they should
/at least/ have been ChangeLog'ed, and commented in the documentation. But
those modifications look wrong anyway.

        Does anybody remember doing this ?


--- gnus-spec.el	Wed Jan 20 01:51:17 1999
+++ /usr/local/src/pgnus/lisp/gnus-spec.el	Wed Dec  8 10:14:35 1999
@@ -291,10 +291,10 @@
   ;; SPEC-ALIST and returns a list that can be eval'ed to return the
   ;; string.  If the FORMAT string contains the specifiers %( and %)
   ;; the text between them will have the mouse-face text property.
-  ;; If the FORMAT string contains the specifiers %< and %>, the text between
+  ;; If the FORMAT string contains the specifiers %[ and %], the text between
   ;; them will have the balloon-help text property.
   (if (string-match
-       "\\`\\(.*\\)%[0-9]?[{(<]\\(.*\\)%[0-9]?[})>]\\(.*\n?\\)\\'"
+       "\\`\\(.*\\)%[0-9]?[{(«]\\(.*\\)%[0-9]?[»})]\\(.*\n?\\)\\'"
        format)
       (gnus-parse-complex-format format spec-alist)
     ;; This is a simple format.
@@ -309,13 +309,13 @@
       (replace-match "\\\"" nil t))
     (goto-char (point-min))
     (insert "(\"")
-    (while (re-search-forward "%\\([0-9]+\\)?\\([{}()<>]\\)" nil t)
+    (while (re-search-forward "%\\([0-9]+\\)?\\([«»{}()]\\)" nil t)
       (let ((number (if (match-beginning 1)
 			(match-string 1) "0"))
 	    (delim (aref (match-string 2) 0)))
 	(if (or (= delim ?\()
 		(= delim ?\{)
-		(= delim ?\<))
+		(= delim ?\«))
 	    (replace-match (concat "\"("
 				   (cond ((= delim ?\() "mouse")
 					 ((= delim ?\{) "face")
@@ -545,7 +545,6 @@
 	(symbol-value (intern (format "gnus-%s-line-format" type)))
 	(symbol-value (intern (format "gnus-%s-line-format-alist" type)))
 	insertable)))
-
 
 (provide 'gnus-spec)
 


-- 
    /     /   _   _       Didier Verna        http://www.inf.enst.fr/~verna/
 - / / - / / /_/ /        EPITA / LRDE            mailto:didier@epita.fr
/_/ / /_/ / /__ /      14-16 rue Voltaire       Tel.   +33 (1) 44 08 01 77
                   94276 Kremlin-Bicêtre cedex  Fax.   +33 (1) 44 08 01 99

Re: what the heck happened to gnus-spec ?!

[Hrvoje Niksic]

Didier Verna <didier@epita.fr> writes:

> --- gnus-spec.el	Wed Jan 20 01:51:17 1999
> +++ /usr/local/src/pgnus/lisp/gnus-spec.el	Wed Dec  8 10:14:35 1999
> @@ -291,10 +291,10 @@
>    ;; SPEC-ALIST and returns a list that can be eval'ed to return the
>    ;; string.  If the FORMAT string contains the specifiers %( and %)
>    ;; the text between them will have the mouse-face text property.
> -  ;; If the FORMAT string contains the specifiers %< and %>, the text between
> +  ;; If the FORMAT string contains the specifiers %[ and %], the text between
>    ;; them will have the balloon-help text property.
>    (if (string-match
> -       "\\`\\(.*\\)%[0-9]?[{(<]\\(.*\\)%[0-9]?[})>]\\(.*\n?\\)\\'"
> +       "\\`\\(.*\\)%[0-9]?[{(«]\\(.*\\)%[0-9]?[»})]\\(.*\n?\\)\\'"
[...]
> -    (while (re-search-forward "%\\([0-9]+\\)?\\([{}()<>]\\)" nil t)
> +    (while (re-search-forward "%\\([0-9]+\\)?\\([«»{}()]\\)" nil t)
[...]
> -		(= delim ?\<))
> +		(= delim ?\«))

Disgusting!  What is this Latin 1 shit doing there?  I don't think it
will work for people running non-Latin-1 fonts.

Re: what the heck happened to gnus-spec ?!

[Jan Vroonhof]

Didier Verna <didier@epita.fr> writes:

>         The balloon-help property format spec has been broken. Here's a diff
> between the latest working version I have, and the latest CVS version. I
> don't understand these modifications. If they were intentional, they should
> /at least/ have been ChangeLog'ed, and commented in the documentation. But
> those modifications look wrong anyway.
> 
>         Does anybody remember doing this ?

If you have write access to the CVS you can use 'cvs annotate' to find
the guilty party.

Jan

Re: what the heck happened to gnus-spec ?!

[Toby Speight]

dv> Didier Verna <URL:mailto:didier@epita.fr>

0> In article <muxzovluxs3.fsf@uzeb.lrde.epita.fr>, dv wrote:

dv> The balloon-help property format spec has been broken. Here's a
dv> diff between the latest working version I have, and the latest CVS
dv> version. I don't understand these modifications. If they were
dv> intentional, they should /at least/ have been ChangeLog'ed, and
dv> commented in the documentation.  But those modifications look
dv> wrong anyway.

I didn't follow the diff well enough to grok the issue, but I do
remember having a problem with "%>" for (thread-depth) indents being
mis-parsed (because of "%>" being used for balloons).  I'm not the
one who made the change, but I urge anyone mucking about in this area
not to reintroduce the problem.

Re: what the heck happened to gnus-spec ?!

[Didier Verna]

Jan Vroonhof <vroonhof@math.ethz.ch> wrote:

> If you have write access to the CVS you can use 'cvs annotate' to find
> the guilty party.


        Hmmm... Master Yoda himself.

"And when too much beer you brew, only bullshit commits you do" :-)



Annotations for gnus-spec.el
***************
5.6          (larsi    06-Nov-99):   ;; If the FORMAT string contains the specifiers %[ and %], the text between
5.6          (larsi    06-Nov-99):        "\\`\\(.*\\)%[0-9]?[{(«]\\(.*\\)%[0-9]?[»})]\\(.*\n?\\)\\'"
5.6          (larsi    06-Nov-99):     (while (re-search-forward "%\\([0-9]+\\)?\\([«»{}()]\\)" nil t)
5.6          (larsi    06-Nov-99):              (= delim ?\«))


-- 
    /     /   _   _       Didier Verna        http://www.inf.enst.fr/~verna/
 - / / - / / /_/ /        EPITA / LRDE            mailto:didier@epita.fr
/_/ / /_/ / /__ /      14-16 rue Voltaire       Tel.   +33 (1) 44 08 01 77
                   94276 Kremlin-Bicêtre cedex  Fax.   +33 (1) 44 08 01 99

Re: what the heck happened to gnus-spec ?!

[Lars Magne Ingebrigtsen]

Didier Verna <didier@epita.fr> writes:

>         The balloon-help property format spec has been broken. Here's a diff
> between the latest working version I have, and the latest CVS version. I
> don't understand these modifications. If they were intentional, they should
> /at least/ have been ChangeLog'ed, and commented in the documentation. But
> those modifications look wrong anyway.

The balloon-help specs collided with already-used specs, so I moved
them to different characters.  «» aren't good chars -- anybody have an
ASCII thing to replace them with?

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen