gnus-article-remove-cr is broken pgnus v0.80

gnus-article-remove-cr is broken pgnus v0.80

[Paul Stodghill]

[-- Attachment #1: Type: text/plain, Size: 43 bytes --]

It's inserting extra LF's.

before 'W c':


[-- Attachment #2: Before --]
[-- Type: image/jpeg, Size: 81959 bytes --]

[-- Attachment #3: Type: text/plain, Size: 15 bytes --]


after 'W c':


[-- Attachment #4: After --]
[-- Type: image/jpeg, Size: 77721 bytes --]

Re: gnus-article-remove-cr is broken pgnus v0.80

[Lars Magne Ingebrigtsen]

Paul Stodghill <stodghil@CS.Cornell.EDU> writes:

> It's inserting extra LF's.

Hm.  The function is supposed to remove all trailing CRs, and then
translate remaining CRs into LFs.  Can you check what
`article-remove-cr' does in a normal buffer with CRs at the end of the 
lines?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-article-remove-cr is broken pgnus v0.80

[Paul Stodghill]

>>>>> "Lars" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

    Lars> Paul Stodghill <stodghil@CS.Cornell.EDU> writes:
    >> It's inserting extra LF's.

    Lars> Hm. The function is supposed to remove all trailing CRs, and then
    Lars> translate remaining CRs into LFs. Can you check what
    Lars> `article-remove-cr' does in a normal buffer with CRs at the end
    Lars> of the lines?

I saw the same before in a normal buffer that I was seeming in the article
buffer: namely, extra LF's.

I found that making the following change "fixes" the problem.

--- gnus-art.el.org	Sun Apr 18 13:02:27 1999
+++ gnus-art.el	Sun Apr 18 13:02:34 1999
@@ -1287,8 +1287,8 @@
   (save-excursion
     (let ((buffer-read-only nil))
       (goto-char (point-min))
-      (while (search-forward "\r$" nil t)
-	(replace-match "" t t))
+      (while (search-forward "\r\n" nil t)
+	(replace-match "\n" t t))
       (goto-char (point-min))
       (while (search-forward "\r" nil t)
 	(replace-match "\n" t t)))))


In order words: "\r$" was _not_ matching the CR's at the end of the line.
This seems odd....

-- 
Paul Stodghill <stodghil@cs.cornell.edu>
Dept. of Computer Science, Upson Hall, Ithaca, NY  14853
Phone: 607-254-8838   FAX: 607-255-4428
http://www.cs.cornell.edu/stodghil/

Re: gnus-article-remove-cr is broken pgnus v0.80

[Paul Stodghill]

>>>>> "Me" == Paul Stodghill <stodghil@cs.cornell.edu> writes:

    Me> I saw the same before in a normal buffer that I was seeming in the
    Me> article buffer: namely, extra LF's.

    Me> I found that making the following change "fixes" the problem.
    Me> [deleted]

I just downloaded 0.83. It fixes the problem. Thanks.
-- 
Paul Stodghill <stodghil@cs.cornell.edu>
Dept. of Computer Science, Upson Hall, Ithaca, NY  14853
Phone: 607-254-8838   FAX: 607-255-4428
http://www.cs.cornell.edu/stodghil/