small article highlighting bug?

small article highlighting bug?

[John H Palmieri]

Pterodactyl Gnus v0.33
GNU Emacs 20.3.1 (sparc-sun-solaris2.5.1, X toolkit) of Thu Aug 27 1998 on darwin

Hi,

I started emacs with '-q', then ran gnus, then entered a mail group.
I read an article, and hit "W H A" to highlight everything; for
instance, the "From" header is made bold.  If I then hit "t" to show
the headers, then several of those headers are bold, also.

Now for the small bug: if I hit "t" again to hide the headers, then
all the bold-face goes away (including the "From" header), and things
look like they did when I first opened the article.  If I hit "t"
again, all of the headers are visible, and none of them are in
bold-face.

If I have emacs read my .gnus file, which contains the lines

     (add-hook 'gnus-article-display-hook 
	       'gnus-article-highlight t)

then of course I get the same behavior, except I don't have to hit
"W H a" first.

-- 
John H. Palmieri
e-mail: palmieri@member.ams.org        205 Computing/Mathematics Building
URL:http://www.nd.edu/~jpalmier/       University of Notre Dame
(219) 631-8846                         Notre Dame, IN 46556

Re: small article highlighting bug?

[Stephen Zander]

>>>>> "John" == John H Palmieri <jpalmier@ahoward.math.nd.edu> writes:
    John> Now for the small bug: if I hit "t" again to hide the
    John> headers, then all the bold-face goes away (including the
    John> "From" header), and things look like they did when I first
    John> opened the article.  If I hit "t" again, all of the headers
    John> are visible, and none of them are in bold-face.

If it's any consolation, I can reproduce the behaviour you describe
under XEmacs 20.4, gnus 5.6.42.

-- 
Stephen
---
Perl is really designed more for the guys that will hack Perl at least
20 minutes a day for the rest of their career.  TCL/Python is more a
"20 minutes a week", and VB is probably in that "20 minutes a month"
group. :) -- Randal Schwartz

Re: small article highlighting bug?

[Lars Magne Ingebrigtsen]

Stephen Zander <gibreel@pobox.com> writes:

>     John> Now for the small bug: if I hit "t" again to hide the
>     John> headers, then all the bold-face goes away (including the
>     John> "From" header), and things look like they did when I first
>     John> opened the article.  If I hit "t" again, all of the headers
>     John> are visible, and none of them are in bold-face.
> 
> If it's any consolation, I can reproduce the behaviour you describe
> under XEmacs 20.4, gnus 5.6.42.

Me too.  Well, I'll wait to do anything about this until after the
display hook change, which I meant to do last weekend, but didn't.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: small article highlighting bug?

[Lars Magne Ingebrigtsen]

John H Palmieri <jpalmier@ahoward.math.nd.edu> writes:

> Now for the small bug: if I hit "t" again to hide the headers, then
> all the bold-face goes away (including the "From" header), and things
> look like they did when I first opened the article.  If I hit "t"
> again, all of the headers are visible, and none of them are in
> bold-face.

Yes.  This is due to the kinda-sorta running of some of the hooks.
Hopefully this will be sorted out once we move to the boolean
variables instead of the hooks.

And speaking of which -- did we decide on names for these variables?

gnus-article-header-highlight-p
gnus-highlight-element-header

or something else?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: small article highlighting bug?

[Kai Grossjohann]

>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

  > And speaking of which -- did we decide on names for these variables?
  > 
  > gnus-article-header-highlight-p
  > gnus-highlight-element-header

I suggest that all these variables get a common prefix,
e.g. gnus-highlight.  I also suggest that they end in -p, 'cause
that's the old way.  Thus: gnus-highlight-header-p or
gnus-highlight-article-header-p.

kai
-- 
OOP: object oriented programming;  OOPS: object oriented mistakes

Re: small article highlighting bug?

[Lars Magne Ingebrigtsen]

Kai Grossjohann <Kai.Grossjohann@CS.Uni-Dortmund.DE> writes:

> I suggest that all these variables get a common prefix,
> e.g. gnus-highlight.  I also suggest that they end in -p, 'cause
> that's the old way.  Thus: gnus-highlight-header-p or
> gnus-highlight-article-header-p.

Not all of these are highlightings, though -- some are "washes".  I'd
kinda like them all to have the same prefix, I think, so perhaps that
should be

gnus-treatment-article-header-p

But are boolean variables supposed to end in "-p"?  Isn't that really
just predicate functions?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: small article highlighting bug?

[Hrvoje Niksic]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> But are boolean variables supposed to end in "-p"?  Isn't that
> really just predicate functions?

According to the Emacs manual, boolean variables should end in "-flag"
when there is a need to indicate their boolean-ness.

However, having variables end in "-p" appears to be quite common, both 
for temporary variables and customization variables.  There are also
examples of -p boolean variables from ZMACS, ZWEI and others, as
reported by Jamie Zawinski.  Here are the "-p" variables in my current 
XEmacs image:

(apropos-internal "-p\\'" 'boundp)
  => (atomic-extent-goto-char-p auto-save-hash-p
      bottom-toolbar-visible-p browse-url-new-window-p
      buffers-menu-submenus-for-groups-p
      c-echo-syntactic-information-p
      c-enable-xemacs-performance-kludge-p c-hanging-comment-ender-p
      c-hanging-comment-starter-p c-indent-comments-syntactically-p
      c-recognize-knr-p c-strict-syntax-p
      c-style-variables-are-local-p complex-buffers-menu-p
      cperl-xemacs-p default-toolbar-visible-p
      font-menu-this-frame-only-p gnus-article-decoded-p
      gnus-async-prefetch-article-p gnus-frame-split-p
      gnus-topology-checked-p has-modeline-p
      horizontal-scrollbar-visible-p initial-frame-unmapped-p
      ispell-highlight-p ispell-look-p ispell-pdict-modified-p
      ispell-use-framepop-p ispell-use-ptys-p left-toolbar-visible-p
      mail-use-multiple-buffers-p mailcap-parsed-p menubar-visible-p
      mouse-track-rectangle-p ps-print-color-p right-toolbar-visible-p
      scroll-pos-visible-bug-p scrollbar-on-left-p scrollbar-on-top-p
      scrollbars-visible-p sgml-xml-p teach-extended-commands-p
      text-cursor-visible-p toolbar-buttons-captioned-p
      toolbar-captioned-p toolbar-visible-p top-toolbar-visible-p
      vertical-divider-always-visible-p vertical-scrollbar-visible-p
      widget-documentation-link-p zmacs-region-active-p
      zmacs-region-rectangular-p)

And here are the "-flag" ones:

(apropos-internal "-flag\\'" 'boundp)
  => (bq-at-flag bq-comma-flag bq-dot-flag cl-hacked-flag
      file-precious-flag isearch-yank-flag mc-flag
      minibuffer-history-sexp-flag purify-flag quit-flag
      sgml-conref-flag widget-menu-minibuffer-flag)

Personally, "-p" sounds nicer than "-flag", but I don't care all that
much.

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
- When I die, shall I not be like Enkidu?
- Like, no, man, you'll be, like, totally dead.

Re: small article highlighting bug?

[Lars Magne Ingebrigtsen]

Hrvoje Niksic <hniksic@srce.hr> writes:

> And here are the "-flag" ones:

Under Emacs 20.3:

(length (apropos-internal "-flag\\'" 'boundp))
=> 24

(length (apropos-internal "-p\\'" 'boundp))
=> 21

> Personally, "-p" sounds nicer than "-flag", but I don't care all that
> much.

Same here.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: small article highlighting bug?

[Per Abrahamsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> (length (apropos-internal "-p\\'" 'boundp))
> => 21

Some of the `-p' options actually takes a predicate function as their value.

`gnus-async-prefetch-article-p' for example.

Use `-flag' (or nothing) for boolean options.

Re: small article highlighting bug?

[Kai Grossjohann]

Sorry, I agree with you on both the `treatment' prefix and the `-p'
thing -- my mistake.
kai
-- 
OOP: object oriented programming;  OOPS: object oriented mistakes

Re: small article highlighting bug?

[Lars Magne Ingebrigtsen]

Kai Grossjohann <Kai.Grossjohann@CS.Uni-Dortmund.DE> writes:

> Sorry, I agree with you on both the `treatment' prefix and the `-p'
> thing -- my mistake.

I want to implement this thing, like, now, but I don't think we've
really found the format for these variables.

gnus-treatment-article-header-flag

is ambiguous, since it doesn't say what it does, really.

gnus-treatment-highlight-article-header-flag

is kinda long, but descriptive.  Then we'd have

gnus-treatment-hide-article-header-flag
gnus-treatment-add-buttons-article-header-flag
gnus-treatment-hide-boring-article-header-flag

Eh.

gnus-treatment-article-header-highlight-flag
gnus-treatment-article-header-hide-flag
gnus-treatment-article-header-add-buttons-flag
gnus-treatment-article-header-hide-boring-flag

(or -p instead of -flag, but even though I like -p better than -flag,
I think the latter is clearer.)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: small article highlighting bug?

[Per Abrahamsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> gnus-treatment-article-header-highlight-flag
> gnus-treatment-article-header-hide-flag
> gnus-treatment-article-header-add-buttons-flag
> gnus-treatment-article-header-hide-boring-flag

The `article' and `flag' components seems unnecessary. 

gnus-treatment-header-highlight
gnus-treatment-header-hide
gnus-treatment-header-add-buttons
gnus-treatment-header-hide-boring

By dropping `flag' you can also later add other values, such as a
number to control how large articles this treatment will affect.

Re: small article highlighting bug?

[Lars Magne Ingebrigtsen]

Per Abrahamsen <abraham@dina.kvl.dk> writes:

> The `article' and `flag' components seems unnecessary. 
> 
> gnus-treatment-header-highlight
> gnus-treatment-header-hide
> gnus-treatment-header-add-buttons
> gnus-treatment-header-hide-boring

Then the body variables would be

gnus-treatment-add-buttons
gnus-treatment-highlight

or

gnus-treatment-body-add-buttons
gnus-treatment-body-highlight

?

> By dropping `flag' you can also later add other values, such as a
> number to control how large articles this treatment will affect.

Yup.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: small article highlighting bug?

[Per Abrahamsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> gnus-treatment-body-add-buttons
> gnus-treatment-body-highlight

I'd prefer this.

Re: small article highlighting bug?

[Lars Magne Ingebrigtsen]

Per Abrahamsen <abraham@dina.kvl.dk> writes:

> > gnus-treatment-body-add-buttons
> > gnus-treatment-body-highlight
> 
> I'd prefer this.

Ok; I'll go with this one.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen