* [PATCH] Hide Reply-To: when broken-reply-to is set
@ 2003-04-15 23:26 Michael Shields
2003-04-16 21:56 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Michael Shields @ 2003-04-15 23:26 UTC (permalink / raw)
This functionality was discussed in <m34r5jqxpx.fsf@quimbies.gnus.org>.
However, it was submitted by Vasily Korytov, who has no papers on file.
Since it was easy, I just wrote my own patch.
I've also noted in the manual that setting `broken-reply-to' is a good
alternative to habitually using `B r'.
lisp/ChangeLog addition:
2003-04-15 Michael Shields <shields@msrl.com>
* gnus-art.el (article-hide-boring-headers): Hide Reply-To: if
the broken-reply-to group parameter is set. Idea from Vasily
Korytov <deskpot@myrealbox.com>.
texi/ChangeLog addition:
2003-04-15 Michael Shields <shields@msrl.com>
* gnus.texi (Group Parameters, Hiding Headers): Document that
the broken-reply-to group parameter now also affects header
hiding.
* gnus.texi (Summary Mail Commands): Suggest setting the
broken-reply-to parameter if you find yourself using `B r'.
gnus source patch:
Diff command: cvs -q diff -u
Files affected: lisp/gnus-art.el texi/gnus.texi
Index: texi/gnus.texi
===================================================================
RCS file: /usr/local/cvsroot/gnus/texi/gnus.texi,v
retrieving revision 6.472
diff -u -r6.472 gnus.texi
--- texi/gnus.texi 15 Apr 2003 22:16:22 -0000 6.472
+++ texi/gnus.texi 15 Apr 2003 23:19:56 -0000
@@ -2745,10 +2745,11 @@
@item broken-reply-to
@cindex broken-reply-to
Elements like @code{(broken-reply-to . t)} signals that @code{Reply-To}
-headers in this group are to be ignored. This can be useful if you're
-reading a mailing list group where the listserv has inserted
-@code{Reply-To} headers that point back to the listserv itself. This is
-broken behavior. So there!
+headers in this group are to be ignored, and for the header to be hidden
+if @code{reply-to} is part of @code{gnus-boring-article-headers}. This
+can be useful if you're reading a mailing list group where the listserv
+has inserted @code{Reply-To} headers that point back to the listserv
+itself. That is broken behavior. So there!
@item to-group
@cindex to-group
@@ -5214,6 +5215,10 @@
@findex gnus-summary-reply-broken-reply-to
Mail a reply to the author of the current article but ignore the
@code{Reply-To} field (@code{gnus-summary-reply-broken-reply-to}).
+If you need this because a mailing list incorrectly sets a
+@code{Reply-To} header pointing to the list, you probably want to set
+the @code{broken-reply-to} group parameter instead, so things will work
+correctly. @xref{Group Parameters}.
@item S B R
@kindex S B R (Summary)
@@ -10685,7 +10690,8 @@
@code{Newsgroups} header.
@item reply-to
Remove the @code{Reply-To} header if it lists the same address as the
-@code{From} header.
+@code{From} header, or if the @code{broken-reply-to} group parameter is
+set.
@item newsgroups
Remove the @code{Newsgroups} header if it only contains the current group
name.
Index: lisp/gnus-art.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-art.el,v
retrieving revision 6.332
diff -u -r6.332 gnus-art.el
--- lisp/gnus-art.el 15 Apr 2003 22:15:42 -0000 6.332
+++ lisp/gnus-art.el 15 Apr 2003 23:20:02 -0000
@@ -1667,15 +1667,18 @@
(message-fetch-field "newsgroups"))
(gnus-article-hide-header "followup-to")))
((eq elem 'reply-to)
- (let ((from (message-fetch-field "from"))
- (reply-to (message-fetch-field "reply-to")))
- (when (and
- from reply-to
- (ignore-errors
- (gnus-string-equal
- (nth 1 (mail-extract-address-components from))
- (nth 1 (mail-extract-address-components reply-to)))))
- (gnus-article-hide-header "reply-to"))))
+ (if (gnus-group-find-parameter
+ gnus-newsgroup-name 'broken-reply-to)
+ (gnus-article-hide-header "reply-to")
+ (let ((from (message-fetch-field "from"))
+ (reply-to (message-fetch-field "reply-to")))
+ (when (and
+ from reply-to
+ (ignore-errors
+ (gnus-string-equal
+ (nth 1 (mail-extract-address-components from))
+ (nth 1 (mail-extract-address-components reply-to)))))
+ (gnus-article-hide-header "reply-to")))))
((eq elem 'date)
(let ((date (message-fetch-field "date")))
(when (and date
--
Shields.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Hide Reply-To: when broken-reply-to is set
2003-04-15 23:26 [PATCH] Hide Reply-To: when broken-reply-to is set Michael Shields
@ 2003-04-16 21:56 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Magne Ingebrigtsen @ 2003-04-16 21:56 UTC (permalink / raw)
Michael Shields <shields@msrl.com> writes:
> This functionality was discussed in <m34r5jqxpx.fsf@quimbies.gnus.org>.
> However, it was submitted by Vasily Korytov, who has no papers on file.
> Since it was easy, I just wrote my own patch.
>
> I've also noted in the manual that setting `broken-reply-to' is a good
> alternative to habitually using `B r'.
Thanks for the patch; I've applied it to Oort Gnus v0.19 (i. e., CVS).
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-04-16 21:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-15 23:26 [PATCH] Hide Reply-To: when broken-reply-to is set Michael Shields
2003-04-16 21:56 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).