* [PATCH] mode Ebola fixes
@ 1998-11-26 12:56 Didier Verna
1998-11-26 14:30 ` Jan Vroonhof
1998-11-26 17:08 ` Hrvoje Niksic
0 siblings, 2 replies; 6+ messages in thread
From: Didier Verna @ 1998-11-26 12:56 UTC (permalink / raw)
1998-11-26 Didier Verna <verna@inf.enst.fr>
* mailcap.el (mailcap-parse-mailcap-extras): fixed more char-int
comparisons
--- mailcap.el.orig Thu Nov 26 13:44:55 1998
+++ mailcap.el Thu Nov 26 13:45:47 1998
@@ -412,7 +412,7 @@
(downcase-region name-pos (point))
(setq name (buffer-substring name-pos (point)))
(skip-chars-forward " \t\n")
- (if (not (eq (or (char-after (point)) 0) ?=)) ; There is no value
+ (if (not (eq (or (char-after (point)) ?0) ?=)) ; There is no value
(setq value nil)
(skip-chars-forward " \t\n=")
(setq val-pos (point))
@@ -426,7 +426,7 @@
(error (goto-char (point-max)))))
(while (not done)
(skip-chars-forward "^;")
- (if (eq (or (char-after (1- (point))) 0) ?\\ )
+ (if (eq (or (char-after (1- (point))) ?0) ?\\ )
(progn
(subst-char-in-region (1- (point)) (point) ?\\ ? )
(skip-chars-forward ";"))
--
/ / _ _ Didier Verna http://www.inf.enst.fr/~verna/
- / / - / / /_/ / E.N.S.T. INF C201.1 mailto:verna@inf.enst.fr
/_/ / /_/ / /__ / 46 rue Barrault Tel. (33) 01 45 81 73 46
75634 Paris cedex 13 Fax. (33) 01 45 81 31 19
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mode Ebola fixes
1998-11-26 12:56 [PATCH] mode Ebola fixes Didier Verna
@ 1998-11-26 14:30 ` Jan Vroonhof
1998-11-26 17:08 ` Hrvoje Niksic
1 sibling, 0 replies; 6+ messages in thread
From: Jan Vroonhof @ 1998-11-26 14:30 UTC (permalink / raw)
Didier Verna <verna@inf.enst.fr> writes:
> (skip-chars-forward " \t\n")
> - (if (not (eq (or (char-after (point)) 0) ?=)) ; There is no value
> + (if (not (eq (or (char-after (point)) ?0) ?=)) ; There is no value
Isn't it much simpler to just write (eq (char-after (point)) ?=) ?
The above code seems to come from some overzealous attempt to emulator
following-char behaviour (thus reintroding ebola).
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mode Ebola fixes
1998-11-26 12:56 [PATCH] mode Ebola fixes Didier Verna
1998-11-26 14:30 ` Jan Vroonhof
@ 1998-11-26 17:08 ` Hrvoje Niksic
1998-11-26 17:38 ` Didier Verna
1 sibling, 1 reply; 6+ messages in thread
From: Hrvoje Niksic @ 1998-11-26 17:08 UTC (permalink / raw)
Didier Verna <verna@inf.enst.fr> writes:
> - (if (not (eq (or (char-after (point)) 0) ?=)) ; There is no value
> + (if (not (eq (or (char-after (point)) ?0) ?=)) ; There is no value
This patch is definitely wrong -- `char-after' returns 0, not ?0 at
eob.
--
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Lost in Static 18 / And the storm is closing in now
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mode Ebola fixes
1998-11-26 17:08 ` Hrvoje Niksic
@ 1998-11-26 17:38 ` Didier Verna
1998-11-26 17:43 ` Hrvoje Niksic
0 siblings, 1 reply; 6+ messages in thread
From: Didier Verna @ 1998-11-26 17:38 UTC (permalink / raw)
Hrvoje Niksic writes:
Hrvoje> Didier Verna <verna@inf.enst.fr> writes:
>> - (if (not (eq (or (char-after (point)) 0) ?=)) ; There is no value + (if
>> (not (eq (or (char-after (point)) ?0) ?=)) ; There is no value
Hrvoje> This patch is definitely wrong -- `char-after' returns 0, not ?0 at
Hrvoje> eob.
Sorry? char-after returns neither 0 nor ?0 at eob. It returns nil. The
point is to compare two chars to avoid Ebola warnings. I don't understand you,
here.
--
/ / _ _ Didier Verna http://www.inf.enst.fr/~verna/
- / / - / / /_/ / E.N.S.T. INF C201.1 mailto:verna@inf.enst.fr
/_/ / /_/ / /__ / 46 rue Barrault Tel. (33) 01 45 81 73 46
75634 Paris cedex 13 Fax. (33) 01 45 81 31 19
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mode Ebola fixes
1998-11-26 17:38 ` Didier Verna
@ 1998-11-26 17:43 ` Hrvoje Niksic
1998-11-27 10:48 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Hrvoje Niksic @ 1998-11-26 17:43 UTC (permalink / raw)
Didier Verna <verna@inf.enst.fr> writes:
> Hrvoje Niksic writes:
>
> Hrvoje> Didier Verna <verna@inf.enst.fr> writes:
> >> - (if (not (eq (or (char-after (point)) 0) ?=)) ; There is no value + (if
> >> (not (eq (or (char-after (point)) ?0) ?=)) ; There is no value
>
> Hrvoje> This patch is definitely wrong -- `char-after' returns 0, not ?0 at
> Hrvoje> eob.
>
> Sorry? char-after returns neither 0 nor ?0 at eob. It returns nil.
You're right. I confused `char-after' with `following-char'. :-(
I think `(if (not (eq (char-after (point)) ?=))' would be somewhat
nicer, though.
--
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
4. Thou shalt not warlorde a sig if it bee the sig of Kibo, nor if
it bee the sig of the Inner Circle.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mode Ebola fixes
1998-11-26 17:43 ` Hrvoje Niksic
@ 1998-11-27 10:48 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Magne Ingebrigtsen @ 1998-11-27 10:48 UTC (permalink / raw)
Hrvoje Niksic <hniksic@srce.hr> writes:
> I think `(if (not (eq (char-after (point)) ?=))' would be somewhat
> nicer, though.
Yup. Fix in Pterodactyl Gnus v0.55.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~1998-11-27 10:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-11-26 12:56 [PATCH] mode Ebola fixes Didier Verna
1998-11-26 14:30 ` Jan Vroonhof
1998-11-26 17:08 ` Hrvoje Niksic
1998-11-26 17:38 ` Didier Verna
1998-11-26 17:43 ` Hrvoje Niksic
1998-11-27 10:48 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).