[patch] inconsistency between `mm-display-external' and `mm-remove-part'.

[patch] inconsistency between `mm-display-external' and `mm-remove-part'.

[Rui Zhu]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

Hi, there,

The error get signaled when I add "text/html" to
`mm-inline-override-types' (my mailcap says to use lynx and
`needsterminal'), because `mm-remove-part' kills the article buffer
unintentionally:

(kill-buffer (cdr object)), while object contains no buffer but only
tmpfile name, so it kills current buffer (article buffer).  I'm not
very sure the patch is the real cure due to lack of knowledge of whole
package, though it works.  Maybe `kill-buffer' in `mm-remove-part'
should be guarded?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: mm-decode.el.diff --]
[-- Type: text/x-patch, Size: 400 bytes --]

--- mm-decode.el.orig	Sun Jul  9 21:31:26 2000
+++ mm-decode.el	Mon Jul 31 03:41:34 2000
@@ -403,7 +403,9 @@
 	  (message "Viewing with %s" method)
 	  (cond (needsterm
 		 (unwind-protect
-		     (start-process "*display*" nil
+		     (start-process "*display*"
+				    (setq buffer
+					  (generate-new-buffer "*mm*"))
 				    "xterm"
 				    "-e" shell-file-name
 				    shell-command-switch

[-- Attachment #3: Type: text/plain, Size: 45 bytes --]


BTW, there is a typo in `emacs-mime.texi'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: emacs-mime.texi.diff --]
[-- Type: text/x-patch, Size: 478 bytes --]

--- emacs-mime.texi.orig	Sat Apr 29 13:00:02 2000
+++ emacs-mime.texi	Mon Jul 31 04:14:01 2000
@@ -899,7 +899,7 @@
 makes the library display all inline images as inline, regardless of
 their size.
 
-@item mm-inline-override-p
+@item mm-inline-override-types
 @code{mm-inlined-types} may include regular expressions, for example to
 specify that all @samp{text/.*} parts be displayed inline.  If a user
 prefers to have a type that matches such a regular expression be treated

[-- Attachment #5: Type: text/plain, Size: 66 bytes --]


The patches is against CVS.

Regards,

#\Rui

-- 
Happy Gnusing!

Re: [patch] inconsistency between `mm-display-external' and `mm-remove-part'.

[Lars Magne Ingebrigtsen]

Rui Zhu <sprache@iname.com> writes:

> BTW, there is a typo in `emacs-mime.texi'.

Thanks for the patch; I've applied it to Oort Gnus v0.04 (i. e., CVS).

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen