Bug in `gnus-summary-refer-thread'

Bug in `gnus-summary-refer-thread'

[Karl Pflästerer]

Hi,
if I use `A T' (gnus-summary-refer-thread) to fetch the whole thread I
get this error:

,----
| Signaling: (wrong-type-argument number-char-or-marker-p t)
|   +(14666 t)
|   (min (+ (mail-header-number ...) limit) gnus-newsgroup-end)
|   (list (min (+ ... limit) gnus-newsgroup-end))
|   (gnus-retrieve-headers (list (min ... gnus-newsgroup-end)) gnus-newsgroup-name (* limit 2))
|   (eq (gnus-retrieve-headers (list ...) gnus-newsgroup-name (* limit 2)) (quote nov))
|   (if (eq (gnus-retrieve-headers ... gnus-newsgroup-name ...) (quote nov)) (gnus-build-all-threads) (error "Can't fetch thread from backends that don't support NOV"))
|   (if (eq gnus-fetch-old-headers (quote invisible)) nil (gnus-message 5 "Fetching headers for %s..." gnus-newsgroup-name) (if (eq ... ...) (gnus-build-all-threads) (error "Can't fetch thread from backends that don't support NOV")) (gnus-message 5 "Fetching headers for %s...done" gnus-newsgroup-name))
|   (unless (eq gnus-fetch-old-headers (quote invisible)) (gnus-message 5 "Fetching headers for %s..." gnus-newsgroup-name) (if (eq ... ...) (gnus-build-all-threads) (error "Can't fetch thread from backends that don't support NOV")) (gnus-message 5 "Fetching headers for %s...done" gnus-newsgroup-name))
|   (let ((id ...) (limit ...)) (unless (eq gnus-fetch-old-headers ...) (gnus-message 5 "Fetching headers for %s..." gnus-newsgroup-name) (if ... ... ...) (gnus-message 5 "Fetching headers for %s...done" gnus-newsgroup-name)) (gnus-summary-limit-include-thread id))
| * gnus-summary-refer-thread(nil)
|   call-interactively(gnus-summary-refer-thread)
`----

I think that is because of the definition of the variable
`gnus-refer-thread-limit'

,----[ C-h v gnus-refer-thread-limit RET ]
| `gnus-refer-thread-limit' is a variable declared in Lisp.
|   -- loaded from "/d/ognus/lib/xemacs/site-packages/lisp/gnus/gnus-sum.el"
| 
| Value: t
| 
| Documentation:
| *The number of old headers to fetch when doing A T.
| If t, fetch all the available old headers.
`----

And here in the function, `limit' is set to `t' if there is no prefix.

,----
| (defun gnus-summary-refer-thread (&optional limit)
|   "Fetch all articles in the current thread.
| If LIMIT (the numerical prefix), fetch that many old headers instead
| of what's specified by the `gnus-refer-thread-limit' variable."
|   (interactive "P")
|   (let ((id (mail-header-id (gnus-summary-article-header)))
| 	(limit (if limit (prefix-numeric-value limit)
| 		 gnus-refer-thread-limit)))
                 ^^^^^^^^^^^^^^^^^^^^^^^
|     (unless (eq gnus-fetch-old-headers 'invisible)
|       (gnus-message 5 "Fetching headers for %s..." gnus-newsgroup-name)
|       ;; Retrieve the headers and read them in.
|       (if (eq (gnus-retrieve-headers
| 	       (list (min
| 		      (+ (mail-header-number
| 			  (gnus-summary-article-header))
| 			 limit)
                         ^^^^^^
Here the wrong addition.
| 		      gnus-newsgroup-end))
| 	       gnus-newsgroup-name (* limit 2))
| 	      'nov)
| 	  (gnus-build-all-threads)
| 	(error "Can't fetch thread from backends that don't support NOV"))
|       (gnus-message 5 "Fetching headers for %s...done" gnus-newsgroup-name))
|     (gnus-summary-limit-include-thread id)))
`----

bye
   KP

-- 
'Twas brillig, and the slithy toves
    Did gyre and gimble in the wabe;
  All mimsy were the borogoves,
   And the mome raths outgrabe.   "Lewis Carroll" "Jabberwocky"

Re: Bug in `gnus-summary-refer-thread'

[Jesper Harder]

sigurd@12move.de (Karl Pflästerer) writes:

> if I use `A T' (gnus-summary-refer-thread) to fetch the whole thread I
> get this error:
>
> | Signaling: (wrong-type-argument number-char-or-marker-p t)
>
> I think that is because of the definition of the variable
> `gnus-refer-thread-limit'

Yep.  It's fixed in CVS.