Gnus development mailing list
 help / color / mirror / Atom feed
* [PATCH] Correctly handle an article that exactly fills the window
@ 2003-01-07  8:21 Michael Shields
  2003-01-08  3:54 ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Shields @ 2003-01-07  8:21 UTC (permalink / raw)


Currently, Gnus will page forward if the last line of the article
falls on the last line of the article window.  This seems to be a bug.

2003-01-07  Michael Shields  <shields@msrl.com>

	* gnus-art.el (gnus-article-next-page): Correctly handle the case
	where the last line of the article is the last line of the window.

--- lisp/gnus-art.el	2003/01/04 00:43:57	6.266
+++ lisp/gnus-art.el	2003/01/07 08:22:45
@@ -4730,7 +4755,7 @@
   (if (save-excursion
 	(end-of-line)
 	(and (pos-visible-in-window-p)	;Not continuation line.
-	     (eobp)))
+	     (>= (1+ (point)) (point-max)))) ;Allow for trailing newline.
       ;; Nothing in this page.
       (if (or (not gnus-page-broken)
 	      (save-excursion

-- 
Shields.




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Correctly handle an article that exactly fills the window
  2003-01-07  8:21 [PATCH] Correctly handle an article that exactly fills the window Michael Shields
@ 2003-01-08  3:54 ` Lars Magne Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Magne Ingebrigtsen @ 2003-01-08  3:54 UTC (permalink / raw)


Michael Shields <shields@msrl.com> writes:

> 	* gnus-art.el (gnus-article-next-page): Correctly handle the case
> 	where the last line of the article is the last line of the window.

Thanks for the patch; I've applied it to Oort Gnus v0.11 (i. e., CVS).

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-01-08  3:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-01-07  8:21 [PATCH] Correctly handle an article that exactly fills the window Michael Shields
2003-01-08  3:54 ` Lars Magne Ingebrigtsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).