too-ugly faces

too-ugly faces

[David Aspinwall]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

For x-faces, there was gnus-article-x-face-too-ugly, but that doesn't
work for the face header.  The following patch adds a
gnus-article-face-too-ugly.  Maybe there should only be one variable
which is used for both headers though.  Also, my lisp skills are
pretty minimal, so I may not have done this the best way.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch to gnus-art.el --]
[-- Type: text/x-patch, Size: 1319 bytes --]

--- gnus-art.el.orig	2003-01-15 10:48:03.000000000 -0800
+++ gnus-art.el	2003-01-24 13:48:38.000000000 -0800
@@ -250,6 +250,11 @@
   :group 'gnus-article-washing)
 
 (defcustom gnus-article-x-face-too-ugly nil
+  "Regexp matching posters whose x-face shouldn't be shown automatically."
+  :type '(choice regexp (const nil))
+  :group 'gnus-article-washing)
+
+(defcustom gnus-article-face-too-ugly nil
   "Regexp matching posters whose face shouldn't be shown automatically."
   :type '(choice regexp (const nil))
   :group 'gnus-article-washing)
@@ -1935,12 +1940,19 @@
   "Display any Face headers in the header."
   (interactive)
   (gnus-with-article-headers
-    (let ((face nil))
+    (let ((face nil)
+          (from nil))
       (save-excursion
 	(when (gnus-buffer-live-p gnus-original-article-buffer)
 	  (set-buffer gnus-original-article-buffer)
+	  (setq from (message-fetch-field "from"))
 	  (setq face (message-fetch-field "face"))))
-      (when face
+      (when (and face
+                 (or
+                  (not gnus-article-face-too-ugly)
+                  (and gnus-article-face-too-ugly from
+                       (not (string-match gnus-article-face-too-ugly
+                                          from)))))
 	(let ((png (gnus-convert-face-to-png face))
 	      image)
 	  (when png

Re: too-ugly faces

[Lars Magne Ingebrigtsen]

David Aspinwall <aspinwall@timesten.com> writes:

> For x-faces, there was gnus-article-x-face-too-ugly, but that doesn't
> work for the face header.  The following patch adds a
> gnus-article-face-too-ugly. 

I think it might make more sense to use the former variable for both
X-Face and Face.  Probably.

And should X-Face display be inhibited if there is a Face?

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen