nnimap-fetch-partial-articles does not seem to work with forwarded articles

nnimap-fetch-partial-articles does not seem to work with forwarded articles

[Robert Pluim]

Hi,

I forwarded an email to someone, cc myself. When I then read that copy,
gnus gave me an error, which went away when I set
nnimap-fetch-partial-articles to nil (it was set to
"text/\\(plain\\|calendar\\)" before).

This is with git gnus as of commit
69bd07e8b7714edc2990acd664fffe26541dc2cc

Debug backtrace is:

Debugger entered--Lisp error: (wrong-type-argument number-char-or-marker-p nil)
  nnimap-convert-partial-article((("text" "plain" ("charset" "us-ascii") nil nil "quoted-printable" 0 0 nil "1" nil nil) ("message" "rfc822" nil nil nil "7bit" 1638 ("tue, 21 dec 2010 09:10:16 -0500" "re: nmc + e-cscf" ... nil nil ... nil nil "<pknei9bi7f6.fsf@this.is.really.invalid>" "<8ccdd3219a5a4d43a6d3b43d9764774b960a4ae0@mailbox1.company.com>") ("text" "plain" ... nil nil "quoted-printable" 658 25 nil nil "en-us" nil) "2" nil nil nil nil) "mixed" ("boundary" "_002_pkn39pri4stfsfthisisreallyinvalid_") nil "en-us"))
  nnimap-get-partial-article(49140 ("1") (("text" "plain" ("charset" "us-ascii") nil nil "quoted-printable" 0 0 nil "1" nil nil) ("message" "rfc822" nil nil nil "7bit" 1638 ("tue, 21 dec 2010 09:10:16 -0500" "re: nmc + e-cscf" ... nil nil ... nil nil "<pknei9bi7f6.fsf@this.is.really.invalid>" "<8ccdd3219a5a4d43a6d3b43d9764774b960a4ae0@mailbox1.company.com>") ("text" "plain" ... nil nil "quoted-printable" 658 25 nil nil "en-us" nil) "2" nil nil nil nil) "mixed" ("boundary" "_002_pkn39pri4stfsfthisisreallyinvalid_") nil "en-us"))
  nnimap-request-article(49140 "INBOX" "mymail" #<buffer "*Article nnimap+mymail:INBOX*">)
  gnus-request-article(49140 "nnimap+mymail:INBOX" #<buffer "*Article nnimap+mymail:INBOX*">)
  gnus-request-article-this-buffer(49140 "nnimap+mymail:INBOX")
  gnus-article-prepare(49140 nil)
  gnus-summary-display-article(49140 nil)
  gnus-summary-select-article(nil nil nil 49140)
  gnus-summary-save-article(nil)
  call-interactively(gnus-summary-save-article)
  (dispatch-event "[internal]")

Re: nnimap-fetch-partial-articles does not seem to work with forwarded articles

[Lars Magne Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> Debugger entered--Lisp error: (wrong-type-argument number-char-or-marker-p nil)
>   nnimap-convert-partial-article((("text" "plain" ("charset" "us-ascii") nil nil "quoted-printable" 0 0 nil "1" nil nil) ("message" "rfc822" nil nil nil "7bit" 1638 ("tue, 21 dec 2010 09:10:16 -0500" "re: nmc + e-cscf" ... nil nil ... nil nil "<pknei9bi7f6.fsf@this.is.really.invalid>" "<8ccdd3219a5a4d43a6d3b43d9764774b960a4ae0@mailbox1.company.com>") ("text" "plain" ... nil nil "quoted-printable" 658 25 nil nil "en-us" nil) "2" nil nil nil nil) "mixed" ("boundary" "_002_pkn39pri4stfsfthisisreallyinvalid_") nil "en-us"))

Your backtrace data has been truncated, so I can't really reproduce this
bug.  I think setting print-length and print-level to nil should
probably fix this, but I'm not sure how your version of XEmacs does this
exactly. 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: nnimap-fetch-partial-articles does not seem to work with forwarded articles

[Robert Pluim]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Robert Pluim <rpluim@gmail.com> writes:
>
>> Debugger entered--Lisp error: (wrong-type-argument
>> number-char-or-marker-p nil)
>>   nnimap-convert-partial-article((("text" "plain" ("charset"
>> "us-ascii") nil nil "quoted-printable" 0 0 nil "1" nil nil)
>> ("message" "rfc822" nil nil nil "7bit" 1638 ("tue, 21 dec 2010
>> 09:10:16 -0500" "re: nmc + e-cscf" ... nil nil ... nil nil
>> "<pknei9bi7f6.fsf@this.is.really.invalid>"
>> "<8ccdd3219a5a4d43a6d3b43d9764774b960a4ae0@mailbox1.company.com>")
>> ("text" "plain" ... nil nil "quoted-printable" 658 25 nil nil
>> "en-us" nil) "2" nil nil nil nil) "mixed" ("boundary"
>> "_002_pkn39pri4stfsfthisisreallyinvalid_") nil "en-us"))
>
> Your backtrace data has been truncated, so I can't really reproduce this
> bug.  I think setting print-length and print-level to nil should
> probably fix this, but I'm not sure how your version of XEmacs does this
> exactly. 

Hmm, they're both set to nil, so something has gone wrong. Anyway, I
edebug'd nnimap-convert-partial-article, and it's failing because 

    (while (looking-at ".*BODY\\[\\([.0-9]+\\)\\]")
      (setq id (match-string 1)
	    bytes (nnimap-get-length))  <== this is returning NIL.

If I've understood the code, this should be parsing the BODY response,
which is 

 BODY[1] NIL UID 49140)

at this point.  I'm not terribly familiar with IMAP, but I guess you're
expecting something a little more descriptive of the body than 'NIL' ;)
Trying to understand the relevant section of the RFC has given me a
headache, so I'll leave it to you to decide if this is a bug in Gnus or
in the Exchange server I'm talking to :)

Regards

Robert

Re: nnimap-fetch-partial-articles does not seem to work with forwarded articles

[Lars Magne Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

>     (while (looking-at ".*BODY\\[\\([.0-9]+\\)\\]")
>       (setq id (match-string 1)
> 	    bytes (nnimap-get-length))  <== this is returning NIL.
>
> If I've understood the code, this should be parsing the BODY response,
> which is 
>
>  BODY[1] NIL UID 49140)
>
> at this point.

The length thing is a {foo} at the end of the line.

Could you send the complete contents of the IMAP buffer when this
happens?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: nnimap-fetch-partial-articles does not seem to work with forwarded articles

[Robert Pluim]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Robert Pluim <rpluim@gmail.com> writes:
>
>>     (while (looking-at ".*BODY\\[\\([.0-9]+\\)\\]")
>>       (setq id (match-string 1)
>> 	    bytes (nnimap-get-length))  <== this is returning NIL.
>>
>> If I've understood the code, this should be parsing the BODY response,
>> which is 
>>
>>  BODY[1] NIL UID 49140)
>>
>> at this point.
>
> The length thing is a {foo} at the end of the line.
>
> Could you send the complete contents of the IMAP buffer when this
> happens?
>

Here's the nnimap buffer I get when attempting to read your reply
forwarded to myself (how's that for circularity :) )

* 556 FETCH (BODY[HEADER] {1063}
MIME-Version: 1.0
Received: from RPluim.mycompany.com (192.168.15.1) by mail.mycompany.com
 (192.168.1.2) with Microsoft SMTP Server (TLS) id 8.2.254.0; Tue, 4 Jan 2011
 03:42:31 -0500
From: Robert Pluim <rpluim@mycompany.com>
To: Robert Pluim <rpluim@mycompany.com>
Date: Tue, 4 Jan 2011 03:42:10 -0500
Subject: [gmane.emacs.gnus.general] Re: nnimap-fetch-partial-articles does
 not seem to work with forwarded articles
Thread-Topic: [gmane.emacs.gnus.general] Re: nnimap-fetch-partial-articles
 does not seem to work with forwarded articles
Thread-Index: Acur61OjR7l3bzSaRjyLTsv29CTRUw==
Message-ID: <pknipy5m55p.fsf@this.is.really.invalid>
Accept-Language: en-US
Content-Language: en-US
X-MS-Exchange-Organization-AuthAs: Internal
X-MS-Exchange-Organization-AuthMechanism: 06
X-MS-Exchange-Organization-AuthSource: mail.mycompany.com
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Gnus/5.110011 (No Gnus v0.11) XEmacs/21.5-b29 (cygwin32)
Content-Type: multipart/mixed;
	boundary="_002_pknipy5m55pfsfthisisreallyinvalid_"

 BODY[1] NIL UID 49311)
127 OK FETCH completed.


Imap log contains:

09:51:32 126 UID FETCH 49311 (BODYSTRUCTURE)
09:51:40 127 UID FETCH 49311 (BODY.PEEK[HEADER] BODY.PEEK[1])

Regards

Robert

Re: nnimap-fetch-partial-articles does not seem to work with forwarded articles

[Lars Magne Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

>  BODY[1] NIL UID 49311)

Ok, I think I may have fixed this.  I suspect it's a zero-length body
part of some sort?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: nnimap-fetch-partial-articles does not seem to work with forwarded articles

[Robert Pluim]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Robert Pluim <rpluim@gmail.com> writes:
>
>>  BODY[1] NIL UID 49311)
>
> Ok, I think I may have fixed this.  I suspect it's a zero-length body
> part of some sort?
>

Well, the part it's complaining about looks like this:

Content-Type: multipart/mixed;
	boundary="_002_pknipy5m55pfsfthisisreallyinvalid_"
MIME-Version: 1.0

--_002_pknipy5m55pfsfthisisreallyinvalid_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


--_002_pknipy5m55pfsfthisisreallyinvalid_


To my mind, 2 empty lines is not 'zero length', but the mime standards
might well disagree. :)

It's fixed now, in any case, although there's nothing to indicate that
there's a message/rfc822 attachment in the article that could be
downloaded.  Are there some variables I can set to get buttons or
something for that part in this case?

Thanks

Robert

Re: nnimap-fetch-partial-articles does not seem to work with forwarded articles

[Lars Ingebrigtsen]

> To my mind, 2 empty lines is not 'zero length', but the mime standards
> might well disagree. :)

Most likely, the IMAP server disagrees.  :-)

> It's fixed now, in any case, although there's nothing to indicate that
> there's a message/rfc822 attachment in the article that could be
> downloaded.  Are there some variables I can set to get buttons or
> something for that part in this case?

Does `K b' display the buttons?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: nnimap-fetch-partial-articles does not seem to work with forwarded articles

[Robert Pluim]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> To my mind, 2 empty lines is not 'zero length', but the mime standards
>> might well disagree. :)
>
> Most likely, the IMAP server disagrees.  :-)
>
>> It's fixed now, in any case, although there's nothing to indicate that
>> there's a message/rfc822 attachment in the article that could be
>> downloaded.  Are there some variables I can set to get buttons or
>> something for that part in this case?
>
> Does `K b' display the buttons?

Yes. I've now done (setq gnus-inhibit-mime-unbuttonizing t)

Thanks

Robert