Re: Customize group parameters problems

Re: Customize group parameters problems

[Shenghuo ZHU]

>>>>> "Paul" == Paul D Smith <pausmith@nortelnetworks.com> writes:

Paul> %% Shenghuo ZHU <zsh@cs.rochester.edu> writes:
>>>>>>> "Paul" == Paul D Smith <pausmith@nortelnetworks.com> writes:

Paul> I can select the toggle items to actually turn on/off things
Paul> (the ones on the left of the screen), and the "[done]" button
Paul> works, but if I try to use _ANY_ other buttons in the buffer,
Paul> such as the "[More]" buttons to see more information, or the
Paul> "[Value Menu]" buttons to see different values, even the text
Paul> string areas to enter regular expressions, etc. I get this
Paul> error:

zsh> You have to active the item first, that is, turn on the thing
zsh> (the one on the left of the screen).

Paul> Hmm.  OK, I guess I can see that for the value fields (although
Paul> it'd be nice to be able to view the value choices without
Paul> enabling the feature), but the "[More]" buttons should
Paul> definitely work whether the item is enabled or not... how do I
Paul> know if I want it if I can't read the description? :)

Paul> I don't think turning it on to get the description, then turning
Paul> it off again is the Right Thing To Do.

Paul> Note that normal Customize buffers let you toggle [More] without
Paul> selecting the item first, so this behavior is also surprising.

I agree. But I am not familiar with those widgets.  Does anyone know
how to fix it?

-- 
Shenghuo

Re: Customize group parameters problems

[Per Abrahamsen]

Shenghuo ZHU <zsh@cs.rochester.edu> writes:

> I agree. But I am not familiar with those widgets.  Does anyone know
> how to fix it?

It is a `wid-edit.el' bug/limitation.  Here is a fix.  I have send it
to the Emacs maintainers, I believe Hjrove has already fixed it for
XEmacs.

2000-05-01  Per Abrahamsen  <abraham@dina.kvl.dk>

	* wid-edit.el (widget-default-active): Obey `:always-active'.
	(widget-documentation-string-value-create): Set `:always-active'.

Index: wid-edit.el
===================================================================
RCS file: /gd/gnu/cvsroot/emacs/lisp/wid-edit.el,v
retrieving revision 1.64
diff -c -r1.64 wid-edit.el
*** wid-edit.el	2000/02/16 13:25:52	1.64
--- wid-edit.el	2000/05/01 13:13:50
***************
*** 1539,1548 ****
  
  (defun widget-default-active (widget)
    "Return t iff this widget active (user modifiable)."
!   (and (not (widget-get widget :inactive))
!        (let ((parent (widget-get widget :parent)))
! 	 (or (null parent) 
! 	     (widget-apply parent :active)))))
  
  (defun widget-default-deactivate (widget)
    "Make WIDGET inactive for user modifications."
--- 1539,1549 ----
  
  (defun widget-default-active (widget)
    "Return t iff this widget active (user modifiable)."
!   (or (widget-get widget :always-active)
!       (and (not (widget-get widget :inactive))
! 	   (let ((parent (widget-get widget :parent)))
! 	     (or (null parent) 
! 		 (widget-apply parent :active))))))
  
  (defun widget-default-deactivate (widget)
    "Make WIDGET inactive for user modifications."
***************
*** 2860,2865 ****
--- 2861,2867 ----
  		 widget 'visibility
  		 :help-echo "Show or hide rest of the documentation."
  		 :off "More"
+ 		 :always-active t
  		 :action 'widget-parent-action
  		 shown)
  		buttons)