eliminate empty mm-alternatives too

eliminate empty mm-alternatives too

[jidanni]

You know, sometimes
  X-Spam-Report:
	*  0.7 MPART_ALT_DIFF BODY: HTML and text parts are different

Indeed sometimes there is that part, but nothing much in it:

--=_NextPart_2rfkindysadvnqw3nerasdf
Content-Type: text/DOESN'T MATTER
Content-Transfer-Encoding: quoted-printable



--=_NextPart_2rfkindysadvnqw3nerasdf


In such cases, could gnus please just show the other part,
I.e., eliminate the empty part as one of the candidates before further
weeding out mm-discouraged-alternatives. Thanks.

Re: eliminate empty mm-alternatives too

[Greg Troxel]

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]


jidanni@jidanni.org writes:

> You know, sometimes
>   X-Spam-Report:
> 	*  0.7 MPART_ALT_DIFF BODY: HTML and text parts are different
>
> Indeed sometimes there is that part, but nothing much in it:
>
> --=_NextPart_2rfkindysadvnqw3nerasdf
> Content-Type: text/DOESN'T MATTER
> Content-Transfer-Encoding: quoted-printable
>
>
>
> --=_NextPart_2rfkindysadvnqw3nerasdf

This mail is defective; I score it even higher.

> In such cases, could gnus please just show the other part,
> I.e., eliminate the empty part as one of the candidates before further
> weeding out mm-discouraged-alternatives. Thanks.

But yes, that makes sense.  If it does show the html part when text was
requested via discouraged-alternatives, I think it makes sense to add

X-Gnus-Warning: suppressing empty text/plain part

so the reader knows the mail was bogus.


[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]

Re: eliminate empty mm-alternatives too

[Lars Magne Ingebrigtsen]

jidanni@jidanni.org writes:

> In such cases, could gnus please just show the other part,
> I.e., eliminate the empty part as one of the candidates before further
> weeding out mm-discouraged-alternatives. Thanks.

Good idea.  Fixed and pushed.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: eliminate empty mm-alternatives too

[David Edmondson]

* larsi@gnus.org [2011-01-11 Tue 19:21]
> jidanni@jidanni.org writes:
>
>> In such cases, could gnus please just show the other part,
>> I.e., eliminate the empty part as one of the candidates before further
>> weeding out mm-discouraged-alternatives. Thanks.
>
> Good idea.  Fixed and pushed.

This appears to cause trouble when a multipart/alternative part contains
text/plain and multipart/related parts (the latter containing text/html
and image/jpeg).

There's an error thrown - no buffer named "multipart/related" exists.

Re: eliminate empty mm-alternatives too

[Lars Ingebrigtsen]

David Edmondson <dme@dme.org> writes:

> There's an error thrown - no buffer named "multipart/related" exists.

Could you send me an example message that shows this bug?

Or `(setq debug-on-error t)' and post the backtrace.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: eliminate empty mm-alternatives too

[David Edmondson]

* larsi@gnus.org [2011-01-22 Sat 02:53]
> David Edmondson <dme@dme.org> writes:
>
>> There's an error thrown - no buffer named "multipart/related" exists.
>
> Could you send me an example message that shows this bug?
>
> Or `(setq debug-on-error t)' and post the backtrace.

It was fixed by:

    (mm-preferred-alternative-precedence): Don't bug out on nested related parts.

Thanks!

Re: eliminate empty mm-alternatives too

[Julien Barnier]

Hi,

David Edmondson <dme <at> dme.org> writes:

> It was fixed by:
>
> (mm-preferred-alternative-precedence): Don't bug out on nested related parts.

I just met the same problem as you describe, with a "no buffer named
multipart/related" error while trying to display this kind of mail.

I try to understand the fix you are talking about, but unfortunately I can't
make it work. Do you redefine the mm-preferred-alternative-precedence function
?

Thanks a lot in advance !

Julien

Re: eliminate empty mm-alternatives too

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

On Wed, Jan 26 2011, Julien Barnier wrote:

> I try to understand the fix you are talking about, but unfortunately I can't
> make it work. Do you redefine the mm-preferred-alternative-precedence function
> ?

No, he just git pull-ed and rebuilt Gnus. :)

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]