Re: imap.el - problem (?) in imap.el

Re: imap.el - problem (?) in imap.el

[Rory Molinari]

Simon Josefsson jas@extundo.com writes:

> Rory Molinari <h571pufwjtlf001@sneakemail.com> writes:
>
>> Hi,
>>
>> I use the fastmail.fm email service, and access my mail through gnus
>> using fastmail's IMAP server.  I had some trouble getting it to work at
>> first, and finally tracked down the problem to the imap-parse-greeting
>> function in imap.el.
>>
>> Where imap-parse-greeting was expecting to see "* OK", the fastmail.fm
>> server produces "SERVER * OK".  The parsing of greetings was failing,
>> and gnus interpreted this as a failure to connect to the server.
>
> Are you using some funky proxy or something?  I don't see SERVER when
> I connect to it:
>
> [jas@localhost jas]$ telnet fastmail.fm imap
> Trying 209.61.183.86...
> Connected to fastmail.fm (209.61.183.86).
> Escape character is '^]'.
> * OK IMAP4 Ready www.fastmail.fm
>
> In any case I'd say a server the returned SERVER * OK foo as a
> greeting was quite broken.

Evidently I am completely out of date.  I had these problems about a
month ago and "fixed" them at that time.  I only just today got around
to posting my patch to the list. 

I just tried connecting to fastmail.fm without my modifications to
imap.el, and it worked perfectly.  Either fastmail.fm's IMAP server was
broken a month ago or (much more likely) I got myself totally confused.

In any case, please ignore my previous post, and the patch it contains.

Cheers,
Rory

Re: imap.el - problem (?) in imap.el

[Simon Josefsson]

Rory Molinari <h571pufwjtlf001@sneakemail.com> writes:

> Hi,
>
> I use the fastmail.fm email service, and access my mail through gnus
> using fastmail's IMAP server.  I had some trouble getting it to work at
> first, and finally tracked down the problem to the imap-parse-greeting
> function in imap.el.
>
> Where imap-parse-greeting was expecting to see "* OK", the fastmail.fm
> server produces "SERVER * OK".  The parsing of greetings was failing,
> and gnus interpreted this as a failure to connect to the server.

Are you using some funky proxy or something?  I don't see SERVER when
I connect to it:

[jas@localhost jas]$ telnet fastmail.fm imap
Trying 209.61.183.86...
Connected to fastmail.fm (209.61.183.86).
Escape character is '^]'.
* OK IMAP4 Ready www.fastmail.fm

In any case I'd say a server the returned SERVER * OK foo as a
greeting was quite broken.

imap.el - problem (?) in imap.el

[Rory Molinari]

Hi,

I use the fastmail.fm email service, and access my mail through gnus
using fastmail's IMAP server.  I had some trouble getting it to work at
first, and finally tracked down the problem to the imap-parse-greeting
function in imap.el.

Where imap-parse-greeting was expecting to see "* OK", the fastmail.fm
server produces "SERVER * OK".  The parsing of greetings was failing,
and gnus interpreted this as a failure to connect to the server.

Here is a simple unified diff that fixed the problem for me.  It is
against the Oort 0.05 release.

Let me know if I did the diff wrong.

Cheers,
Rory

--- imap.el.dist	Fri May  3 13:32:27 2002
+++ imap.el	Fri May  3 13:32:27 2002
@@ -1928,11 +1928,11 @@
 
 (defun imap-parse-greeting ()
   "Parse a IMAP greeting."
-  (cond ((looking-at "\\* OK ")
+  (cond ((looking-at "\\(Server \\)?\\* OK ")
 	 (setq imap-state 'nonauth))
-	((looking-at "\\* PREAUTH ")
+	((looking-at "\\(Server \\)?\\* PREAUTH ")
 	 (setq imap-state 'auth))
-	((looking-at "\\* BYE ")
+	((looking-at "\\(Server \\)?\\* BYE ")
 	 (setq imap-state 'closed))))
 
 ;;   response        = *(continue-req / response-data) response-done