Backtrace on agent fetching

Backtrace on agent fetching

[Kai Großjohann]

I got a backtrace on agent fetching:

Debugger entered--Lisp error: (wrong-type-argument listp #[nil "À ?" [gnus-agent-read-p] 1])
  gnus-function-implies-unread-1(#[nil "À ?" [gnus-agent-read-p] 1])
  gnus-predicate-implies-unread((not read))
  gnus-agent-fetch-headers("nntp+gmane:gmane.comp.db.dbworld")
  gnus-agent-fetch-group-1("nntp+gmane:gmane.comp.db.dbworld" (nntp "gmane" (nntp-address "news.gmane.org")))
  gnus-agent-fetch-session()
  call-interactively(gnus-agent-fetch-session)

I applied the following patch to make it go away.  I am, however,
quite unsure if this was the right thing to do.

Does anyone know what's the right thing to do?

Index: lisp/gnus-agent.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-agent.el,v
retrieving revision 6.151
diff -u -r6.151 gnus-agent.el
--- lisp/gnus-agent.el	4 Mar 2003 01:43:59 -0000	6.151
+++ lisp/gnus-agent.el	4 Mar 2003 10:55:59 -0000
@@ -2344,7 +2344,7 @@
          nil)
         ((not function)
          nil)
-        ((symbolp function)
+        ((gnus-functionp function)
          'ignore)
         ((memq (car function) '(or and not))
          (apply (car function)

-- 
A preposition is not a good thing to end a sentence with.

Re: Backtrace on agent fetching

[Kevin Greiner]

kai.grossjohann@uni-duisburg.de (Kai Großjohann) writes:

> I got a backtrace on agent fetching:
>
> Debugger entered--Lisp error: (wrong-type-argument listp #[nil "À ?" [gnus-agent-read-p] 1])
>   gnus-function-implies-unread-1(#[nil "À ?" [gnus-agent-read-p] 1])
>   gnus-predicate-implies-unread((not read))
>   gnus-agent-fetch-headers("nntp+gmane:gmane.comp.db.dbworld")
>   gnus-agent-fetch-group-1("nntp+gmane:gmane.comp.db.dbworld" (nntp "gmane" (nntp-address "news.gmane.org")))
>   gnus-agent-fetch-session()
>   call-interactively(gnus-agent-fetch-session)
>
> I applied the following patch to make it go away.  I am, however,
> quite unsure if this was the right thing to do.
>
> Does anyone know what's the right thing to do?
>
> Index: lisp/gnus-agent.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/gnus-agent.el,v
> retrieving revision 6.151
> diff -u -r6.151 gnus-agent.el
> --- lisp/gnus-agent.el	4 Mar 2003 01:43:59 -0000	6.151
> +++ lisp/gnus-agent.el	4 Mar 2003 10:55:59 -0000
> @@ -2344,7 +2344,7 @@
>           nil)
>          ((not function)
>           nil)
> -        ((symbolp function)
> +        ((gnus-functionp function)
>           'ignore)
>          ((memq (car function) '(or and not))
>           (apply (car function)
>

We may need both to handle code being interpreted versus compiled.  I
going to be off-line all day, if you have something that works, please
check it in.

Thanks,
Kevin

Re: Backtrace on agent fetching

[Kai Großjohann]

Kevin Greiner <kgreiner@xpediantsolutions.com> writes:

> We may need both to handle code being interpreted versus compiled.  I
> going to be off-line all day, if you have something that works, please
> check it in.

gnus-functionp handles both.  So I'll commit this.  Thanks for your
heads-up.
-- 
A preposition is not a good thing to end a sentence with.