Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Leo <sdl.web@gmail.com>
Cc: Gnus <ding@gnus.org>, emacs-devel@gnu.org
Subject: gmm-tool-bar-style (was: svn icons in the toolbar)
Date: Wed, 26 Sep 2007 22:11:10 +0200	[thread overview]
Message-ID: <v9hclhp4pt.fsf_-_@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <m2odgg4ql4.fsf@cam.ac.uk> (Leo's message of "Thu, 06 Sep 2007 00:53:11 +0100")

On Thu, Sep 02 2007, Leo wrote:
> Have you noticed that the tool-bar in Gnus's article buffer, summary
> buffer and message buffer has gone back to using the old-fashioned icons
> or missing a couple of icons. See:
[ Screen shots, see http://article.gmane.org/gmane.emacs.devel/77591 ]

On Thu, Sep 06 2007, Leo wrote:
> My Emacs was installed from a fresh CVS check out on the first build
> which you can see from 23.0.50.1.
>
> Toobar and menubar are initially disabled.
> Emacs.menuBar: 0
> Emacs.toolBar: 0

[ -xrm 'Emacs.toolBar:0' ]

> Turn on tool-bar-mode and switch to gnus buffers and you can see the
> weird tool-bar shown up.

I think similar problems appear with Emacs 22.1.  

Maybe the bug is the default value of `gmm-tool-bar-style':

--8<---------------cut here---------------start------------->8---
(defcustom gmm-tool-bar-style
  (if (and (boundp 'tool-bar-mode)
	   tool-bar-mode
	   (and (fboundp 'display-visual-class)
		(not (memq (display-visual-class)
			   (list 'static-gray 'gray-scale
				 'static-color 'pseudo-color)))))
      'gnome
    'retro)
  "Prefered tool bar style."
  :type '(choice (const :tag "GNOME style" gnome)
		 (const :tag "Retro look"  retro))
  :group 'gmm)
--8<---------------cut here---------------end--------------->8---

I don't exactly remember what I had in mind with testing for non-nil
`tool-bar-mode'.  Could you try the following patch?

--8<---------------cut here---------------start------------->8---
--- gmm-utils.el	27 Apr 2007 10:39:17 +0200	7.33
+++ gmm-utils.el	26 Sep 2007 22:01:11 +0200	
@@ -208,7 +281,6 @@
 
 (defcustom gmm-tool-bar-style
   (if (and (boundp 'tool-bar-mode)
-	   tool-bar-mode
 	   (and (fboundp 'display-visual-class)
 		(not (memq (display-visual-class)
 			   (list 'static-gray 'gray-scale
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

           reply	other threads:[~2007-09-26 20:11 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <m2odgg4ql4.fsf@cam.ac.uk>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v9hclhp4pt.fsf_-_@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).