gmm-tool-bar-style (was: svn icons in the toolbar)

gmm-tool-bar-style (was: svn icons in the toolbar)

[Reiner Steib]

On Thu, Sep 02 2007, Leo wrote:
> Have you noticed that the tool-bar in Gnus's article buffer, summary
> buffer and message buffer has gone back to using the old-fashioned icons
> or missing a couple of icons. See:
[ Screen shots, see http://article.gmane.org/gmane.emacs.devel/77591 ]

On Thu, Sep 06 2007, Leo wrote:
> My Emacs was installed from a fresh CVS check out on the first build
> which you can see from 23.0.50.1.
>
> Toobar and menubar are initially disabled.
> Emacs.menuBar: 0
> Emacs.toolBar: 0

[ -xrm 'Emacs.toolBar:0' ]

> Turn on tool-bar-mode and switch to gnus buffers and you can see the
> weird tool-bar shown up.

I think similar problems appear with Emacs 22.1.  

Maybe the bug is the default value of `gmm-tool-bar-style':

--8<---------------cut here---------------start------------->8---
(defcustom gmm-tool-bar-style
  (if (and (boundp 'tool-bar-mode)
	   tool-bar-mode
	   (and (fboundp 'display-visual-class)
		(not (memq (display-visual-class)
			   (list 'static-gray 'gray-scale
				 'static-color 'pseudo-color)))))
      'gnome
    'retro)
  "Prefered tool bar style."
  :type '(choice (const :tag "GNOME style" gnome)
		 (const :tag "Retro look"  retro))
  :group 'gmm)
--8<---------------cut here---------------end--------------->8---

I don't exactly remember what I had in mind with testing for non-nil
`tool-bar-mode'.  Could you try the following patch?

--8<---------------cut here---------------start------------->8---
--- gmm-utils.el	27 Apr 2007 10:39:17 +0200	7.33
+++ gmm-utils.el	26 Sep 2007 22:01:11 +0200	
@@ -208,7 +281,6 @@
 
 (defcustom gmm-tool-bar-style
   (if (and (boundp 'tool-bar-mode)
-	   tool-bar-mode
 	   (and (fboundp 'display-visual-class)
 		(not (memq (display-visual-class)
 			   (list 'static-gray 'gray-scale
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/