From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de>
Subject: Re: [PATCH] Better handling for Microsoft citations (resend)
Date: Wed, 19 Feb 2003 19:00:07 +0100 [thread overview]
Message-ID: <v9r8a4qhg8.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <84adh0zabw.fsf@lucy.is.informatik.uni-duisburg.de> (kai.grossjohann@uni-duisburg.de's message of "Thu, 13 Feb 2003 12:30:59 +0100")
[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]
On Thu, Feb 13 2003, Kai Großjohann wrote:
> Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:
>
>> On Wed, Feb 12 2003, Michael Shields wrote:
>>
>>> +(defcustom gnus-unsightly-citation-regexp
>>> + "^-----Original Message-----\nFrom: \\(.+\n\\)+\n"
>>> + "Regexp matching Microsoft-type rest-of-message citations."
[...]
>> Wouldn't it be better to use a name starting with `gnus-cite-' for
>> consistency?
>
> I agree. Michael, what do you think?
No response or objection from Michael?
I propose to rename it and apply the attached patch (patch to
ChangeLog files is also included):
--8<---------------cut here---------------start------------->8---
2003-02-19 Reiner Steib <Reiner.Steib@gmx.de>
* GNUS-NEWS: Renamed `gnus-unsightly-citation-regexp' to
`gnus-cite-unsightly-citation-regexp'.
2003-02-19 Reiner Steib <Reiner.Steib@gmx.de>
* gnus-cite.el (gnus-cite-unsightly-citation-regexp)
(gnus-cite-parse): Renamed `gnus-unsightly-citation-regexp' to
`gnus-cite-unsightly-citation-regexp'.
--8<---------------cut here---------------end--------------->8---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-cite.unsightly.patch --]
[-- Type: text/x-patch, Size: 3087 bytes --]
Index: GNUS-NEWS
===================================================================
RCS file: /usr/local/cvsroot/gnus/GNUS-NEWS,v
retrieving revision 6.43
diff -u -r6.43 GNUS-NEWS
--- GNUS-NEWS 18 Feb 2003 20:42:51 -0000 6.43
+++ GNUS-NEWS 19 Feb 2003 18:06:58 -0000
@@ -10,10 +10,11 @@
** Better handling of Microsoft citation styles
-Gnus now tries to recognize the mangled header block that some
-Microsoft mailers use to indicate that the rest of the message is a
-citation, even though it is not quoted in any way. The variable
-`gnus-unsightly-citation-regexp' matches the start of these citations.
+Gnus now tries to recognize the mangled header block that some Microsoft
+mailers use to indicate that the rest of the message is a citation, even
+though it is not quoted in any way. The variable
+`gnus-cite-unsightly-citation-regexp' matches the start of these
+citations.
** gnus-article-skip-boring
Index: ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/ChangeLog,v
retrieving revision 6.44
diff -u -r6.44 ChangeLog
--- ChangeLog 18 Feb 2003 20:43:17 -0000 6.44
+++ ChangeLog 19 Feb 2003 18:06:58 -0000
@@ -1,3 +1,8 @@
+2003-02-19 Reiner Steib <Reiner.Steib@gmx.de>
+
+ * GNUS-NEWS: Renamed `gnus-unsightly-citation-regexp' to
+ `gnus-cite-unsightly-citation-regexp'.
+
2003-02-18 Simon Josefsson <jas@extundo.com>
* GNUS-NEWS: Talk about canlock more.
Index: lisp/gnus-cite.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-cite.el,v
retrieving revision 6.22
diff -u -r6.22 gnus-cite.el
--- lisp/gnus-cite.el 12 Feb 2003 20:36:45 -0000 6.22
+++ lisp/gnus-cite.el 19 Feb 2003 18:06:58 -0000
@@ -120,7 +120,7 @@
:group 'gnus-cite
:type 'regexp)
-(defcustom gnus-unsightly-citation-regexp
+(defcustom gnus-cite-unsightly-citation-regexp
"^-----Original Message-----\nFrom: \\(.+\n\\)+\n"
"Regexp matching Microsoft-type rest-of-message citations."
:group 'gnus-cite
@@ -749,7 +749,7 @@
(setq line (1+ line)))
;; Horrible special case for some Microsoft mailers.
(goto-char (point-min))
- (when (re-search-forward gnus-unsightly-citation-regexp max t)
+ (when (re-search-forward gnus-cite-unsightly-citation-regexp max t)
(setq begin (count-lines (point-min) (point)))
(setq end (count-lines (point-min) max))
(setq entry nil)
Index: lisp/ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 6.2014
diff -u -r6.2014 ChangeLog
--- lisp/ChangeLog 19 Feb 2003 06:55:27 -0000 6.2014
+++ lisp/ChangeLog 19 Feb 2003 18:06:59 -0000
@@ -1,3 +1,9 @@
+2003-02-19 Reiner Steib <Reiner.Steib@gmx.de>
+
+ * gnus-cite.el (gnus-cite-unsightly-citation-regexp)
+ (gnus-cite-parse): Renamed `gnus-unsightly-citation-regexp' to
+ `gnus-cite-unsightly-citation-regexp'.
+
2003-02-19 Katsumi Yamaoka <yamaoka@jpl.org>
* gnus-msg.el (gnus-copy-article-buffer): Copy an article header
[-- Attachment #3: Type: text/plain, Size: 116 bytes --]
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- PGP key available via WWW http://rsteib.home.pages.de/
next prev parent reply other threads:[~2003-02-19 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-12 18:03 Michael Shields
2003-02-12 20:25 ` Kai Großjohann
2003-02-12 20:27 ` Kai Großjohann
2003-02-12 23:41 ` Michael Shields
2003-02-13 11:29 ` Kai Großjohann
2003-02-12 22:30 ` Reiner Steib
2003-02-13 11:30 ` Kai Großjohann
2003-02-19 18:00 ` Reiner Steib [this message]
2003-02-19 19:08 ` Kai Großjohann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9r8a4qhg8.fsf@marauder.physik.uni-ulm.de \
--to=4.uce.03.r.s@nurfuerspam.de \
--cc=reiner.steib@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).