Bugs in deuglify.el and message.el (was: Current CVS broken)

Bugs in deuglify.el and message.el (was: Current CVS broken)

[Reiner Steib]

On Wed, Jan 08 2003, Robin S. Socha wrote:

> See attached backtrace. CVS updated as of 2hrs ago.
>
> Also, W k breaks Gnus for me, but I'm too lazy to restart it right
> now. ;)
[...]
> Signaling: (error "fourth element of a button must be a string (the
> label suffix)" ["Flag As Important" message-insert-importance-high
> \,@ (if (featurep (quote xemacs)) (quote (t)) (quote (:help "Mark
> this message as important")))]) [...]

I think we see two errors/problems here:

(1) deuglify.el

With `XEmacs 21.1 (patch 14) "Cuyahoga Valley" [Lucid]
(i386-suse-linux, Mule) of Wed May 16 2001 on knuth' (I know, this is
ancient), I get the following backtrace after hitting `W k' on this
article:

| Newsgroups: de.comp.gnu
| Date: Wed, 8 Jan 2003 01:45:38 +0100
| Message-ID: <avfsbf$f5u7u$1@ID-68477.news.dfncis.de>
 
--8<---------------cut here---------------start------------->8---
Signaling: (wrong-type-argument extent-live-p #<destroyed extent>)
  gnus-overlay-end(#<destroyed extent>)
  gnus-cite-delete-overlays()
  gnus-cite-parse-maybe(t)
  gnus-article-highlight-citation(t)
  gnus-article-highlight(t)
  (save-current-buffer (set-buffer (or gnus-article-buffer ...))
  (gnus-article-highlight t) (gnus-treat-article nil) (gnus-run-hooks
  (quote gnus-article-prepare-hook))))
  (with-current-buffer (or gnus-article-buffer (current-buffer))
  (gnus-article-highlight t) (gnus-treat-article nil) (gnus-run-hooks
  (quote gnus-article-prepare-hook))))
  (lambda nil "Deuglify broken Outlook (Express) articles and
  redisplay." (interactive) (gnus-outlook-deuglify-article)
  (with-current-buffer (or gnus-article-buffer ...)
  (gnus-article-highlight t) (gnus-treat-article nil) (gnus-run-hooks
  ...)))()
  call-interactively(gnus-article-outlook-deuglify-article)
--8<---------------cut here---------------end--------------->8---

(2) message.el

Robin's backtrace corresponds to code from message.el.  AFAICS, the
backtrace is not related to deuglify.el.  Using `a' in the *Group*
buffer gives me the this backtrace (with XEmacs 21.1, see above):

--8<---------------cut here---------------start------------->8---
Signaling: (error "fourth element of a button must be a string (the
  label suffix)" ["Flag As Important" message-insert-importance-high
  \,@ (if (featurep (quote xemacs)) (quote (t)) (quote (:help "Mark
  this message as important")))])
  signal(error ("fourth element of a button must be a string (the
  label suffix)" ["Flag As Important" message-insert-importance-high
  \,@ (if ... ... ...)]))
  check-menu-syntax(("Field" ["Fetch To" message-insert-to t] ["Fetch
  Newsgroups" message-insert-newsgroups t] "----" ["To"
  message-goto-to t] ["From" message-goto-from t] ["Subject"
  message-goto-subject t] ["Change subject..." message-change-subject
  t] ["Cc" message-goto-cc t] ["Bcc" message-goto-bcc t] ["Fcc"
  message-goto-fcc t] ["Reply-To" message-goto-reply-to t] ["Flag As
  Important" message-insert-importance-high \,@ (if ... ... ...)]
  ["Flag As Unimportant" message-insert-importance-low \,@ (if
  ... ... ...)]
[...]
  ["Followup-To" message-goto-followup-to t] ["Crosspost /
  Followup-To..." message-cross-post-followup-to t] ["Distribution"
  message-goto-distribution t] ["X-No-Archive:"
  message-add-archive-header t] "----" ["Send to list only"
  message-to-list-only t] ["Mail-Followup-To"
  message-goto-mail-followup-to t] ["Reduce To: to Cc:"
  message-reduce-to-to-cc t] "----" ["Sort Headers"
  message-sort-headers t] ["Goto Body" message-goto-body t] ["Goto
  Signature" message-goto-signature t]) #<keymap 7 entries 0x4230>)
  message-mode()
  message-pop-to-buffer("*posting*")
  message-news("")
  gnus-post-news(post "" nil nil nil nil t)
  gnus-group-post-news(nil)
  call-interactively(gnus-group-post-news)
--8<---------------cut here---------------end--------------->8---

Maybe something is wrong with the following (and similar)
definition(s):

(easy-menu-define
  message-mode-field-menu message-mode-map ""
  '("Field"
[...]
    ["Flag As Important" message-insert-importance-high
     ,@(if (featurep 'xemacs) '(t)
	 '(:help "Mark this message as important"))]
[...]

I guess it's better to put this on ding (Mail-Followup-To: ding@gnus.org).

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: Bugs in deuglify.el and message.el

[Reiner Steib]

On Wed, Jan 08 2003, Reiner Steib wrote:

> I think we see two errors/problems here:
>
> (1) deuglify.el

The same problem has been reported in gnu.emacs.gnus:

,----
| From: Vincent Bernat <vincent.bernat@raysa.org>
| Subject: Outlook deuglify broken in latest Oort
| Newsgroups: gnu.emacs.gnus
| Date: Thu, 09 Jan 2003 09:26:45 +0100
| Message-ID: <m3bs2qvid6.fsf@neo.loria>
| User-Agent: Gnus/5.090011 (Oort Gnus v0.11) XEmacs/21.4 (Military
|   Intelligence, i386-debian-linux)
`----

> (2) message.el

Jesper Harder has fixed this bug yesterday.

> (easy-menu-define
>   message-mode-field-menu message-mode-map ""
>   '("Field"

It was my fault, I forgot to use »`« here.  Thank you, Jesper.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/