Followup leaves one space too many

Followup leaves one space too many

[Kai Großjohann]

When I followup to something like the following:

/----
| > > foo
| > > bar
\----

Then I get

/----
| > > > foo
| >> > bar
\----

Note that the first line has "> > >" rather than ">> >".  I think the
first line should have ">> >", like all the subsequent lines.

Opinions?

kai
-- 
Abort this operation?   [OK]  [Cancel]

Re: Followup leaves one space too many

[Harry Putnam]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> When I followup to something like the following:
>
> /----
> | > > foo
> | > > bar
> \----
>
> Then I get
>
> /----
> | > > > foo
> | >> > bar
> \----
>
> Note that the first line has "> > >" rather than ">> >".  I think the
> first line should have ">> >", like all the subsequent lines.
>
> Opinions?

I don't see the behavior you describe..

Making a fake sample by editing a message in an nnml group so it says

> > foo
> > bar

Then following up to it... I see

>> > foo
>> > bar
-- 
Every improvement in communication makes the bore more terrible.
                -- Frank Moore Colby --

Re: Followup leaves one space too many

[Paul Jarc]

Harry Putnam <reader@newsguy.com> wrote:
> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
>> Then I get
>>
>> /----
>> | > > > foo
>> | >> > bar
>> \----
>
> I don't see the behavior you describe..

It seems to be related to empty lines after attributions.  This case
gets mangled:
> Someone wrote:
> > blah
>> blah

This case doesn't:
> Someone wrote:
> 
>> blah
>> blah

If you start a response to this message, you should see it.


paul

Re: Followup leaves one space too many

[Simon Josefsson]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> When I followup to something like the following:
>
> /----
> | > > foo
> | > > bar
> \----
>
> Then I get
>
> /----
> | > > > foo
> | >> > bar
> \----
>
> Note that the first line has "> > >" rather than ">> >".  I think the
> first line should have ">> >", like all the subsequent lines.

Yes, this is a side effect of the AI added as a result of the
<vafu1zmu3hm.fsf@INBOX.auto.gnus.tok.lucy.cs.uni-dortmund.de> thread,
also see the followup-thread <iluwv4faiaw.fsf@barbar.josefsson.org>.

I think the patch I proposed works equally well in practice, and gives
less surprising results in the corner cases.  Maybe you can run with
this for a while and see if it works?  (The patch is againt current
CVS.)

--- message.el.~6.119.~	Sun Sep 30 12:21:44 2001
+++ message.el	Mon Oct  1 22:34:48 2001
@@ -2105,31 +2105,11 @@
 	(indent-rigidly start (mark t) message-indentation-spaces)
       (save-excursion
 	(goto-char start)
-	(let (last-line)
-	  ;; `last-line' describes the contents of the last line
-	  ;; encountered in the loop below. nil means "empty line",
-	  ;; spaces "line consisting entirely of whitespace",
-	  ;; right-angle "line starts with >", quoted "quote character
-	  ;; at the beginning of the line", text "the remaining cases".
 	  (while (< (point) (mark t))
-	    (cond
-	     ((eolp) 
+	  (if (looking-at ">")
 	      (insert message-yank-cited-prefix)
-	      (setq last-line nil))
-	     ((looking-at ">")
-	      (if (memq last-line '(nil spaces right-angle quoted))
-		  (progn
-		    (insert message-yank-cited-prefix)
-		    (setq last-line 'quoted))
-		(insert message-yank-prefix)
-		(setq last-line 'right-angle)))
-	     ((looking-at "\\s-+$")
-	      (insert message-yank-prefix)
-	      (setq last-line 'spaces))
-	     (t
-	      (insert message-yank-prefix)
-	      (setq last-line 'text)))
-	    (forward-line 1)))))
+ 	    (insert message-yank-prefix))
+ 	  (forward-line 1))))
     (goto-char start)))
 
 (defun message-yank-original (&optional arg)

Re: Followup leaves one space too many

[Kai Großjohann]

prj@po.cwru.edu (Paul Jarc) writes:

> Harry Putnam <reader@newsguy.com> wrote:
> > Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

Here...

>>> Then I get
>>>
>>> /----
>>> | > > > foo
>>> | >> > bar
>>> \----
>>
>> I don't see the behavior you describe..
>
> It seems to be related to empty lines after attributions.  This case
> gets mangled:
> > Someone wrote:

Here...

>> > blah
>>> blah
>
> This case doesn't:
> > Someone wrote:

Here...

>> 
>>> blah
>>> blah
>
> If you start a response to this message, you should see it.
>
>
> paul
>

Sorry for the full quote.  I just wanted to make sure that it is clear
what happens.  message-cite-function is
message-cite-original-without-signature, if that's relevant.

kai
-- 
Abort this operation?   [OK]  [Cancel]

Re: Followup leaves one space too many

[Kai Großjohann]

prj@po.cwru.edu (Paul Jarc) writes:

> Harry Putnam <reader@newsguy.com> wrote:
>> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
>>> Then I get

Look, ma, no space!

*Very* nice!

Thank you, Simon!

kai
-- 
Abort this operation?   [OK]  [Cancel]

Re: Followup leaves one space too many

[Kai Großjohann]

Simon Josefsson <jas@extundo.com> writes:

> I think the patch I proposed works equally well in practice, and gives
> less surprising results in the corner cases.  Maybe you can run with
> this for a while and see if it works?  (The patch is againt current
> CVS.)

Very nice.  The first try was positive.

I hope to remember to report on this in a few days.  But I'm afraid I
might forget, for I have this feeling that this patch is going to work
so well for me that I'll forget that something special is going on.

Isn't it the best when software gets out of your way and you don't
even notice it's there?  ;-)

kai
-- 
Abort this operation?   [OK]  [Cancel]

Re: Followup leaves one space too many

[Simon Josefsson]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> Simon Josefsson <jas@extundo.com> writes:
>
>> I think the patch I proposed works equally well in practice, and gives
>> less surprising results in the corner cases.  Maybe you can run with
>> this for a while and see if it works?  (The patch is againt current
>> CVS.)
>
> Very nice.  The first try was positive.
>
> I hope to remember to report on this in a few days.  But I'm afraid I
> might forget, for I have this feeling that this patch is going to work
> so well for me that I'll forget that something special is going on.

If you have time, see if you can find practical examples of quoted
text that ends up being quoted incorrectly with this version, using
the pathological examples from the threads discussed.  The AI version
does things wrong with lines such as:

Foo bar
> Foo bar

which actually seem quite common (attributions), but maybe the simple
versions misbehaves in some similar bad way.

The differences are quite subtle though, so you probably won't notice
them unless you search for them...

Re: Followup leaves one space too many

[Kai Großjohann]

Simon Josefsson <jas@extundo.com> writes:

> If you have time, see if you can find practical examples of quoted
> text that ends up being quoted incorrectly with this version, using
> the pathological examples from the threads discussed.  The AI version
> does things wrong with lines such as:
> 
> Foo bar
>> Foo bar

Looks good to me.  I'll keep an eye on it, though.

What do the others think?

kai
-- 
Abort this operation?   [OK]  [Cancel]