[patch] nnimap.el fix for messages missing message-id field

[patch] nnimap.el fix for messages missing message-id field

[Danny Siu]

In nnimap-split-articles, nnmail-cache-insert would fail if splitting
malformed messages¹ contain no message-id field (nnmail-fetch-field returns
nil).

Can someone with CVS write access commit the patch for me?

Thanks,

Index: nnimap.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnimap.el,v
retrieving revision 6.37
diff -r6.37 nnimap.el
1219,1220c1223,1225
< 			     (nnmail-cache-insert (nnmail-fetch-field
< 						   "message-id") to-group)))
---
>                              (let (msgid)
>                                (and (setq msgid (nnmail-fetch-field "message-id"))
>                                     (nnmail-cache-insert msgid to-group)))))

Index: ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 6.1460
diff -r6.1460 ChangeLog
0a1,5
> 2002-07-31  Danny Siu  <dsiu@adobe.com>
> 
> 	* nnimap.el (nnimap-split-articles): do not call nnmail-fetch-field 
> 	when splitting malformed messages without message-id
> 


Footnotes: 
¹  usually come for machine generated emails.  in my case, TWiki sent me an 
auto generated email thur Netscape Messaging Server.

-- 
Danny Siu

Re: [patch] nnimap.el fix for messages missing message-id field

[Simon Josefsson]

Danny Siu <dsiu@adobe.com> writes:

> In nnimap-split-articles, nnmail-cache-insert would fail if splitting
> malformed messages¹ contain no message-id field (nnmail-fetch-field returns
> nil).
>
> Can someone with CVS write access commit the patch for me?

Done, thanks.

Re: [patch] nnimap.el fix for messages missing message-id field

[Kai Großjohann]

Danny Siu <dsiu@adobe.com> writes:

>>                              (let (msgid)
>>                                (and (setq msgid (nnmail-fetch-field "message-id"))
>>                                     (nnmail-cache-insert msgid to-group)))))

Why the setq?  Why not just

(let ((msgid (nnmail-fetch-field "message-id")))
  (when msgid
    (nnmail-cache-insert msgid to-group)))

kai
-- 
A large number of young women don't trust men with beards.  (BFBS Radio)