[gnu.emacs.gnus] Re: Group parameters and gnus-boring-article-headers

[gnu.emacs.gnus] Re: Group parameters and gnus-boring-article-headers

[Kai Großjohann]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

What do you guys (and gals?) think about the following patch by Tony?
I think it is the right thing to do.

kai
-- 
I like BOTH kinds of music.



[-- Attachment #2: Type: message/rfc822, Size: 3287 bytes --]

From: tbennett@nvidia.com (Tony E. Bennett)
Subject: Re: Group parameters and gnus-boring-article-headers
Date: 18 Oct 2000 09:57:34 -0400
Message-ID: <m3snpuz1yp.fsf@uh-oh.nvidia.com>


Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> On 16 Oct 2000, Tony E. Bennett wrote:
> 
> > Here is a patch that seems to fix this for me.
> 
> One thing to try is this: suppose you have group A which sets local
> variable foo to 1, and you have group B which sets local variable bar
> to 1.  And then you enter group A, display a message, enter group B,
> also display a message.  Does the article buffer then have both local
> variables?

Whoops, it was accumulating local variables.

This replacement patch works for me and fixes the problem you mention
where later article buffers see superset of all previously set locals.

If there are any locals that should persist in *article* buffer, then
this patch would break them.


{~/.../gnus/gnus/lisp}. diff -u ORIG/gnus-5.8.7/lisp/gnus-art.el .
--- ORIG/gnus-5.8.7/lisp/gnus-art.el	Sat Jul  1 07:10:43 2000
+++ ./gnus-art.el	Wed Oct 18 09:19:34 2000
@@ -2663,6 +2663,10 @@
     (if (get-buffer name)
 	(save-excursion
 	  (set-buffer name)
+          ;; destroy all locals in the *Article* buffer
+          ;; so that group parameters copied from the *Summary* buffer
+          ;; don't accumulate from group to group
+          (kill-all-local-variables)
 	  (when gnus-article-mime-handles
 	    (mm-destroy-parts gnus-article-mime-handles))
 	  (buffer-disable-undo)
@@ -2710,6 +2714,10 @@
       (save-excursion
 	(gnus-article-setup-buffer)
 	(set-buffer gnus-article-buffer)
+        ;; Copy all locals from *Summary* buffer to our *Article* buffer.
+        ;; Primary benefit is to allow article-buffer specific variables
+        ;; to be set in the group parameters, eg: gnus-treat-hide-boring-headers.
+        (message-clone-locals gnus-summary-buffer)
 	;; Deactivate active regions.
 	(when (and (boundp 'transient-mark-mode)
 		   transient-mark-mode)
-- 
--tony              tbennett@nvidia.com

Re: [gnu.emacs.gnus] Re: Group parameters and gnus-boring-article-headers

[ShengHuo ZHU]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> What do you guys (and gals?) think about the following patch by Tony?
> I think it is the right thing to do.

Because Gnus may dynamically bind some variables (maybe local
variables in the summary buffer) then switch to the article buffer,
cloning local variables in the article buffer may cause some problems.
The following example illustrates this kind of problems.  In the
article buffer, it still uses the local value, "Article", instead of
the dynamic one, "Dynamic".

    (let (art-buf sum-buf msg)
      (with-temp-buffer
        (setq art-buf (current-buffer))
        (set (make-local-variable 'info) "Article")
        (with-temp-buffer
          (setq sum-buf (current-buffer))
          (set (make-local-variable 'info) "Summary")
          (let ((info "Dynamic"))
            (set-buffer art-buf)
            (setq msg info))
          (set-buffer sum-buf)
          (setq msg (concat msg "; " info))))
      msg)

As an alternative solution, I've installed a patch which enables users
explicitly specify which summary-buffer-local variables should be
globalized (see `gnus-newsgroup-variables'), so that the values could
be used in the article buffer.

ShengHuo