Re: RMail functionality I miss

Re: RMail functionality I miss

[Karl Kleinpaste]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> I've now implemented this.  (This is the first test.  :-) )

Sweep region in *Article* buffer, hit `F', and get this trace:

Signaling: (void-variable mark-active)
  #<compiled-function nil "...(24)" [mark-active gnus-article-current article gnus-summary-followup mark] 4 ("/home/karl/Emacs/Gnus/gnus-art.elc" . 125119) nil>()
  call-interactively(gnus-article-followup-with-original)

Re: RMail functionality I miss

[Lars Magne Ingebrigtsen]

Karl Kleinpaste <karl@charcoal.com> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> I've now implemented this.  (This is the first test.  :-) )
>
> Sweep region in *Article* buffer, hit `F', and get this trace:
>
> Signaling: (void-variable mark-active)

Another Emacs/XEmacs incompatibility I'd forgotten.

I find this is the code:

(defun gnus-region-active-p ()
  "Say whether the region is active."
  (and (boundp 'transient-mark-mode)
       transient-mark-mode
       (boundp 'mark-active)
       mark-active))

But that's not really what we want here, is it?  I want this to work
even though `transient-mark-mode' isn't in use.  So I could just make
a new one that doesn't include that test.

But the XEmacs version of this function is:

(defalias 'gnus-region-active-p 'region-active-p)

Does that include the transient mark mode stuff, or not?

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: RMail functionality I miss

[David Z Maze]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> (defun gnus-region-active-p ()
>   "Say whether the region is active."
>   (and (boundp 'transient-mark-mode)
>        transient-mark-mode
>        (boundp 'mark-active)
>        mark-active))
> 
> But that's not really what we want here, is it?  I want this to work
> even though `transient-mark-mode' isn't in use.  So I could just
> make a new one that doesn't include that test.

Are you sure you don't mean

(defun gnus-region-active-p ()
  "Say whether the region is active."
  (if (boundp 'transient-mark-mode)
      transient-mark-mode
    (if (boundp 'mark-active)
	mark-active
      nil)))

instead?  The function as quoted above returns t if
transient-mark-mode exists at all (either t or nil), and tries to
evaluate transient-mark-mode only if it's unbound.

-- 
David Maze             dmaze@mit.edu          http://www.mit.edu/~dmaze/
"Theoretical politics is interesting.  Politicking should be illegal."
	-- Abra Mitchell

Re: RMail functionality I miss

[Lars Magne Ingebrigtsen]

David Z Maze <dmaze@MIT.EDU> writes:

>> (defun gnus-region-active-p ()
>>   "Say whether the region is active."
>>   (and (boundp 'transient-mark-mode)
>>        transient-mark-mode
>>        (boundp 'mark-active)
>>        mark-active))

[...]

> The function as quoted above returns t if transient-mark-mode exists
> at all (either t or nil), and tries to evaluate transient-mark-mode
> only if it's unbound.

No, it evals to non-nil if all the four clauses eval to non-nil.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: RMail functionality I miss

[Karl Kleinpaste]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Yup.  Fix in Oort Gnus v0.05 (i. e., CVS).

Not yet, I'm afraid.

Sweep region in article, hit `R', get this stack trace:

Signaling: (wrong-type-argument numberp (103763 "Fix in Oort Gnus v0.05 (i. e., CVS)."))
  number-to-string((103763 "Fix in Oort Gnus v0.05 (i. e., CVS)."))
  gnus-inews-insert-draft-meta-information("nntp+news:gnu.emacs.gnus" ((103763 "Fix in Oort Gnus v0.05 (i. e., CVS).")))

(XEmacs 21.4.6, maximally-bleedy Oort [cvs update 5min ago].)