EasyPG and inline-PGP

EasyPG and inline-PGP

[Michael Piotrowski]

Hi,

When using EasyPG, and when viewing inline-PGP encrypted messages, I'm
prompted for my passphrase, but then only a

  [1. application/pgp-encrypted]...

button is displayed.  If I type K i, the decrypted text is displayed
correctly.

When using PGG, the decrypted text is displayed _immediately_ after
entering the passphrase, which I find much more convenient.

Do I need to make some setting or is this a bug?

Thanks and greetings

-- 
Michael Piotrowski, M.A.                               <mxp@dynalabs.de>
Public key at <http://www.dynalabs.de/mxp/pubkey.txt>

Re: EasyPG and inline-PGP

[Daiki Ueno]

>>>>> In <x67j0elhfb.fsf@aix.cs.uni-magdeburg.de> 
>>>>>	Michael Piotrowski <mxp@dynalabs.de> wrote:
> When using EasyPG, and when viewing inline-PGP encrypted messages, I'm
> prompted for my passphrase, but then only a

>   [1. application/pgp-encrypted]...

> button is displayed.  If I type K i, the decrypted text is displayed
> correctly.

I can't reproduce this.  Could you send me such a message?

Regards,
-- 
Daiki Ueno

Re: EasyPG and inline-PGP

[Michael Piotrowski]

On 2006-09-08, Daiki Ueno <ueno@unixuser.org> wrote:

>> When using EasyPG, and when viewing inline-PGP encrypted messages, I'm
>> prompted for my passphrase, but then only a
>
>>   [1. application/pgp-encrypted]...
>
>> button is displayed.  If I type K i, the decrypted text is displayed
>> correctly.
>
> I can't reproduce this.  Could you send me such a message?

I just did some more experiments and apparently this happens when the
encrypted message contains non-ASCII characters.  I'll send you a test
message.

Greetings

-- 
Michael Piotrowski, M.A.                               <mxp@dynalabs.de>
Public key at <http://www.dynalabs.de/mxp/pubkey.txt>

Re: EasyPG and inline-PGP

[Daiki Ueno]

>>>>> In <x6ejumjvky.fsf@aix.cs.uni-magdeburg.de> 
>>>>>	Michael Piotrowski <mxp@dynalabs.de> wrote:
> On 2006-09-08, Daiki Ueno <ueno@unixuser.org> wrote:

> >> When using EasyPG, and when viewing inline-PGP encrypted messages, I'm
> >> prompted for my passphrase, but then only a
> >
> >>   [1. application/pgp-encrypted]...
> >
> >> button is displayed.  If I type K i, the decrypted text is displayed
> >> correctly.
> >
> > I can't reproduce this.  Could you send me such a message?

> I just did some more experiments and apparently this happens when the
> encrypted message contains non-ASCII characters.  I'll send you a test
> message.

Ah, I misunderstood what is "inline-PGP".  The following patch will fix
the problem.  I'll commit it on Monday.

Index: mml2015.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/mml2015.el,v
retrieving revision 7.27
diff -u -r7.27 mml2015.el
--- mml2015.el	7 Sep 2006 08:30:07 -0000	7.27
+++ mml2015.el	8 Sep 2006 19:04:13 -0000
@@ -1053,14 +1053,13 @@
       (goto-char (point-min))
       (while (search-forward "\r\n" nil t)
 	(replace-match "\n" t t))
+      (mm-set-handle-multipart-parameter
+       mm-security-handle 'gnus-info "OK")
       (if (epg-context-result-for context 'verify)
 	  (mm-set-handle-multipart-parameter
-	   mm-security-handle 'gnus-info
-	   (concat "OK\n"
-		   (epg-verify-result-to-string
-		    (epg-context-result-for context 'verify))))
-	(mm-set-handle-multipart-parameter
-	 mm-security-handle 'gnus-info "OK")))))
+	   mm-security-handle 'gnus-details
+	   (epg-verify-result-to-string
+	    (epg-context-result-for context 'verify)))))))
 
 (defun mml2015-epg-verify (handle ctl)
   (catch 'error

Regards,
-- 
Daiki Ueno

Re: EasyPG and inline-PGP

[Michael Piotrowski]

On 2006-09-08, Daiki Ueno <ueno@unixuser.org> wrote:

>>>> When using EasyPG, and when viewing inline-PGP encrypted messages, I'm
>>>> prompted for my passphrase, but then only a
>>>>
>>>>   [1. application/pgp-encrypted]...
>>>>
>>>> button is displayed.  If I type K i, the decrypted text is displayed
>>>> correctly.
>>> 
>>> I can't reproduce this.  Could you send me such a message?
>
>> I just did some more experiments and apparently this happens when the
>> encrypted message contains non-ASCII characters.  I'll send you a test
>> message.
>
> Ah, I misunderstood what is "inline-PGP".

I'm sorry, I'd thought about writing something like
"non-RFC-3156-PGP-encrypted messages", but it felt a bit clumsy ;-)

> The following patch will fix the problem.  I'll commit it on Monday.

I just tried the patch, it now works fine.

Thanks for the quick fix!

Greetings

-- 
Michael Piotrowski, M.A.                               <mxp@dynalabs.de>
Public key at <http://www.dynalabs.de/mxp/pubkey.txt>